item_bonuses not working on costume type headgears(1024/2048/4096)

[Powlice]

Item Effects are not working, i want to know atleast the line where i can find and try to edit it, or any idea why the item effects won't work if it's intended not to work can we please make an advice how it will read the item effect on OnEquipScript or Script on itemdb.

Edited April 29, 2017 by Powlice

[Technoken]

You need to provide more info about it.

• what item effects?
• what item?
• what effect won't work if it's intended not to work?

Check this links also.

https://github.com/rathena/rathena/blob/master/doc/item_bonus.txt
https://github.com/rathena/rathena/blob/master/doc/item_db.txt

[Powlice]

Hello, thanks for replying to my topic, it is the default costume headgears made in item_db the one that uses the id bitmask 1024(Costume Top Headgear) in location of the equipment

as for example the bonus bstats,n; aint gonna work as long as the equipment is stated as (Costume Top - 1024).

 

 

Off Topic: Where i can find the edit button for my Topic's Title

[Technoken]

Can you tell me which specific item are you referring to? And if possible post the item script here.

1 hour ago, Powlice said:

Off Topic: Where i can find the edit button for my Topic's Title

You can edit your first post and edit title, then save.

[Powlice]

16 hours ago, Technoken said:

Can you tell me which specific item are you referring to? And if possible post the item script here.

You can edit your first post and edit title, then save.

Thanks,


BTW let me reproduce it with some screenshots

 

Item Script : 

Quote

27001,Blush,Blush,5,20,,0,,1,,1,0xFFFFFFFF,63,2,1024,,0,0,125,{ bonus bonus bMaxHPrate,10; },{},{}

 

 

No luck, on my server no matter what the item bonus on the script or onequipscript still it wont work as long as the headgear is a costume

Edited April 29, 2017 by Powlice

[Technoken]

I just test it and in my case it's working. It gives the additional item bonus. Are you using the latest git hash?

[Powlice]

@Technoken

And no, i dont use a latest git.. uhm can u tell me where should i go to check the problem? which file on the src ? something like that, kinda afraid to update my files it might give me a huge conflict and such problems.. TIA

 

I've been looking for a solution to this for like a week now, so i ended up seeking for help here XD

 

Edited April 29, 2017 by Powlice

[Cyro]

you can try posting your itemdb  script here

[Powlice]

15 hours ago, Cyro said:

you can try posting your itemdb  script here

it is already here, 

 

this one?

Quote

27001,Blush,Blush,5,20,,0,,1,,1,0xFFFFFFFF,63,2,1024,,0,0,125,{ bonus bonus bMaxHPrate,10; },{},{}

 

[Cyro]

my bad, i didnt notice it,

and its working fine for me

can you try this one

27001,Blush,Blush,5,20,,0,,1,,1,0xFFFFFFFF,7,2,1024,,0,0,125,{ bonus bVit,3; bonus bLuk,2; bonus bMaxHPrate,6; },{},{}

try this one?

[Powlice]

16 hours ago, Cyro said:

my bad, i didnt notice it,

and its working fine for me

can you try this one

27001,Blush,Blush,5,20,,0,,1,,1,0xFFFFFFFF,7,2,1024,,0,0,125,{ bonus bVit,3; bonus bLuk,2; bonus bMaxHPrate,6; },{},{}

try this one?

still no luck i even tried with different kind of item bonus still no effect.. 

[Technoken]

It's something in the source which doesn't give bonuses on costumes. Maybe try to update it but make sure to backup it first before updating. We can't help you that much since you're using an outdated version.

[Radian]

Maybe this

27001,Blush,Blush,5,20,,0,,1,,1,0xFFFFFFFF,63,2,1024,,0,0,125,{ bonus bonus bMaxHPrate,10; },{},{}

should be like this

27001,Blush,Blush,5,20,,0,,1,,1,0xFFFFFFFF,63,2,1024,,0,0,125,{ bonus bMaxHPRate,10; },{},{}

 

[Radian]

3 hours ago, Powlice said:

Hello, thanks for replying to my topic, it is the default costume headgears made in item_db the one that uses the id bitmask 1024(Costume Top Headgear) in location of the equipment

as for example the bonus bstats,n; aint gonna work as long as the equipment is stated as (Costume Top - 1024).

 

 

Off Topic: Where i can find the edit button for my Topic's Title

bonus bstats,n; is not available.. but if you mean bonus bAllStats,n;

[Powlice]

15 hours ago, Radian said:

bonus bstats,n; is not available.. but if you mean bonus bAllStats,n;

Ye sorry for not making it accurate in terms of case sensitive but yes ofc i did bonus bAllStats,n;

What i mean is what ever item bonuses i tried to put into that costume type headgear no matter what it is not gonna work even if its HP addition or Stats Addition.

[Radian]

1 minute ago, Powlice said:

Ye sorry for not making it accurate in terms of case sensitive but yes ofc i did bonus bAllStats,n;

What i mean is what ever item bonuses i tried to put into that costume type headgear no matter what it is not gonna work even if its HP addition or Stats Addition.

Tell me did you do any source modifications? and what emulator are you using?

Edit: its not about the case it was the bonus you stated that you are using bonus bstats,n; but that bonus is not available. well it doesn't matter anymore since if other bonuses are not working there should be something that you changed that cause this..

Edited April 29, 2017 by Radian

[Powlice]

rAthena.

 

and the only source mod that did is the costume system(@costumeitem) the system works

[Radian]

Just now, Powlice said:

rAthena.

 

and the only source mod that did is the costume system(@costumeitem) the system works

As you can see that modification will remove everything that is costume... and thats why the effects are not working

[Technoken]

@Radian I'm also using the Costume System, but a regular costume item in item_db.txt gives bonus, while costume items which are produced via @costumeitem or costume script command doesn't give any bonus. Maybe the way he patched it was wrong, or bc he's using an older rathena revision.

[Powlice]

16 hours ago, Radian said:

As you can see that modification will remove everything that is costume... and thats why the effects are not working

are you familiar to that mod? cause i've seen some server that has this costume system aswell but their costume type hg effect are working aswell

[Radian]

Just now, Powlice said:

are you familiar to that mod? cause i've seen some server that has this costume system aswell but their costume type hg effect are working aswell

You need to define which one you are using because there are 2 kinds of costumeitem the one that released by Rebel or by Secret?

[Radian]

2 minutes ago, Technoken said:

@Radian I'm also using the Costume System, but a regular costume item in item_db.txt gives bonus, while costume items which are produced via @costumeitem or costume script command doesn't give any bonus. Maybe the way he patched it was wrong, or bc he's using an older rathena revision.

I might be wrong... I used that last time and its a cool system and maybe yea he might be wrong while adding the modification.

[Cyro]

1 hour ago, Powlice said:

still no luck i even tried with different kind of item bonus still no effect.. 

i also sense this consume system modification might be effected it as @Radian said

[Powlice]

is there any posibilities to make it work like the un-mod costume type headgear?

16 hours ago, Cyro said:

i also sense this consume system modification might be effected it as @Radian said

 

[Powlice]

16 hours ago, Radian said:

You need to define which one you are using because there are 2 kinds of costumeitem the one that released by Rebel or by Secret?

i forgot which one, but as i can remember i tried to find a way to fix rebel's patch.

file attached below is the one i used.(forgot who made the patch)

Costume_System_Fix_for_Latest_rA.diff

[Radian]

Yea this is the one that Rebel released. and this might help you out 

but I dont think you want to make everything that is converted to costume will still have their own effect.