killmonster command doesn't work

[ZelosAvalon]

i have two problems in my script  (Note: this scripts was made for hercules and now i'm return to rathena)

1st: When my event is finished by a GM or by the npc itself, the map monsters aren't being killed, they are still alive.

2nd: When my event starts the npc appears an emotion / hlp above his head, but it is only appearing in an npc, just in what you started the event, I would like it to appear in all npcs of the world!

my NPC Script: http://upaste.me/0c9a34036a75a2370

when i finish it i'll share here in rathena forum! NPC Invasion + NPC Ranking Invasion

best regards ZelosAvalon

[Emistry]

1.

find this line...424

killmonster .invasion_map$, "Event Invasion::OnMyMobDead";

change into

killmonster .invasion_map$, strnpcinfo(3)+"::OnMyMobDead";

 

2.

you can do it this way ...

add this label in your npc

OnEventEmote:
	emotion e_hlp;
	end;

then change

while ($invasion_event_flag == true) {
	sleep 2000;
	emotion(e_hlp);
}
end;

into

while ($invasion_event_flag == true) {
	sleep 2000;
	donpcevent "::OnEventEmote";
}
end;

it should do the trick for you...

but there are several ways for you to do this tricks too. 

Edited May 18, 2018 by Emistry

[AnnieRuru]

@Emistry should be donpcevent

donpcevent "::OnEventEmote";

another thing that's different from rathena and hercules is the gettime constants ...
hercules use GETTIME_WEEKDAY
rathena use DT_DAYOFWEEK

Edited May 18, 2018 by AnnieRuru