Circular cell preventing the cast of a certain skill

[imat1]

When i'm using a melee skill like asura, FCP, or sonic blow while i'm 3 or more cell away on the target, my character just move closer, but the skill interrupts and there is no cast especially when i'm diagonally positioned onto the target. Please help me...

[Playtester]

        } else if( !battle_check_range(src, target, range) )
            return 0; // Arrow-path check failed.

Just change to that to:

        } else if( !battle_check_range(src, target, range+1) )
            return 0; // Arrow-path check failed.

For now.

 

At least then you only change it in that one specific case instead of changing a general range function that's used everywhere.

 

Yes, it's not safe, it gives hackers one more skill range than other players, but I can't look into a better fix because the bug doesn't appear for me locally and nobody else that has this bug could look into why it even gets to that code part.

[anacondaq]

When i'm using a melee skill like asura, FCP, or sonic blow while i'm 3 or more cell away on the target, my character just move closer, but the skill interrupts and there is no cast especially when i'm diagonally positioned onto the target. Please help me...

Is it the same like this issue? https://github.com/rathena/rathena/issues/1427

If yes, see my comments below, i have fixed it, but my fix not safe.

Edited September 16, 2016 by Anacondaqq

[imat1]

Now i know why it's not safe. It makes a melee skill somewhat range.

Edited September 16, 2016 by imat1

[imat1]

Anyone have the better fix for this?