(script commands) OnPCSkillUseEvent + getskillname

[Ninja]

Hi rAthena,

 

I've seen a lot of (old) posts that wanted to have skill detection through scripts. I'm releasing these stuff for scripters to munch on

Hope it helps expand the scripting scene and hope you guys release your work here in rAthena too.

 

Credits to Playtester for helping me find the entry point of skill usage.

 

working on Rev: 100644

OnPCSkillUseEventOnPCSkillUseEvent.diff

Detects when a player uses a skill returns:

@skillused_id - the id of the skill used

@skillused_lv - the level of the skill used

 

getskillnamegetskillname.diff

Gets the skill name of a skill_id

 

Sample Script

-	script	Test	-1,{

OnPCUseSkillEvent:
announce "You have used level"[email protected]_lv+" "+getskillname(@skillused_id),bc_self;
end;

}

I intentionally separated these so that getskillname can be used independently since I haven't really seen any script command that shows the "english" name of a skill.

Edited March 21, 2016 by Ninja

[Azeroth]

Thank you

[Ninja]

Thank you

You're welcome. feel free to use and extend it.

[Fratini]

Wow, very nice!! Thank you a lot , Ninja!

 

That's a great work indeed!!

[Ninja]

Wow, very nice!! Thank you a lot , Ninja!

 

That's a great work indeed!!

 

You're welcome

[Helly]

Thank you

nice release

 

But show error in the last rev of rA about a "npc use item"

Edited April 22, 2016 by Namine210

[Ninja]

@Namine210 can you post the error here? Thanks

[jawbreaker]

this one 

pc.c: In function ‘pc_useitem’:

pc.c:4920:23: error: ‘NPCE_ITEMUSE’ undeclared (first use in this function)

  npc_script_event(sd, NPCE_ITEMUSE);

                       ^

pc.c:4920:23: note: each undeclared identifier is reported only once for each function it appears in

make[1]: *** [obj/pc.o] Error 1

 

 

can you share also OnPCUseItemEvent?

Edited June 9, 2016 by jawbreaker

[acdse]

 

this one 

pc.c: In function ‘pc_useitem’:

pc.c:4920:23: error: ‘NPCE_ITEMUSE’ undeclared (first use in this function)

  npc_script_event(sd, NPCE_ITEMUSE);

                       ^

pc.c:4920:23: note: each undeclared identifier is reported only once for each function it appears in

make[1]: *** [obj/pc.o] Error 1

 

 

can you share also OnPCUseItemEvent?

 

 

NPCE_ITEMUSE - > NPCE_SKILLUSE change

[eezclide]

I can't seems to get this work XD

i have the same error jawbreaker mention

and change NPCE_ITEMUSE -> NPCE_SKILLUSE

and came out with no error

but still it doesnt work for me

 

On 3/21/2016 at 6:02 PM, Ninja said:

Hi rAthena,

 

I've seen a lot of (old) posts that wanted to have skill detection through scripts. I'm releasing these stuff for scripters to munch on

Hope it helps expand the scripting scene and hope you guys release your work here in rAthena too.

 

Credits to Playtester for helping me find the entry point of skill usage.

 

working on Rev: 100644

OnPCSkillUseEventOnPCSkillUseEvent.diff

  Reveal hidden contents

 

Detects when a player uses a skill returns:

@skillused_id - the id of the skill used

@skillused_lv - the level of the skill used

 

 

getskillnamegetskillname.diff

 

  Reveal hidden contents

 

Gets the skill name of a skill_id

 

 

 

Sample Script

  Reveal hidden contents

 

-	script	Test	-1,{

OnPCUseSkillEvent:
announce "You have used level"+@skillused_lv+" "+getskillname(@skillused_id),bc_self;
end;

}

I intentionally separated these so that getskillname can be used independently since I haven't really seen any script command that shows the "english" name of a skill.

Quoting, waiting for your response

[Ninja]

@eezclide Hey man, I just got back from my hiatus. I'm still catching up with a lot of stuff here in rA. I'll try to get back to you as soon as I get my environment up and running again. Cheers.

[AdrianoGC]

script.cpp: In function 'int buildin_getskillname(script_state*)':
script.cpp:24755:29: error: no match for 'operator[]' (operand types are 'SkillDatabase' and 'uint16 {aka short unsigned int}')
  memcpy(skill_name, skill_db[skill_get_index(skill_id)]->desc, SKILL_DESC_LENGTH);

[eezclide]

@Ninja hehehe its been a while and I'm about to practice more here in rathena again XD.

I remember why I need your diff here.

coz with this I can call out the wav files while using skills custom and easier for newbies.

like when using LORD of VERMILLION - the character is shouting the skills.

I just got back on developing again all my old files are gone now starting new hehehe

 

by the way I have this error here. using the latest revision.

 

/**
* Jezznar
* getskillname (skillid);
**/
BUILDIN_FUNC(getskillname)
 {
    int skill_id;
    char *skill_name;
        //get input skill_id
        if (!script_hasdata(st, 2)) {
        script_pushconststr(st, "null");
        return SCRIPT_CMD_SUCCESS;
        
    }
        skill_id = script_getnum(st, 2);
    
        if (!skill_get_index(skill_id)) {
        ShowError("script:conv_str: Unknown skill_id supplied.\"\n");
        script_pushconststr(st, "null");
        return SCRIPT_CMD_SUCCESS;
        
    }
    skill_name = (char *)aMalloc(SKILL_NAME_LENGTH * sizeof(char));
    memcpy(skill_name, skill_db[skill_get_index(skill_id)]->desc, SKILL_DESC_LENGTH);
    script_pushstr(st, skill_name);
    
        return SCRIPT_CMD_SUCCESS;
    }

 

Anyways thanks for this. I cant make the skill name appear but, The skillused_id is what I need for skills shout. thank you

Edited March 1, 2020 by eezclide
added question and realize alternative