Jump to content
  • 0

Looping Simplification


nasagnilac

Question


  • Group:  Members
  • Topic Count:  89
  • Topics Per Day:  0.02
  • Content Count:  232
  • Reputation:   15
  • Joined:  11/02/13
  • Last Seen:  

	case 2:
		mes "[^0000ff TIER 1 ^000000]";
		for( set .@i, 1; .@i < getarraysize(.tier1); set .@i, .@i + 3 ){
			if(.tier1[.@i+3] == 1){
				mes ""+((.tier1[.@i+2] >= 1)?"+"+.tier1[.@i+2]+" ":"")+""+getitemname(.tier1[.@i])+" x "+.tier1[.@i+1]+"";
			}else if(.tier1[.@i+3] == 2){
				mes ""+((.tier1[.@i+2] >= 1)?"+"+.tier1[.@i+2]+" ":"")+"Costume's "+getitemname(.tier1[.@i])+" x "+.tier1[.@i+1]+"";
			}
		}
		mes "   ";
		mes "[^0000ff TIER 2 ^000000]";
		for( set .@i, 1; .@i < getarraysize(.tier2); set .@i, .@i + 3 ){
			if(.tier2[.@i+3] == 1){
				mes ""+((.tier2[.@i+2] >= 1)?"+"+.tier2[.@i+2]+" ":"")+""+getitemname(.tier2[.@i])+" x "+.tier2[.@i+1]+"";
			}else if(.tier2[.@i+3] == 2){
				mes ""+((.tier2[.@i+2] >= 1)?"+"+.tier2[.@i+2]+" ":"")+"Costume's "+getitemname(.tier2[.@i])+" x "+.tier2[.@i+1]+"";
			}
		}
		mes "   ";
		mes "[^0000ff TIER 3 ^000000]";
		for( set .@i, 1; .@i < getarraysize(.tier3); set .@i, .@i + 3 ){
			if(.tier3[.@i+3] == 1){
				mes ""+((.tier3[.@i+2] >= 1)?"+"+.tier3[.@i+2]+" ":"")+""+getitemname(.tier3[.@i])+" x "+.tier3[.@i+1]+"";
			}else if(.tier3[.@i+3] == 2){
				mes ""+((.tier3[.@i+2] >= 1)?"+"+.tier3[.@i+2]+" ":"")+"Costume's "+getitemname(.tier3[.@i])+" x "+.tier3[.@i+1]+"";
			}
		}
		mes "   ";
		mes "[^0000ff TIER 4 ^000000]";
		for( set .@i, 1; .@i < getarraysize(.tier4); set .@i, .@i + 3 ){
			if(.tier4[.@i+3] == 1){
				mes ""+((.tier4[.@i+2] >= 1)?"+"+.tier4[.@i+2]+" ":"")+""+getitemname(.tier4[.@i])+" x "+.tier4[.@i+1]+"";
			}else if(.tier4[.@i+3] == 2){
				mes ""+((.tier4[.@i+2] >= 1)?"+"+.tier4[.@i+2]+" ":"")+"Costume's "+getitemname(.tier4[.@i])+" x "+.tier4[.@i+1]+"";
			}
		}
		mes "   ";
		mes "[^0000ff TIER 5 ^000000]";
		for( set .@i, 1; .@i < getarraysize(.tier5); set .@i, .@i + 3 ){
			if(.tier5[.@i+3] == 1){
				mes ""+((.tier5[.@i+2] >= 1)?"+"+.tier5[.@i+2]+" ":"")+""+getitemname(.tier5[.@i])+" x "+.tier5[.@i+1]+"";
			}else if(.tier5[.@i+3] == 2){
				mes ""+((.tier5[.@i+2] >= 1)?"+"+.tier5[.@i+2]+" ":"")+"Costume's "+getitemname(.tier5[.@i])+" x "+.tier5[.@i+1]+"";
			}
		}
		mes "   ";
		mes "[^0000ff TIER 6 ^000000]";
		for( set .@i, 1; .@i < getarraysize(.tier6); set .@i, .@i + 3 ){
			if(.tier6[.@i+3] == 1){
				mes ""+((.tier6[.@i+2] >= 1)?"+"+.tier6[.@i+2]+" ":"")+""+getitemname(.tier6[.@i])+" x "+.tier6[.@i+1]+"";
			}else if(.tier6[.@i+3] == 2){
				mes ""+((.tier6[.@i+2] >= 1)?"+"+.tier6[.@i+2]+" ":"")+"Costume's "+getitemname(.tier6[.@i])+" x "+.tier6[.@i+1]+"";
			}
		}
		mes "   ";
		mes "[^0000ff TIER 7 ^000000]";
		for( set .@i, 1; .@i < getarraysize(.tier7); set .@i, .@i + 3 ){
			if(.tier7[.@i+3] == 1){
				mes ""+((.tier7[.@i+2] >= 1)?"+"+.tier7[.@i+2]+" ":"")+""+getitemname(.tier7[.@i])+" x "+.tier7[.@i+1]+"";
			}else if(.tier7[.@i+3] == 2){
				mes ""+((.tier7[.@i+2] >= 1)?"+"+.tier7[.@i+2]+" ":"")+"Costume's "+getitemname(.tier7[.@i])+" x "+.tier7[.@i+1]+"";
			}
		}
		mes "   ";
		mes "[^0000ff TIER 8 ^000000]";
		for( set .@i, 1; .@i < getarraysize(.tier8); set .@i, .@i + 3 ){
			if(.tier8[.@i+3] == 1){
				mes ""+((.tier8[.@i+2] >= 1)?"+"+.tier8[.@i+2]+" ":"")+""+getitemname(.tier8[.@i])+" x "+.tier8[.@i+1]+"";
			}else if(.tier8[.@i+3] == 2){
				mes ""+((.tier8[.@i+2] >= 1)?"+"+.tier8[.@i+2]+" ":"")+"Costume's "+getitemname(.tier8[.@i])+" x "+.tier8[.@i+1]+"";
			}
		}
		mes "   ";
		mes "[^0000ff TIER 9 ^000000]";
		for( set .@i, 1; .@i < getarraysize(.tier9); set .@i, .@i + 3 ){
			if(.tier9[.@i+3] == 1){
				mes ""+((.tier9[.@i+2] >= 1)?"+"+.tier9[.@i+2]+" ":"")+""+getitemname(.tier9[.@i])+" x "+.tier9[.@i+1]+"";
			}else if(.tier9[.@i+3] == 2){
				mes ""+((.tier9[.@i+2] >= 1)?"+"+.tier9[.@i+2]+" ":"")+"Costume's "+getitemname(.tier9[.@i])+" x "+.tier9[.@i+1]+"";
			}
		}
		mes "   ";
		mes "[^0000ff TIER 10 ^000000]";
		for( set .@i, 1; .@i < getarraysize(.tier10); set .@i, .@i + 3 ){
			if(.tier10[.@i+3] == 1){
				mes ""+((.tier10[.@i+2] >= 1)?"+"+.tier10[.@i+2]+" ":"")+""+getitemname(.tier10[.@i])+" x "+.tier10[.@i+1]+"";
			}else if(.tier10[.@i+3] == 2){
				mes ""+((.tier10[.@i+2] >= 1)?"+"+.tier10[.@i+2]+" ":"")+"Costume's "+getitemname(.tier10[.@i])+" x "+.tier10[.@i+1]+"";
			}
		}
		mes "   ";
		close;

How can I simplify this script?

Link to comment
Share on other sites

4 answers to this question

Recommended Posts


  • Group:  Forum Moderator
  • Topic Count:  93
  • Topics Per Day:  0.02
  • Content Count:  10018
  • Reputation:   2370
  • Joined:  10/28/11
  • Last Seen:  


if ( .@value_3 == 1 ) {

mes (( .@value_2 >= 1)?"+"+.@value_2+" ":"")+""+getitemname( .@value_0 )+"["+.@value_0+"] x "+.@value_1;

}

else if ( .@value_3 == 2 ) {

mes (( .@value_2 >= 1)?"+"+.@value_2+" ":"")+"Costume's "+getitemname( .@value_0 )+"["+.@value_0+"] x "+.@value_1;

}

Link to comment
Share on other sites


  • Group:  Forum Moderator
  • Topic Count:  93
  • Topics Per Day:  0.02
  • Content Count:  10018
  • Reputation:   2370
  • Joined:  10/28/11
  • Last Seen:  

	for ( .@tier = 1; .@tier <= 10; .@tier++ ) {
		mes "[^0000ff TIER "+.@tier+" ^000000]";

		.@tier_size = getarraysize( getd( ".tier"+.@tier ) );
		for( .@i = 1; .@i < .@tier_size; .@i += 3 ) {
			.@value_0 = getd( ".tier"+.@tier+"["+( .@i )+"]" );
			.@value_1 = getd( ".tier"+.@tier+"["+( .@i+1 )+"]" );
			.@value_2 = getd( ".tier"+.@tier+"["+( .@i+2 )+"]" );
			.@value_3 = getd( ".tier"+.@tier+"["+( .@i+3 )+"]" );
			if ( .@value_3 == 1 ) {
				mes (( .@value_2 >= 1)?"+"+.@value_2+" ":"")+""+getitemname( .@value_0 )+" x "+.@value_1;
			}
			else if ( .@value_3 == 2 ) {
				mes (( .@value_2 >= 1)?"+"+.@value_2+" ":"")+"Costume's "+getitemname( .@value_0 )+" x "+.@value_1;
			}
		}
		mes "   ";
	}

something like this .... 

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  14
  • Topics Per Day:  0.00
  • Content Count:  265
  • Reputation:   96
  • Joined:  09/30/14
  • Last Seen:  

Haha aw you beat me to it.

function	script	FN_Tier	{
.@tier = getarg(0);
	mes "[^0000ff TIER "+.@tier+" ^000000]";
	for( .@i = 1; .@i < getarraysize(getd(".tier" + .@tier)); .@i = .@i + 3 ){
		if(getd(".tier" + .@tier + "[.@i+3]") == 1) {
			mes ""+((getd(".tier" + .@tier + "[.@i+2]") >= 1)?"+"+getd(".tier" + .@tier + "[.@i+2]")+" ":"")+""+getitemname(getd(".tier" + .@tier + "[.@i]"))+" x "+getd(".tier" + .@tier +"[.@i+1]")+"";
		}else if(getd(".tier" + .@tier + "[.@i+3]") == 2){
			mes ""+((getd(".tier" + .@tier + "[.@i+2]") >= 1)?"+"+getd(".tier" + .@tier + "[.@i+2]")+" ":"")+"Costume's "+getitemname(getd(".tier" + .@tier + "[.@i]"))+" x "+getd(".tier" + .@tier +"[.@i+1]")+"";
		}
	}
	mes "   ";
	return;
}

prontera,150,150,4	script	TestingStuff	567,{
	for( .@i = 1; .@i < 11; .@i++ ){
		callfunc("FN_Tier",.@i);
		}
	end;
}

Didn't test with actual variables.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  89
  • Topics Per Day:  0.02
  • Content Count:  232
  • Reputation:   15
  • Joined:  11/02/13
  • Last Seen:  

It works! Thank you emistry.

But there is a problem. At this image you can see that only pantie is written there.
It should be Pantie[2371] and Undershirt[2523]. How can I fix it to red multiple items.
 

OnInit:

// == <itemid><amount><refine>
setarray .tier1[1],12412,1,1,1;
setarray .tier2[1],2371,1,2,1,2523,1,7,1;
setarray .tier3[1],1624,1,3,1;
setarray .tier4[1],5518,1,4,1;
setarray .tier5[1],5518,1,5,1;
setarray .tier6[1],5518,1,6,1;
setarray .tier7[1],5518,1,7,1;
setarray .tier8[1],5518,1,8,1;
setarray .tier9[1],5518,1,9,1;
setarray .tier10[1],5518,1,10,1;
end;

post-21795-0-06091000-1430465594_thumb.jpg

Edited by gmprestige
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...