Change Pre-Renewal Final Strike to Renewal Final Strike

[AkaruiX]

As the title says.

Everything else should be pre-Renewal.

I am using the newest git version.

 

I can't seem to find the pre-Renewal formula.

Well, at least what I did find didn't seem to change anything, even when I pasted the Renewal formula over it.

#ifdef RENEWAL
	case NJ_ISSEN:
		// Official Renewal formula [helvetica]
		// base damage = currenthp + ((atk * currenthp * skill level) / maxhp)
		// final damage = base damage + ((mirror image count + 1) / 5 * base damage) - (edef + sdef)
		// modified def formula
		{
			short totaldef;
			struct Damage atk = battle_calc_weapon_attack(src, target, skill_id, skill_lv, 0);
			struct status_change *sc = status_get_sc(src);

			md.damage = (int64)sstatus->hp + (atk.damage * (int64)sstatus->hp * skill_lv) / (int64)sstatus->max_hp;

			if (sc && sc->data[SC_BUNSINJYUTSU] && (i=sc->data[SC_BUNSINJYUTSU]->val2) > 0) { // mirror image bonus only occurs if active
				md.div_ = -( i + 2 ); // mirror image count + 2
				md.damage += (md.damage * (((i + 1) * 10) / 5)) / 10;
			}
			// modified def reduction, final damage = base damage - (edef + sdef)
			totaldef = tstatus->def2 + (short)status_get_def(target);
			md.damage -= totaldef;
		}
		break;
#endif

 

Am I missing something?

Do I have to change the mirror image skill?

[sandbox]

Can you elaborate the difference with pre-re and re final strike?

[AkaruiX]

Pre-Renewal: Final Strike hits only once, no matter what.

Renewal: Deals a number of hits equal to the remaining hits on Mirror Image + 1

Edited February 11, 2014 by AkaruiX

[sandbox]

So you want to use the renewal formula?

 

Try commenting #ifdef..

//#ifdef

[AkaruiX]

That doesn't work, it still only hits once.

[sandbox]

Oh! Did you also copy the skill related files in db folder? you should copy the lines of final strike from skill_cast_db, skill_require_db, etc. which can be found in the renewal db folder

[AkaruiX]

Copied everything I missed to their respective files, still no luck...

 

I don't understand this...

I double checked everything and compiled multiple times.

 

The only way I can get it to work is by commenting #define PRERE and uncommenting #define RENEWAL in config.c, but I don't want the other Renewal formulas.

 

 

 

 

Attached Image is with #define RENEWAL uncommented:

Edited February 13, 2014 by AkaruiX

[sietse11]

You need to find the formula in the source for pre re final strike.

The copy paste the formula from re over it.

 

Done.

 

 

Sadly, I have not tried to mod skills yet. So I wouldn't know where to find the formula's.

But I'm assuming it's right beneath the code you added in your 1st post

[AkaruiX]

I didn't have time to reply to this sooner, but no, that doesn't work.

That was actually one of the first things I tried.