Jump to content
  • 0
Dee

(Help) Fix This Fame Script

Question

So i have this script but its not from me.. its from some other guy "MRBRICE".

//====Hero Fame Gaining System====
//====By Temperis=============
-    script    FameOn    -1,{
// Enables the Fame Gaining System
OnPCLogInEvent:
if (EnableFame == 1) end;
set Fame, 0;
set Mobkills, 0;
set PvPkills, 0;
set Deaths, 0;
set EnableFame, 1;
mes "You have yet to choose what type of hero you want to become.";
next;
mes "Choose your destiny";
menu "Selfless Hero",-,"Deadly Hero",L_DHero,"Renouned Hero",L_RHero,"Legendary Hero",L_LHero,"Bountiful Hero",L_BHero;
set Shero, 1;
set HeroFame, 1;
mes "Very well. You are a selfless hero.";
close;
L_DHero:
set Dhero, 1;
set HeroFame, 1;
mes "Very well. You are a deadly hero.";
close;
L_RHero:
set Rhero, 1;
set HeroFame, 1;
mes "Very well. You are a renowned hero.";
close;
L_LHero:
set LHero, 1;
set HeroFame, 1;
mes "Very well. You are a Legendary Hero.";
close;
L_BHero:
set BHero, 1;
set HeroFame, 1;
mes "Very well. You are a Bountiful Hero.";
close;
// ==================================================
// For when a player kills a monster
// ==================================================
OnNPCKillEvent:
if (EnableFame < 1 || ( Rhero == 1 && Lhero == 1 && Bhero == 1 && Dhero == 1 && Shero == 1 ) ) end;
set Mobkills, Mobkills+1;
if (Mobkills == 20) goto L_GainMobFame;
end;
L_GainMobFame:
set Fame, Fame+1;
dispbottom "You have gained fame.";
dispbottom "Your current fame is "+Fame+" .";
dispbottom "Your current rank is "+Rank+" .";
set Mobkills, 0;
end;
// ==================================================
// For when you kill another player
// ==================================================
OnPCKillEvent:
if (EnableFame < 1 || ( Rhero == 1 && Lhero == 1 && Bhero == 1 && Dhero == 1 && Shero == 1 ) ) end;
if (Shero == 1) goto L_PKLoseFame;
set PvPkills, PvPkills+1;
if (PvPkills == 30) goto L_PKGetFame;
end;
L_PKGetFame:
set Fame, Fame+1;
dispbottom "You have gained fame.";
dispbottom "Your current fame is "+Fame+" .";
dispbottom "Your current rank is "+Rank+" .";
close;
L_PKLoseFame:
set Fame, Fame-1;
dispbottom "You have lost fame.";
dispbottom "Your current fame is "+Fame+" .";
dispbottom "Your current rank is "+Rank+" .";
close;
// ====================================================
// For when a player dies.
// ====================================================
OnPCDieEvent:
if (EnableFame < 1 || ( Rhero == 1 && Lhero == 1 && Bhero == 1 && Dhero == 1 && Shero == 1 ) ) end;
if (Shero == 1) goto L_PKGainFame;
set Fame, Fame-1;
dispbottom "You have lost fame.";
dispbottom "Your current fame is "+Fame+" .";
dispbottom "Your current rank is "+Rank+" .";
close;
L_PKGainFame:
set Deaths, Deaths+1;
if (Deaths == 2) goto L_PKGain2;
end;
L_PKGain2:
set Fame, Fame-1;
set Deaths, 0;
dispbottom "You have lost fame.";
dispbottom "Your current fame is "+Fame+" .";
dispbottom "Your current rank is "+Rank+" .";
close;
}
// ====================================================
// Rank Upgrade Component
// ====================================================
prontera,147,161,4    script    Rank Upgrade    98,{
// if(getgmlevel()<99) end;
mes "- Rank Upgrade Component -";
mes "Current Fame -^FA0000 "+Fame+"^000000";
mes "Current Rank -^0000FA "+Rank+"^000000";
next;
mes "Select an Option";
set @upgrademenu, select(
"Rank Upgrade(1) - Hero",
"Rank Upgrade(2) - Fierce Hero",
"Rank Upgrade(3) - Mighty Hero",
"Rank Upgrade(4) - Vicious Hero",
"Rank Upgrade(5) - Terrifying Hero",
"Rank Upgrade(6) - Conquering Hero",
"Rank Upgrade(7) - Subjugating Hero"
// "Rank Upgrade(8) - Vanquishing Hero",
// "Rank Upgrade(9) - Beloved Hero",
// "Rank Upgrade(10) - Illustrious Hero",
// "Rank Upgrade(11) - Eminent Hero",
// "Rank Upgrade(12) - King's Hero",
// "Rank Upgrade(13) - Emperor's Hero",
// "Rank Upgrade(14) - Odin's Hero",
// "Rank Upgrade(15) - Immortal Hero",
// "Rank Benefits",
// "Heroes' Ascent",
// "Heroes' Retreat",
);
switch(@upgrademenu) {
case 1:
    mes "Indeed you are ready to make the first upgrade.";
    menu "Yes",-,"No",L_Noupgrade;
    if (Rank > 0) goto L_Noupgrade;
    next;
    mes "Now, you shall become a Hero..";
    if (Rank >= 1) goto L_NoUpgrade;
    if (Fame < 250) goto L_Noupgrade;
    set Rank, 1;
    next;
    specialeffect2 514;
    announce "YoloRO Hero, "+strcharinfo(0)+" has upgraded to Rank 1 - Hero!",0;
    logmes "Rank 1 Upgrade";
    mes "You are now Rank 2!";
    getitem 6153,150;
    getitem 673,20;
    getitem 6096,3;
    getitem 667,2;
    close;
L_Noupgrade:
    mes "You cannot Upgrade your Rank because either you do not have enough fame or you have reached this rank already.";
    close;
case 2:
    mes "Your dedication is very becoming. Do you wish to go to Rank 2?";
    menu "Yes",-,"No",L_Noupgrade;
    if (Rank >= 2) goto L_Noupgrade;
    next;
    if (Fame < 750) goto L_Noupgrade;
    mes "Now the world will see the rise of a fierce hero.";
    set Rank, 2;
    next;
    specialeffect2 514;
    announce "YoloRO Hero, "+strcharinfo(0)+" has upgraded to Rank 2 - Fierce Hero!",0;
    logmes "Rank 2 Upgrade";
    mes "You are now Rank 2!";
    next;
    mes "You are quickly growing in your status. I entrust you with this ring.";
    mes "It is a symbol of your power, if you will.";
    next;
    mes "Good luck, "+strcharinfo(0)+" .";
    getitem 7280,1;
    close;
case 3:
    mes "Do you want to upgrade to Rank 3?";
    menu "Yes",-,"No",L_Noupgrade;
    if (Rank >= 3) goto L_Noupgrade;
    next;
    if (Fame < 1300) goto L_Noupgrade;
    mes "Now the world will see a true hero.. A Mighty hero.";
    mes "I will take your ring to imbue it with your heroic energy.";
    set Rank, 3;
    next;
    specialeffect2 514;
    announce "BriceRO Hero, "+strcharinfo(0)+" has upgraded to Rank 3 - Mighty Hero!",0;
    logmes "Rank 3 Upgrade";
    mes "You are now Rank 3!";
    next;
    mes "This ring now is imbued with your heroic spirit.";
    mes "You're now 'mightier than the wolves'.";
    next;
    mes "Good luck, "+strcharinfo(0)+" .";
    delitem 7280,1;
    getitem 7281,1;
    close;
case 4:
    mes "Do you want to upgrade to Rank 4?";
    menu "Yes",-,"No",L_Noupgrade;
    if (Rank >= 4) goto L_Noupgrade;
    next;
    if (Fame < 2000) goto L_Noupgrade;
    mes "Now the world will see a true hero.. A Vicious hero.";
    mes "I will take your ring to imbue it with your heroic energy.";
    set Rank, 4;
    next;
    specialeffect2 514;
    announce "Player, "+strcharinfo(0)+" has upgraded to Rank 4 - Fierce Hero!",0;
    logmes "Rank 4 Upgrade";
    mes "You are now Rank 4!";
    next;
    mes "This ring now is imbued with your heroic spirit.";
    next;
    mes "Good luck, "+strcharinfo(0)+" .";
    delitem 7281,1;
    getitem 7282,1;
    close;
case 5:
    mes "Do you want to upgrade to Rank 5?";
    menu "Yes",-,"No",L_Noupgrade;
    if (Rank >= 5) goto L_Noupgrade;
    next;
    if (Fame < 3300) goto L_Noupgrade;
    mes "Your heroic deeds are one word to your enemies... Terrifying..";
    mes "I will take your ring to imbue it with your heroic energy.";
    set Rank, 5;
    next;
    specialeffect2 514;
    announce "Player, "+strcharinfo(0)+" has upgraded to Rank 5 - Terrifying Hero!",0;
    logmes "Rank 5 Upgrade";
    mes "You are now Rank 5!";
    next;
    mes "This ring now is imbued with your heroic spirit.";
    next;
    mes "Good luck, "+strcharinfo(0)+" .";
    delitem 7282,1;
    getitem 7283,1;
    close;
case 6:
    mes "Do you want to upgrade to Rank 6?";
    menu "Yes",-,"No",L_Noupgrade;
    if (Rank >= 6) goto L_Noupgrade;
    next;
    if (Fame < 5000) goto L_Noupgrade;
    mes "Your heroic deeds are one word to your enemies... Terrifying..";
    mes "I will take your ring to imbue it with your heroic energy.";
    set Rank, 6;
    next;
    specialeffect2 514;
    announce "Player, "+strcharinfo(0)+" has upgraded to Rank 6 - Conquering Hero!",0;
    logmes "Rank 6 Upgrade";
    mes "You are now Rank 6!";
    next;
    mes "This ring now is imbued with your heroic spirit.";
    next;
    mes "Good luck, "+strcharinfo(0)+" .";
    delitem 7283,1;
    getitem 7284,1;
    close;
case 7:
    mes "Do you want to upgrade to Rank 7?";
    menu "Yes",-,"No",L_Noupgrade;
    if (Rank >= 7) goto L_Noupgrade;
    next;
    if (Fame < 10000) goto L_Noupgrade;
    mes "Your heroic deeds are one word to your enemies... Terrifying..";
    mes "I will take your ring to imbue it with your heroic energy.";
    set Rank, 7;
    next;
    specialeffect2 514;
    announce "Player, "+strcharinfo(0)+" has upgraded to Rank 7 - Subjugating Hero!",0;
    logmes "Rank 7 Upgrade";
    mes "You are now Rank 7!";
    next;
    mes "This ring now is imbued with your heroic spirit.";
    next;
    mes "Good luck, "+strcharinfo(0)+" .";
    delitem 7284,1;
    getitem 2630,1;
    close;
}
}

 

 

 

so some of the script is working. like when you kill monster "400pcs" you get 1 fame

 

the problem is on the PVP side. because when you kill somebody it doesnt give any FAME.

 

but if you die. it does reduce the fame.  so im not really sure whats the problem with this script. 

 

so all i want is if you Kill you get +1 Fame  if you die you get -1 fame.  in monster killing if you kill 20 monster you get +1 fame

 

Thank you guys.

Edited by Emistry
Changed [Quote] to [Code].
Link to comment
Share on other sites

7 answers to this question

Recommended Posts

i believe..you have to reset the variable 1 times..since the previous variable already stored more than 30...the script wont run that part as your variable is not equal to 30...

 

otherwise..change to

if (PvPkills % 30 == 0 ) goto L_PKGetFame;

 

else..

test with another characters...

Link to comment
Share on other sites

The script says everytime you kill a player it will add up to PVP kills and when the PVP kills reaches 30 you will gain 1 fame. Meaning 30 kills = 1 fame.

 
set PvPkills, PvPkills+1;
if (PvPkills == 30) goto L_PKGetFame;
end;
L_PKGetFame:
set Fame, Fame+1;
Edited by Patskie
Link to comment
Share on other sites

L_PKGetFame:
set PvPkills,0;  // <---------- MISSING
set Fame, Fame+1;

 

Nothings Happening.

 

The script says everytime you kill a player it will add up to PVP kills and when the PVP kills reaches 30 you will gain 1 fame. Meaning 30 kills = 1 fame.

 
set PvPkills, PvPkills+1;
if (PvPkills == 30) goto L_PKGetFame;
end;
L_PKGetFame:
set Fame, Fame+1;

im not asking about what it does i need the script to be fixed because its not working at all.. like everytime i kill 30 players it doesnt even give me a single fame.

Link to comment
Share on other sites

i believe..you have to reset the variable 1 times..since the previous variable already stored more than 30...the script wont run that part as your variable is not equal to 30...

 

otherwise..change to

if (PvPkills % 30 == 0 ) goto L_PKGetFame;

 

else..

test with another characters...

It is now working. Thank you so much..

Link to comment
Share on other sites

share share the working script :D Dee

 

Copy my first Script then Just add this. Enjoy :))

 

i believe..you have to reset the variable 1 times..since the previous variable already stored more than 30...the script wont run that part as your variable is not equal to 30...

 

otherwise..change to

if (PvPkills % 30 == 0 ) goto L_PKGetFame;

 

else..

test with another characters...

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use and Privacy Policy.