Why is this crashing my map server?

[michaelsoftman]

I have changed this part of skill.c. From this:

if(fixed == 0) {
 fixed = (int)time * 20 / 100; // fixed time
 time = time * 80 / 100; // variable time
}
else if( fixed == 0 ) {
 fixed = 0;
}

To this:

if( fixed == 0 && sd->class_&JOBL_THIRD){
 fixed = (int)time * 20 / 100; // fixed time
 time = time * 80 / 100; // variable time
}
if (!sd->class_&JOBL_THIRD) {// no fixed cast time
 fixed = 0;
}

And then when I boot up the server, the map server crashes as soon as the char server connects. But I do not get any compile errors or warnings. Any idea why?

Edited January 8, 2013 by michaelsoftman

[Lighta]

cause not only sd use that fonction I suppose.

I should check but that my raw guess, you can validate it with the coredump.

Try to add another if case for class_

[clydelion]

You introduced sd->class_&JOBL_THIRD, the right way would be to check first if sd is not NULL.

thus,

if( fixed == 0 && sd && sd->class_&JOBL_THIRD){

[Lighta]

na but he shouldn't do that since mob/homon etc won't ever enter here then and won't be concern.

(dunno who enter atm you need to test, but maybe that what u want yeah)

otherwise jsut add :

if(sd) blablabla;

else if blabla

else foo;

[michaelsoftman]

You introduced sd->class_&JOBL_THIRD, the right way would be to check first if sd is not NULL.

thus,

if( fixed == 0 && sd && sd->class_&JOBL_THIRD){

Thanks a lot, it's working perfectly now!