EvilPuncker Posted September 30, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 71 Joined: 11/08/11 Last Seen: December 25, 2024 Share Posted September 30, 2012 What about you guys changing all leftover numeric values into constants, like skill names in item_db for better reading? If you guys want I can do it and provide a diff to be commited 1 Link to comment Share on other sites More sharing options...
Brian Posted September 30, 2012 Group: Members Topic Count: 75 Topics Per Day: 0.02 Content Count: 2223 Reputation: 594 Joined: 10/26/11 Last Seen: June 2, 2018 Share Posted September 30, 2012 Are these constants already in trunk/db/const.txt, or would we have to add new constants ? Link to comment Share on other sites More sharing options...
EvilPuncker Posted September 30, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 71 Joined: 11/08/11 Last Seen: December 25, 2024 Author Share Posted September 30, 2012 Are these constants already in trunk/db/const.txt, or would we have to add new constants ? I mean basically changing skill ids to skill names and also some elements/races that still uses its ID Link to comment Share on other sites More sharing options...
rafoka Posted October 14, 2012 Group: Members Topic Count: 5 Topics Per Day: 0.00 Content Count: 48 Reputation: 8 Joined: 01/09/12 Last Seen: September 5, 2021 Share Posted October 14, 2012 (edited) I would love it, CONSTANTS is in all the way too much better Edited October 14, 2012 by rafoka Link to comment Share on other sites More sharing options...
EvilPuncker Posted November 14, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 71 Joined: 11/08/11 Last Seen: December 25, 2024 Author Share Posted November 14, 2012 I would love it, CONSTANTS is in all the way too much better indeed, I'm just waiting for someone to tell me to go ahead and I will do it myself Link to comment Share on other sites More sharing options...
Lighta Posted November 14, 2012 Group: Members Topic Count: 16 Topics Per Day: 0.00 Content Count: 737 Reputation: 216 Joined: 11/29/11 Last Seen: December 20, 2020 Share Posted November 14, 2012 go ahead I'll take a look at it =) Link to comment Share on other sites More sharing options...
kyeme Posted November 14, 2012 Group: Members Topic Count: 10 Topics Per Day: 0.00 Content Count: 164 Reputation: 12 Joined: 03/08/12 Last Seen: Yesterday at 07:18 AM Share Posted November 14, 2012 (edited) What about you guys changing all leftover numeric values into constants, like skill names in item_db for better reading? If you guys want I can do it and provide a diff to be commited +1 Edited November 14, 2012 by kyeme Link to comment Share on other sites More sharing options...
Akkarin Posted November 14, 2012 Group: Forum Manager Topic Count: 282 Topics Per Day: 0.06 Content Count: 3145 Reputation: 1633 Joined: 03/26/12 Last Seen: May 25 Share Posted November 14, 2012 To be honest, i think alot of users would prefer to see names instead of IDs. I like it. Link to comment Share on other sites More sharing options...
EvilPuncker Posted November 15, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 71 Joined: 11/08/11 Last Seen: December 25, 2024 Author Share Posted November 15, 2012 did it and some more edit as your need: http://pastebin.com/aLcGgJtd also there still 15 occurrences of isequipped that I didn't bothered to look at but maybe you guys should move them to item_combo_db.txt 1 Link to comment Share on other sites More sharing options...
Lighta Posted November 16, 2012 Group: Members Topic Count: 16 Topics Per Day: 0.00 Content Count: 737 Reputation: 216 Joined: 11/29/11 Last Seen: December 20, 2020 Share Posted November 16, 2012 Thx EvilPuncker, I always forget. Looks good at first sight but I'll need to try it properly before commit it so probably this weekend it'll be done, or if someone wanna do it feel free. Anyway thx EP =) 1 Link to comment Share on other sites More sharing options...
EvilPuncker Posted November 16, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 71 Joined: 11/08/11 Last Seen: December 25, 2024 Author Share Posted November 16, 2012 Are these constants already in trunk/db/const.txt, or would we have to add new constants ? btw I've added 3 new constants for sizes I've found it necessary xd but you guys should decide what to do Link to comment Share on other sites More sharing options...
Lighta Posted November 16, 2012 Group: Members Topic Count: 16 Topics Per Day: 0.00 Content Count: 737 Reputation: 216 Joined: 11/29/11 Last Seen: December 20, 2020 Share Posted November 16, 2012 saw that, there a small mistmatch with size constant wich ain't the same for mob and player but that another issue Link to comment Share on other sites More sharing options...
Lighta Posted November 18, 2012 Group: Members Topic Count: 16 Topics Per Day: 0.00 Content Count: 737 Reputation: 216 Joined: 11/29/11 Last Seen: December 20, 2020 Share Posted November 18, 2012 So I looked the patch EvilPunker and there some issues : script error on db/re/item_db.txt line 1053 parse_callfunc: not enough arguments, expected ',' * 1053 : { bonus bStr,2; bonus bInt,1; bonus2 bAddRace,RC_DemiHuman,95; bonus2 bVariableCastrate,"MO_EXTREMITYFIST",-25; autobonus "{ bonus2 bVariableCastrate,"'M'O_EXTREMITYFIST",-100; }",50,6000,BF_WEAPON,"{ specialeffect2 EF_SUFFRAGIUM; }"; bonus bUnbreakableWeapon,0; } This is due to " " quote, since you using them for the skill name you breaking the quote thus generating an error on autobonus. Then another more important error is that right now not all bonus can support skill name, just a few do the resolution to skillid. So that was just to give you some feedback, I'll work on it. Link to comment Share on other sites More sharing options...
EvilPuncker Posted November 18, 2012 Group: Members Topic Count: 19 Topics Per Day: 0.00 Content Count: 713 Reputation: 71 Joined: 11/08/11 Last Seen: December 25, 2024 Author Share Posted November 18, 2012 thanks for the feedback Link to comment Share on other sites More sharing options...
Recommended Posts