Small milestone to item_db.txt

[EvilPuncker]

What about you guys changing all leftover numeric values into constants, like skill names in item_db for better reading? If you guys want I can do it and provide a diff to be commited

[Brian]

Are these constants already in trunk/db/const.txt, or would we have to add new constants ?

[EvilPuncker]

Are these constants already in trunk/db/const.txt, or would we have to add new constants ?

I mean basically changing skill ids to skill names and also some elements/races that still uses its ID

[rafoka]

I would love it, CONSTANTS is in all the way too much better

Edited October 14, 2012 by rafoka

[EvilPuncker]

I would love it, CONSTANTS is in all the way too much better

indeed, I'm just waiting for someone to tell me to go ahead and I will do it myself

[Lighta]

go ahead I'll take a look at it =)

[kyeme]

What about you guys changing all leftover numeric values into constants, like skill names in item_db for better reading? If you guys want I can do it and provide a diff to be commited

+1

Edited November 14, 2012 by kyeme

[Akkarin]

To be honest, i think alot of users would prefer to see names instead of IDs. I like it.

[EvilPuncker]

did it and some more edit as your need:

http://pastebin.com/aLcGgJtd

also there still 15 occurrences of isequipped that I didn't bothered to look at but maybe you guys should move them to item_combo_db.txt

[Lighta]

Thx EvilPuncker, I always forget.

Looks good at first sight but I'll need to try it properly before commit it so probably this weekend it'll be done, or if someone wanna do it feel free.

Anyway thx EP =)

[EvilPuncker]

Are these constants already in trunk/db/const.txt, or would we have to add new constants ?

btw I've added 3 new constants for sizes I've found it necessary xd but you guys should decide what to do

[Lighta]

saw that, there a small mistmatch with size constant wich ain't the same for mob and player but that another issue

[Lighta]

So I looked the patch EvilPunker and there some issues :

script error on db/re/item_db.txt line 1053

parse_callfunc: not enough arguments, expected ','

* 1053 : { bonus bStr,2; bonus bInt,1; bonus2 bAddRace,RC_DemiHuman,95; bonus2 bVariableCastrate,"MO_EXTREMITYFIST",-25; autobonus "{ bonus2 bVariableCastrate,"'M'O_EXTREMITYFIST",-100; }",50,6000,BF_WEAPON,"{ specialeffect2 EF_SUFFRAGIUM; }"; bonus bUnbreakableWeapon,0; }

This is due to " " quote, since you using them for the skill name you breaking the quote thus generating an error on autobonus.

Then another more important error is that right now not all bonus can support skill name, just a few do the resolution to skillid.

So that was just to give you some feedback, I'll work on it.

[EvilPuncker]

thanks for the feedback