goddameits refine++ script modification

[Breaker]

hi im referring to thi script http://rathena.org/board/topic/66190-refine/,

since this one gives you on every upgrade level the choice to use a safe refine or a normal one im asking you guys to change it that it wont ask for protection scroll while the refine level is still 100%.

i tried it myself but im totally new to the stuff and meh... didnt turn out very well

hope you guys would help me with that,

thanks in advance!

BREAKER

[Loki81]

Yess me too i search for this thing i believe to find there but it have nothing it have a script refine +++

[Yanji]

So you want a script that has a 100% chance to refine, or a script that doesn't ask you to safe refine it when the chance is 100%?

[Breaker]

exactly lets say level 1-4 is already 100% safe then you shouldnt have the option to use the protection scroll im just afraid people wouldnt get it and use it to a anyway safe thing and complain then

[goddameit]

seen there is a variable recording the chances of success

' @rate '

function sRater {
 mes "[successful rate]["+set(@rate,(nRate(@typr,getequiprefinerycnt(@typr))+(@use2>6000?10:0)))+"%]";
 return;
}

and we know below is used to delete the protection scroll

if(.Scroll)
{
 if( @menu==2 || @menu2==2 )
  delitem .Scroll,1;
}

so what should we done is making a new exception about 100% (even over) success.

if(.Scroll)
{
 if( ( @menu==2 || @menu2==2 ) && @rate < 100 )
  delitem .Scroll,1;
}

also can add a note.

if(.Scroll)
{
 if( @menu==2 || @menu2==2 )
if( @rate >= 100 )
  mes "100% of success, so automatically cancel using the protection scroll";
else
 delitem .Scroll,1;
}

http://imgur.com/TXn3l

http://imgur.com/pLLrQ

http://imgur.com/lGEtd

http://imgur.com/Wh5Yn

http://imgur.com/ZCu33

Edited June 29, 2012 by goddameit

[Breaker]

can you post the full modified script please?

[MelMel]

is it me or does anyone have problem after refining +13?

when my weapon +13 i was going to +14 then all of sudden it just spam itself to +20

on map server it report:

Unexpected type for argument 1. Expected string.

[Debug]: Data: number value=-1

[Debug]: Function: select

[Debug]: Source <NPC>: Refine++ at prontera <173,159>

[Error]: run_script: infinity loop !

anyone help with this problems?

thanks in advance

[Charada]

is it me or does anyone have problem after refining +13?

when my weapon +13 i was going to +14 then all of sudden it just spam itself to +20

on map server it report:

Unexpected type for argument 1. Expected string.

[Debug]: Data: number value=-1

[Debug]: Function: select

[Debug]: Source <NPC>: Refine++ at prontera <173,159>

[Error]: run_script: infinity loop !

anyone help with this problems?

thanks in advance

I'm having the same problem, someone knows how to solve?

[AnnieRuru]

change this line 210

while(getequiprefinerycnt(@typr)!=.@D)successrefitem @typr;

into

while(getequiprefinerycnt(@typr)<.@D)successrefitem @typr;

[Charada]

It worked! Thank you.

[Mootie]

i got this error while un-wearing equips on me i guess the npc looking for 1 not -1 lol wondering to prevent this