mvproom npc error

[donkeyg]

the npc was work fine on eathena, but since i move the eathena to rathena SVN, this mvp_room files comes out error

Uploaded with ImageShack.us

here is my script

L_Start: // I hate gotos ... but ...
set .@dif, strnpcinfo(2);
if ( .remind[.@dif] == 0 ) {
set .remind[.@dif], 1;
initnpctimer;
}
mes "[MVP Summoner]";
mes "Hi, what can I do for you ?";
next;
switch ( select(.menu$) ) {
case 1:
mes "[MVP Summoner]";
if ( getmapmobs("this") > 0 {
mes "I cannot offer heal service when there are monsters around.";
close;
}
sc_end sc_poison;
sc_end sc_hallucination;
sc_end sc_stripweapon;
sc_end sc_striparmor;
sc_end sc_striphelm;
sc_end sc_stripshield;
sc_end sc_changeundead;
sc_end sc_orcish;
sc_end sc_berserk;
sc_end sc_ske;
sc_end sc_swoo;
sc_end sc_ska;
percentheal 100,100;
specialeffect2 7;
mes "You have completely healed.";
close;

Edited June 22, 2012 by donkeyg

[Aksl]

if ( getmapmobs("this") > 0 )  {

no ?

[donkeyg]

u mean remove the line?

[HD Scripts]

if(getmapmobs("NAMEOFMAP") > 0) ...

[Yanji]

You forgot a ) in this line:

if ( getmapmobs("this") > 0  {

It should be this:

if ( getmapmobs("this") > 0 )  {

Edited June 23, 2012 by Yanji

[donkeyg]

it has many room

06guild_01,49,49,4 duplicate(MVP Summoner) MVP Summoner#1 116
06guild_02,49,49,4 duplicate(MVP Summoner) MVP Summoner#2 116
06guild_03,49,49,4 duplicate(MVP Summoner) MVP Summoner#3 116
06guild_04,49,49,4 duplicate(MVP Summoner) MVP Summoner#4 116
06guild_05,49,49,4 duplicate(MVP Summoner) MVP Summoner#5 116
06guild_06,49,49,4 duplicate(MVP Summoner) MVP Summoner#6 116
06guild_07,49,49,4 duplicate(MVP Summoner) MVP Summoner#7 116
06guild_08,49,49,4 duplicate(MVP Summoner) MVP Summoner#8 116

if ( getmapmobs("this") > 0 ) {

You forgot a ) in this line:

if ( getmapmobs("this") > 0  {

It should be this:

if ( getmapmobs("this") > 0 )  {

yes, mine is same as u

Edited June 23, 2012 by donkeyg

[pandaplaygames]

Here's the converted script for rathena from eathena script.

http://pastebin.com/XWNdE76c

Credits ~AnnieRuru~

Added killmonsterall function to empty rooms that ended for the rent duration.

[Relzz]

The command 'getmapmobs' doens't work in rathena in rathena is 'mobcount' and.. Yeah.. Also killmonsterall is changed :3

[AnnieRuru]

I have updated the script to 1.4a hidden here

Credits ~AnnieRuru~

Added killmonsterall function to empty rooms that ended for the rent duration.

weird, I thought I already made it kill all the monsters inside upon renting a room

    warp "06guild_0"+ .@room, 0,0;
   killmonsterall "06guild_0"+ .@room;
   donpcevent "MVP Summoner#"+ .@room +"::OnEnterMap";
   end;

and

    // If the room has left over monsters while nobody in the room and the room not give up yet, shall we kill monsters in empty room ?
   set .killmonster, 1; // Default is yes

the default setting is yes,

you set it to 0 and then claim you edited the script to kill left over monster ?

[pandaplaygames]

@Annieruru - i meant it already has the killmonster function. It's the script back in eathena. I don't claim anything just to make things clear.

Here's your post in eathena http://www.eathena.ws/board/index.php?showtopic=187654

just added

killmonsterall .@map$; where it was checking the time that's all.

anyway Annieruru I don't (again) claim anything. it's urs.

and I didn't know about 1.4a. so my miss on that.

Edited November 9, 2012 by pandaplaygames