Jump to content
The forums will be going offline for an extended maintenance period at 1400hrs GMT on 19th June 2025. The number of hours for this downtime is intentionally not advertised due to the nature of these upgrades. ×
  • 0

HELPP! script:delitem: failed to delete 1 item (blah blah blah.. )

Critica

Asked by Critica,

 Share

Question

Critica Poring

Critica

Posted
  • Group:  Members
  • Topic Count:  82
  • Topics Per Day:  0.02
  • Content Count:  223
  • Reputation:   4
  • Joined:  02/23/12
  • Last Seen:  
Posted 

nguild_pay,124,58,1 script Special Compound  952,{
//nguild,124,58,0 script Card Compounder 100,{
set .n$,"["+strnpcinfo(1)+"]";
// ======== Requirement Settings: ============
// = Format:
// - .requ[0],<ID>,<Amount>;
// = ID:
// - 0 = Nothing/Disabled
// - 1 = Zeny
// - 2 = #CASHPOINTS
// - 3 = Custom Variable > Search & Replace "custom_points" with your variable
// - 501 and higher means Item ID
// Amount should be obvious .
setarray .requ[0],2,100; // Default: 2,100 = 100x Cash Points
// GM Settings & Testing Help
if(getgmlevel() > 0) {
if(.requ[0] == 1) {
 mes "Zeny:";
 input @zeny,.requ[1],1000000; // 1m Zeny
 if(@zeny == 0) set @zeny,.requ[1];
 set Zeny,@zeny*4;
} else if(.requ[0] == 2) {
 mes "Cash Points:";
 input @cash,.requ[1],10000; // 10k Cash Points
 if(@cash == 0) set @cash,.requ[1];
 set #CASHPOINTS,@cash*4;
} else if(.requ[0] == 3) {
 mes "Custom Points:";
 input @custom,.requ[1],2000;
 if(@custom == 0) set @custom,.requ[1];
 set custom_points,@custom*4;
} else if(.requ[0] > 500) {
 mes getitemname(.requ[0])+":";
 input @item,.requ[1],10000;
 if(@item == 0) set @item,.requ[1];
 getitem .requ[0],@item*4;
}
next;
mes "Balances:";
mes "Zeny: "+ Zeny;
mes "Cash Points: "+#CASHPOINTS;
mes "Custom Points: "+custom_points;
set @debug,1;
next;
}
mes .n$;
mes "Hello, how can I help you?";
next;
switch(select("- Compound Cards:- Information:- Nothing")) {
case 1:
mes .n$;
mes "Please choose the item you want to compound cards on from your inventory:";
next;
getinventorylist;
deletearray @eq_list[0],128;
deletearray @ca_list[0],128;
deletearray @ca_am[0],128;
deletearray @eq_ref[0],128;
deletearray @eq_c1[0],128;
deletearray @eq_c2[0],128;
deletearray @eq_c3[0],128;
deletearray @eq_c4[0],128;
set @card1,0;
set @card2,0;
set @card3,0;
set @card4,0;
set @it_m$,"";
set @e,0; // Reset Array Position
for ( set @i,0; @i < @inventorylist_count; set @i,@i + 1) { // Looping through the Items
 // Available Equipment
 if( (getiteminfo(@inventorylist_id[@i],2) == 4 || getiteminfo(@inventorylist_id[@i],2) == 5) && getitemslots(@inventorylist_id[@i]) > 0 && @inventorylist_identify[@i] == 1 && @inventorylist_equip[@i] == 0) {
  // Item ID
  setarray @eq_list[@e],@inventorylist_id[@i];
  if(@debug) dispbottom "Equip Name: "+getitemname(@inventorylist_id[@i])+" ["+@inventorylist_id[@i]+"]";
  // Does the items have an refine?
  setarray @eq_ref[@e],@inventorylist_refine[@i];
  // Does the items already have cards compounded?
  setarray @eq_c1[@e],@inventorylist_card1[@i];
  if(@debug) dispbottom "Card 1: "+ getitemname(@inventorylist_card1[@i])+" ["+@inventorylist_card1[@i]+"]";
  setarray @eq_c2[@e],@inventorylist_card2[@i];
  if(@debug) dispbottom "Card 2: "+ getitemname(@inventorylist_card2[@i])+" ["+@inventorylist_card2[@i]+"]";
  setarray @eq_c3[@e],@inventorylist_card3[@i];
  if(@debug) dispbottom "Card 3: "+ getitemname(@inventorylist_card3[@i])+" ["+@inventorylist_card3[@i]+"]";
  setarray @eq_c4[@e],@inventorylist_card4[@i];
  if(@debug) dispbottom "Card 4: "+ getitemname(@inventorylist_card4[@i])+" ["+@inventorylist_card4[@i]+"]";
  if(@debug) dispbottom "------------------------------------------------------";
  if(@debug) dispbottom "Array Sizes: Card 1: "+getarraysize(@eq_c1)+" - Card 2: "+getarraysize(@eq_c2)+" - Card 3: "+getarraysize(@eq_c3)+" - Card 4: "+getarraysize(@eq_c4);
  if(@debug) dispbottom "=============================================";
  if(@debug) dispbottom " ";
  // Menu Creation
  set @it_m$,@it_m$ + "- (+"+@inventorylist_refine[@i]+") " + getitemname(@inventorylist_id[@i])+" ["+getitemslots(@inventorylist_id[@i])+"]" + ( (@inventorylist_id[@i+1])?":":"");

  // New Array Position:
  // getarraysize would be bugged if an entry would be 0
  // since it won't be counted as a valid value
  set @e,@e + 1;
 }
 // Available Cards
 if(getiteminfo(@inventorylist_id[@i],2) == 6) {
  setarray (@ca_list[getarraysize(@ca_list)],@inventorylist_id[@i]);
  setarray (@ca_am[getarraysize(@ca_am)],@inventorylist_amount[@i]);
 }
}
// Menu Selection
set @id,select(@it_m$) - 1;

set @max_c,getitemslots(@eq_list[@id]);
if(getd("@eq_c"+@max_c+"["+@id+"]") > 0) {
 mes .n$;
 mes "Each slot is in usage already, please uncompound the current cards and try again.";
 close;
}
set @cards,0;

set @slots,@max_c;
set @c,1;
while(@c <= @max_c) {
 if(getd("@eq_c"+@c+"["+@id+"]") == 0) {
  set @ca_m$,"";
  for ( set @l,0; @l < getarraysize(@ca_list); set @l,@l + 1)
   set @ca_m$,@ca_m$ + "- "+getitemname(@ca_list[@l]) + " ("+@ca_am[@l]+")" + ( (@ca_list[@l+1])?":":"");
  mes .n$;
  mes "Slots left: "+@slots;
  next;
  if(prompt(@ca_m$) != 255) {
   setd("@card"+@c),@ca_list[@menu-1];
   if(@ca_am[@menu-1] == 1) {
 deletearray @ca_list[@menu-1],1;
 deletearray @ca_am[@menu-1],1;
   } else setarray @ca_am[@menu-1],@ca_am[@menu-1] - 1;

  } else setd("@card"+@c),0;
  if(getd("@card"+@c) != 0) set @cards,@cards + 1;
 }
 set @slots,@slots - 1;
set @c,@c + 1;
}
mes .n$;
mes "You will recieve the following Item:";
mes "Name: 1x +"+@eq_ref[@id]+" "+ getitemname(@eq_list[@id]) + " with these cards:";
if(!@cards) { // No new Cards inserted!
 mes "Error: No Cards inserted.";
 close;
}
if(@card1) mes "Card 1: "+ getitemname(@card1)+" ["+@card1+"]";
if(@card2) mes "Card 2: "+ getitemname(@card2)+" ["+@card2+"]";
if(@card3) mes "Card 3: "+ getitemname(@card3)+" ["+@card3+"]";
if(@card4) mes "Card 4: "+ getitemname(@card4)+" ["+@card4+"]";
if(.requ[0] > 0) {
 set @cost,.requ[1]*@cards;
 mes " ";
 mes "Therefore I require";
 mes @cost + ( (.requ[0] > 500)?"x ":" ") + ( (.requ[0] == 1)?"Zeny" (.requ[0] == 2)?"Cash Points" (.requ[0] > 3)?getitemname(.requ[0]):"Custom Points")));
 mes "Proceed?";
 if(select("- Yes:- No") - 1) close;

 if(.requ[0] == 1 && Zeny < @cost ) {
  mes "I'm sorry, but you don't have the required Zeny for inserting "+@cards+" Cards.";
  mes "You'll need "+@cost+" Zeny.";
  close;
 } else if(.requ[0] == 2 && #CASHPOINTS < @cost) {
  mes "I'm sorry, but you don't have the required Cash Points for inserting "+@cards+" Cards.";
  mes "You'll need "+@cost+" Cash Points.";
  close;
 } else if(.requ[0] == 3 && custom_points < @cost) {
  mes "I'm sorry, but you don't have the required Custom Points for inserting "+@cards+" Cards.";
  mes "You'll need "+@cost+" Custom Points.";
  close;
 } else if(.requ[0] > 500 && countitem(.requ[0]) < @cost) {
  mes "I'm sorry, but you don't have the required "+getitemname(.requ[0])+" for inserting "+@cards+" Cards.";
  mes "You'll need "+@cost+" "+getitemname(.requ[0])+".";
  close;
 }
}
// If there are cards inserted already,
// re-add them also else they will be deleted
// and only the new card will be added.
if(!@card1 && @eq_c1[@id]) set @card1,@eq_c1[@id];
if(!@card2 && @eq_c2[@id]) set @card2,@eq_c2[@id];
if(!@card3 && @eq_c3[@id]) set @card3,@eq_c3[@id];
if(!@card4 && @eq_c4[@id]) set @card4,@eq_c4[@id];

 delitem2 @eq_list[@id],1,1,@eq_ref[@id],0,@eq_c1[@id],@eq_c2[@id],@eq_c3[@id],@eq_c4[@id];
getitem2 @eq_list[@id],1,1,@eq_ref[@id],0,@card1,@card2,@card3,@card4;
for ( set @c,1; @c <= @max_c; set @c,@c+1)
 if(getd("@card"+@c)) delitem getd("@card"+@c),1;
if(.requ[0] == 1) set Zeny,Zeny - @cost;
else if(.requ[0] == 2) set #CASHPOINTS,#CASHPOINTS - @cost;
else if(.requ[0] == 3) set custom_points,custom_points - @cost;
else if(.requ[0] > 500) delitem .requ[0],.requ[1];
close;
case 2:
mes .n$;
mes "I am able to insert cards in any equipment you want.";
if(.requ[0] == 0) close;
mes "The only thing I require is";
mes .requ[1] + ( (.requ[0] > 500)?"x ":" ") + ( (.requ[0] == 1)?"Zeny" (.requ[0] == 2)?"Cash Points" (.requ[0] > 3)?getitemname(.requ[0]):"Custom Points")));
mes "for each card you inserted.";
close;

case 3:
close;
}
}

after using it for the 2nd time, on the 2nd slot (my HG slot is 2) i get that error.. causing the cards to be dupped..

help me fix this Plssssssssssssssssssssssssssss? thank you!

Link to comment
Share on other sites

9 answers to this question

Recommended Posts

goddameit Poring

goddameit

Posted
  • Group:  Members
  • Topic Count:  60
  • Topics Per Day:  0.01
  • Content Count:  562
  • Reputation:   219
  • Joined:  11/22/11
  • Last Seen:  
Posted

clean variable, all of this '@' type.

Link to comment
Share on other sites
Critica Poring

Critica

Posted
  • Group:  Members
  • Topic Count:  82
  • Topics Per Day:  0.02
  • Content Count:  223
  • Reputation:   4
  • Joined:  02/23/12
  • Last Seen:  
  • Author
Posted

Im sorry.. what exactly do you want me to do..?

Link to comment
Share on other sites
plankt Poring

plankt

Posted
  • Group:  Members
  • Topic Count:  7
  • Topics Per Day:  0.00
  • Content Count:  130
  • Reputation:   43
  • Joined:  12/11/11
  • Last Seen:  
Posted

What he means is that a temporary character variable, @var, will have the same value until it's overwritten or the user logs off.

You must make sure that when the user runs the script for the second time, the variable values aren't messing with it.

Link to comment
Share on other sites
_Dynosawr_ Poring

_Dynosawr_

Posted
  • Group:  Members
  • Topic Count:  11
  • Topics Per Day:  0.00
  • Content Count:  69
  • Reputation:   10
  • Joined:  05/14/12
  • Last Seen:  
Posted

Try using temporary NPC variables. '.@' is the prefix.

Link to comment
Share on other sites
Critica Poring

Critica

Posted
  • Group:  Members
  • Topic Count:  82
  • Topics Per Day:  0.02
  • Content Count:  223
  • Reputation:   4
  • Joined:  02/23/12
  • Last Seen:  
  • Author
Posted

ok i understand now why the players are able to dupe,,

im sorry again.. is there anyone here able to teach me which lines are to change, i really dont know much anything about scripting.. i can only do the basic..

if someone could help me correct the script that would be grateful.. thank you, sorry for my english.

Link to comment
Share on other sites
_Dynosawr_ Poring

_Dynosawr_

Posted
  • Group:  Members
  • Topic Count:  11
  • Topics Per Day:  0.00
  • Content Count:  69
  • Reputation:   10
  • Joined:  05/14/12
  • Last Seen:  
Posted

Change every single variable that starts with @ to .@

Link to comment
Share on other sites
plankt Poring

plankt

Posted
  • Group:  Members
  • Topic Count:  7
  • Topics Per Day:  0.00
  • Content Count:  130
  • Reputation:   43
  • Joined:  12/11/11
  • Last Seen:  
Posted

Except @inventorylist_id and @inventorylist_amount. They need to stay '@'.

Link to comment
Share on other sites
_Dynosawr_ Poring

_Dynosawr_

Posted
  • Group:  Members
  • Topic Count:  11
  • Topics Per Day:  0.00
  • Content Count:  69
  • Reputation:   10
  • Joined:  05/14/12
  • Last Seen:  
Posted

Yeah, didn't see those.

Link to comment
Share on other sites
Critica Poring

Critica

Posted
  • Group:  Members
  • Topic Count:  82
  • Topics Per Day:  0.02
  • Content Count:  223
  • Reputation:   4
  • Joined:  02/23/12
  • Last Seen:  
  • Author
Posted

okk.. i tried it,, put " . " to every " @ " on the script except those, but know im getting stuck and this debug error

data: variable name='@ca_list'

now every @ca_list i removed the " . " but still getting stack after clicking the cards..

help...?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to question listing
×
×
  • Create New...