LatSo Posted July 17, 2013 Group: Members Topic Count: 69 Topics Per Day: 0.02 Content Count: 296 Reputation: 2 Joined: 04/11/13 Last Seen: December 22, 2020 Share Posted July 17, 2013 Will manual update of this work? Link to comment Share on other sites More sharing options...
LatSo Posted July 19, 2013 Group: Members Topic Count: 69 Topics Per Day: 0.02 Content Count: 296 Reputation: 2 Joined: 04/11/13 Last Seen: December 22, 2020 Share Posted July 19, 2013 anyone can confirm that manual patching will work? Link to comment Share on other sites More sharing options...
dice4real Posted July 20, 2013 Group: Members Topic Count: 1 Topics Per Day: 0.00 Content Count: 45 Reputation: 1 Joined: 10/18/12 Last Seen: June 26, 2018 Share Posted July 20, 2013 Im using 17422. and i try the latest one v2.1. and its not working. can someone help me please. Link to comment Share on other sites More sharing options...
dice4real Posted July 22, 2013 Group: Members Topic Count: 1 Topics Per Day: 0.00 Content Count: 45 Reputation: 1 Joined: 10/18/12 Last Seen: June 26, 2018 Share Posted July 22, 2013 (edited) THIS PART IS THE PROBLEM: @@ -3102,6 +3136,8 @@ if( sd ) {+ ATK_ADDRATE(battle_SAD(sd, target, skill_id)); // Manage Skill Damage [Lilith]+ if (skill_id && (i = pc_skillatk_bonus(sd, skill_id))) ATK_ADDRATE(i); BECAUSE IN NEW REV IS THIS: #ifdef RENEWAL ATK_ADD(wd.equipAtk, wd.equipAtk2, ratio); // equip ATK gets modified by skill bonuses as well [helvetica]#endif // add any miscellaneous player ATK bonuses if( sd && skill_id && (i = pc_skillatk_bonus(sd, skill_id))) { ATK_ADDRATE(wd.damage, wd.damage2, i); RE_ALLATK_ADDRATE(wd, i); } Can someone rebuild and edit for latest revisions. im using 17425. Thnk you for Reply Edited July 22, 2013 by dice4real Link to comment Share on other sites More sharing options...
AngelRO Posted July 27, 2013 Group: Members Topic Count: 5 Topics Per Day: 0.00 Content Count: 34 Reputation: 2 Joined: 09/25/12 Last Seen: November 23, 2020 Share Posted July 27, 2013 I need this so badly. Link to comment Share on other sites More sharing options...
solid2005 Posted July 29, 2013 Group: Members Topic Count: 20 Topics Per Day: 0.00 Content Count: 145 Reputation: 15 Joined: 01/06/12 Last Seen: Friday at 08:23 AM Share Posted July 29, 2013 maybe this can be help. I did not test yet. rAthena 17435 fix compile error. manage skill damage 2.2 BETA.patch Link to comment Share on other sites More sharing options...
FutureGazer Posted July 29, 2013 Group: Members Topic Count: 9 Topics Per Day: 0.00 Content Count: 23 Reputation: 0 Joined: 06/06/12 Last Seen: September 11, 2013 Share Posted July 29, 2013 got this error on my r17348 using that manage skill damage 2.2 beta battle.c: In function âbattle_SADâ: battle.c:1701: warning: suggest parentheses around â&&â within â||â battle.c:1702: warning: suggest parentheses around â&&â within â||â battle.c:1703: warning: suggest parentheses around â&&â within â||â battle.c:1704: warning: suggest parentheses around â&&â within â||â battle.c:3292:72: error: macro "ATK_ADDRATE" passed 3 arguments, but takes just 1 battle.c: In function âbattle_calc_weapon_attackâ: battle.c:3292: error: âATK_ADDRATEâ undeclared (first use in this function) battle.c:3292: error: (Each undeclared identifier is reported only once battle.c:3292: error: for each function it appears in.) battle.c: In function âbattle_calc_misc_attackâ: battle.c:4637: warning: suggest parentheses around assignment used as truth value Link to comment Share on other sites More sharing options...
AngelRO Posted July 29, 2013 Group: Members Topic Count: 5 Topics Per Day: 0.00 Content Count: 34 Reputation: 2 Joined: 09/25/12 Last Seen: November 23, 2020 Share Posted July 29, 2013 Thanks solid2005, for taking your time to adapt the code. I will test it now. It worked! Thank you so much! Ps: The increased damage is just a bit inaccurate. Link to comment Share on other sites More sharing options...
LatSo Posted July 31, 2013 Group: Members Topic Count: 69 Topics Per Day: 0.02 Content Count: 296 Reputation: 2 Joined: 04/11/13 Last Seen: December 22, 2020 Share Posted July 31, 2013 There is no error, but the damage increase/decrease is not working i think? Link to comment Share on other sites More sharing options...
LatSo Posted August 4, 2013 Group: Members Topic Count: 69 Topics Per Day: 0.02 Content Count: 296 Reputation: 2 Joined: 04/11/13 Last Seen: December 22, 2020 Share Posted August 4, 2013 maybe this can be help. I did not test yet. rAthena 17435 fix compile error. the damage increase/decrease is not working Link to comment Share on other sites More sharing options...
OunoriBaka Posted August 5, 2013 Group: Members Topic Count: 6 Topics Per Day: 0.00 Content Count: 19 Reputation: 0 Joined: 06/27/13 Last Seen: August 19, 2013 Share Posted August 5, 2013 im having a problem compiling. using solid05's 2.2beta. with my test server (windows) no problem. but when i tried via vps which is centOS, after compilation my map server does not at all. T_T... great release btw. Link to comment Share on other sites More sharing options...
solid2005 Posted August 6, 2013 Group: Members Topic Count: 20 Topics Per Day: 0.00 Content Count: 145 Reputation: 15 Joined: 01/06/12 Last Seen: Friday at 08:23 AM Share Posted August 6, 2013 this is the problem, need some one modify this one. or i have wrong place the code. ATK_ADDRATE(wd.damage, wd.damage2, battle_SAD(sd, target, skill_id)); // Manage Skill Damage [Lilith] Link to comment Share on other sites More sharing options...
LatSo Posted August 6, 2013 Group: Members Topic Count: 69 Topics Per Day: 0.02 Content Count: 296 Reputation: 2 Joined: 04/11/13 Last Seen: December 22, 2020 Share Posted August 6, 2013 I hope someone can help you in this! Link to comment Share on other sites More sharing options...
Cydh Posted August 8, 2013 Group: Developer Topic Count: 153 Topics Per Day: 0.04 Content Count: 2285 Reputation: 745 Joined: 06/16/12 Last Seen: June 30, 2023 Share Posted August 8, 2013 this is the problem, need some one modify this one. or i have wrong place the code. ATK_ADDRATE(wd.damage, wd.damage2, battle_SAD(sd, target, skill_id)); // Manage Skill Damage [Lilith] for latest revs, u're right, ATK_ADDRATE needs 3 params Link to comment Share on other sites More sharing options...
LatSo Posted August 8, 2013 Group: Members Topic Count: 69 Topics Per Day: 0.02 Content Count: 296 Reputation: 2 Joined: 04/11/13 Last Seen: December 22, 2020 Share Posted August 8, 2013 And to fix it what we need to edit/add ? Link to comment Share on other sites More sharing options...
Cydh Posted August 8, 2013 Group: Developer Topic Count: 153 Topics Per Day: 0.04 Content Count: 2285 Reputation: 745 Joined: 06/16/12 Last Seen: June 30, 2023 Share Posted August 8, 2013 And to fix it what we need to edit/add ? or maybe the problem is the placement Manage_Skill_Damage_2.1_byLilith-rA-r11360_(SVNbyGit).patch Link to comment Share on other sites More sharing options...
LatSo Posted August 8, 2013 Group: Members Topic Count: 69 Topics Per Day: 0.02 Content Count: 296 Reputation: 2 Joined: 04/11/13 Last Seen: December 22, 2020 Share Posted August 8, 2013 will surely try this one. I got this warnings: battle.c: In function âbattle_SADâ: battle.c:1742: warning: suggest parentheses around â&&â within â||â battle.c:1742: warning: suggest parentheses around â&&â within â||â battle.c:1742: warning: suggest parentheses around â&&â within â||â battle.c:1742: warning: suggest parentheses around â&&â within â||â battle.c: In function âbattle_calc_misc_attackâ: battle.c:5530: warning: suggest parentheses around assignment used as truth value Link to comment Share on other sites More sharing options...
Cydh Posted August 9, 2013 Group: Developer Topic Count: 153 Topics Per Day: 0.04 Content Count: 2285 Reputation: 745 Joined: 06/16/12 Last Seen: June 30, 2023 Share Posted August 9, 2013 @LatSo, do use mine? I updated the patch file Link to comment Share on other sites More sharing options...
LatSo Posted August 9, 2013 Group: Members Topic Count: 69 Topics Per Day: 0.02 Content Count: 296 Reputation: 2 Joined: 04/11/13 Last Seen: December 22, 2020 Share Posted August 9, 2013 Yes I use yours, your first patch is working theres just a warning. Will try your 2nd patch and see if theres warning Link to comment Share on other sites More sharing options...
dice4real Posted August 12, 2013 Group: Members Topic Count: 1 Topics Per Day: 0.00 Content Count: 45 Reputation: 1 Joined: 10/18/12 Last Seen: June 26, 2018 Share Posted August 12, 2013 Help please im using r17454. no errors but its nor working itry it on extrimity fist. nothing happen. //MO_EXTREMITYFIST271,0,-80,-80,-80,-80 i did it like that/ sorry for my bad english. CC battle.cbattle.c: In function \u2018battle_SAD\u2019:battle.c:1743: warning: suggest parentheses around && within ||battle.c:1744: warning: suggest parentheses around && within ||battle.c:1745: warning: suggest parentheses around && within ||battle.c:1746: warning: suggest parentheses around && within ||battle.c: In function \u2018battle_calc_misc_attack\u2019: And ive got this after compiling. Link to comment Share on other sites More sharing options...
solid2005 Posted August 13, 2013 Group: Members Topic Count: 20 Topics Per Day: 0.00 Content Count: 145 Reputation: 15 Joined: 01/06/12 Last Seen: Friday at 08:23 AM Share Posted August 13, 2013 (edited) Fix compile warning for svn. Only Support 17454. Backup first before apply this. manage_skill_damage_v2.2_rAthena17454.patch Edited August 14, 2013 by solid2005 1 Link to comment Share on other sites More sharing options...
Cydh Posted August 13, 2013 Group: Developer Topic Count: 153 Topics Per Day: 0.04 Content Count: 2285 Reputation: 745 Joined: 06/16/12 Last Seen: June 30, 2023 Share Posted August 13, 2013 Help please im using r17454. no errors but its nor working itry it on extrimity fist. nothing happen. //MO_EXTREMITYFIST 271,0,-80,-80,-80,-80 I just realized that the skill_damage will not worked if user only define 1 skill (I think the mod will works if player input all skill_db.txt to the skill_damage_db.txt) because Lilith used skill_db[skill_id] on her battle_SAD, it should skill_db[skill_get_index(skill_id)]. CC battle.c battle.c: In function \u2018battle_SAD\u2019: battle.c:1743: warning: suggest parentheses around && within || battle.c:1744: warning: suggest parentheses around && within || battle.c:1745: warning: suggest parentheses around && within || battle.c:1746: warning: suggest parentheses around && within || battle.c: In function \u2018battle_calc_misc_attack\u2019: And ive got this after compiling. which patch file do u use? Link to comment Share on other sites More sharing options...
krashdragon Posted August 13, 2013 Group: Members Topic Count: 13 Topics Per Day: 0.00 Content Count: 56 Reputation: 4 Joined: 06/20/13 Last Seen: August 31, 2021 Share Posted August 13, 2013 Fix compile warning for svn. Support 17454. Backup first before apply this. Hi i used version 17422 and failed recompile,Please help Link to comment Share on other sites More sharing options...
LatSo Posted August 14, 2013 Group: Members Topic Count: 69 Topics Per Day: 0.02 Content Count: 296 Reputation: 2 Joined: 04/11/13 Last Seen: December 22, 2020 Share Posted August 14, 2013 Fix compile warning for svn. Support 17454. Backup first before apply this. Hi i used version 17422 and failed recompile,Please help as you can see the one you've patched is supporting svn 17454 or higher. update your svn to latest or at least 17454 Link to comment Share on other sites More sharing options...
krashdragon Posted August 14, 2013 Group: Members Topic Count: 13 Topics Per Day: 0.00 Content Count: 56 Reputation: 4 Joined: 06/20/13 Last Seen: August 31, 2021 Share Posted August 14, 2013 which version should i use for revision 17422? Link to comment Share on other sites More sharing options...
Recommended Posts