Custom Autolooting

[nickyb]

I'm trying to add an additional loot command to only autoloot if an item does not have a drop effect set in the DB. I still haven't gotten this new command filter to work correctly because it's still looting everything. If anyone spots where I'm going wrong it would be greatly appreciated.

 

 /*==========================================
* @lootcommon - autoloots common items and drops most rares with drop effects.
* Made by Moobs/NickyB
 *------------------------------------------*/
ACMD_FUNC(lootcommon)
{
	int rate;
	nullpo_retr(-1, sd);

	if (sd->state.autoloot)
			rate = 0;
		else
			rate = 10000;

	sd->state.autoloot = rate;

	if (sd->state.autoloot) {
		clif_displaymessage(fd, "Autoloot common loot is now enabled.");
		sd->state.lootcommon = 1;
	}else{
		clif_displaymessage(fd, "Autoloot common loot is now disabled."); // Autoloot is now off.
		sd->state.lootcommon = 0;
	}
	return 0;
}

pc.cpp

/**
 * Check if player is autolooting given itemID.
 */
bool pc_isautolooting(struct map_session_data *sd, t_itemid nameid)
{
	uint8 i = 0;

	std::shared_ptr<item_data> item_data;
	item_data = item_db.find(nameid);

	//add lootcommon 
	if (sd->state.lootcommon && item_data->flag.dropEffect != 0)
		return false;

	if (sd->state.autoloottype && sd->state.autoloottype&(1<<itemdb_type(nameid)))
		return true;

	if (!sd->state.autolooting)
		return false;

	if (sd->state.autolooting)
		ARR_FIND(0, AUTOLOOTITEM_SIZE, i, sd->state.autolootid[i] == nameid);

	return (i != AUTOLOOTITEM_SIZE);
}

 

Edited July 1, 2022 by nickyb

[Start_]

Please revert all code modified and use this instead.

\src\map\mob.cpp  Line 2212

	if( test_autoloot && (itemdb_dropeffect(ditem->item_data.nameid) <= 0)) {	//Autoloot.

[Litro Endemic]

pc.cpp

replace

	//add lootcommon 
	if (sd->state.lootcommon && item_data->flag.dropEffect != 0)
		return false;

with

	//add lootcommon 
	if (sd->state.lootcommon)
		return (item_data->flag.dropEffect == 0);

 

[nickyb]

12 minutes ago, Litro Endemic said:

pc.cpp

replace

	//add lootcommon 
	if (sd->state.lootcommon && item_data->flag.dropEffect != 0)
		return false;

with

	//add lootcommon 
	if (sd->state.lootcommon)
		return (item_data->flag.dropEffect == 0);

 

Thanks, still autolooting everything, but I'll continue to work on it. There may be a bug in the custom command as well.

[nickyb]

2 hours ago, Start_ said:

Please revert all code modified and use this instead.

\src\map\mob.cpp  Line 2212

	if( test_autoloot && (itemdb_dropeffect(ditem->item_data.nameid) <= 0)) {	//Autoloot.

 

Thank you very much, works perfectly!