Custom #command

[QwertyD]

Hey guys, 

 

I was trying to make a custom @command named @reward that gives zeny to a player as an event reward, but if player has spaces on their name eg: M y C h A r N a m e, then the custom command fails. I know # commands work on this by adding " " before and after the character name but how do I make my own custom #command?

Example:

#reward "N a M e" 10000

To give 10000 zeny reward to that player.

 

Thanks!

Edited July 4, 2020 by QwertyD

[Kreustoo]

Hello,

# commands make the player using the command as if they did it themself using @.

So you may change your @reward command to NOT take in parameter a player, but gives to the player using it the reward, so:

@reward 10000 - would give you 10000 zeny
#reward "N a M e" 10000 - would give N a M e 10000 zeny

And you don't give the @reward command right to the basic players and it should do the job.

---

Another way is to split the parameters you get, and change how you give them, like:

@reward N a M e#10000

And you split on # on know on [0] it's the name and on [1] it's the number (but be carefull what you're doing there).

---

Or like vip command, you put the name at the end, just watch in the src how it's done:

ACMD_FUNC(vip) {
	struct map_session_data *pl_sd = NULL;
	char * modif_p;
	int32 vipdifftime = 0;
	time_t now=time(NULL);

	nullpo_retr(-1, sd);

	memset(atcmd_output, '\0', sizeof(atcmd_output));

	if (!message || !*message || sscanf(message, "%255s %23[^\n]",atcmd_output,atcmd_player_name) < 2) {
		clif_displaymessage(fd, msg_txt(sd,700));	//Usage: @vip <timef> <character name>
		return -1;
	}

	atcmd_output[sizeof(atcmd_output)-1] = '\0';

	modif_p = atcmd_output;
	vipdifftime = (int32)solve_time(modif_p);
	if (vipdifftime == 0) {
		clif_displaymessage(fd, msg_txt(sd,701)); // Invalid time for vip command.
		clif_displaymessage(fd, msg_txt(sd,702)); // Time parameter format is +/-<value> to alter. y/a = Year, m = Month, d/j = Day, h = Hour, n/mn = Minute, s = Second.
		return -1;
	}

	if ((pl_sd = map_nick2sd(atcmd_player_name,false)) == NULL) {
		clif_displaymessage(fd, msg_txt(sd,3)); // Character not found.
		return -1;
	}

And adapt the first parameter to work without having to solve_time (just an integer).

[QwertyD]

7 hours ago, Kreustoo said:

Hello,

# commands make the player using the command as if they did it themself using @.

So you may change your @reward command to NOT take in parameter a player, but gives to the player using it the reward, so:

@reward 10000 - would give you 10000 zeny
#reward "N a M e" 10000 - would give N a M e 10000 zeny

And you don't give the @reward command right to the basic players and it should do the job.

---

Another way is to split the parameters you get, and change how you give them, like:

@reward N a M e#10000

And you split on # on know on [0] it's the name and on [1] it's the number (but be carefull what you're doing there).

---

Or like vip command, you put the name at the end, just watch in the src how it's done:

ACMD_FUNC(vip) {
	struct map_session_data *pl_sd = NULL;
	char * modif_p;
	int32 vipdifftime = 0;
	time_t now=time(NULL);

	nullpo_retr(-1, sd);

	memset(atcmd_output, '\0', sizeof(atcmd_output));

	if (!message || !*message || sscanf(message, "%255s %23[^\n]",atcmd_output,atcmd_player_name) < 2) {
		clif_displaymessage(fd, msg_txt(sd,700));	//Usage: @vip <timef> <character name>
		return -1;
	}

	atcmd_output[sizeof(atcmd_output)-1] = '\0';

	modif_p = atcmd_output;
	vipdifftime = (int32)solve_time(modif_p);
	if (vipdifftime == 0) {
		clif_displaymessage(fd, msg_txt(sd,701)); // Invalid time for vip command.
		clif_displaymessage(fd, msg_txt(sd,702)); // Time parameter format is +/-<value> to alter. y/a = Year, m = Month, d/j = Day, h = Hour, n/mn = Minute, s = Second.
		return -1;
	}

	if ((pl_sd = map_nick2sd(atcmd_player_name,false)) == NULL) {
		clif_displaymessage(fd, msg_txt(sd,3)); // Character not found.
		return -1;
	}

And adapt the first parameter to work without having to solve_time (just an integer).

Thank you