Does anyone know how to fix? homunculus affected by song?

[iamjhigz]

i dont know if im in right place to ask this.
Does anyone know how to fix homunculus will not be affected by songs? of bard and dancer? 
Cant find any on google/rathena . 
https://gitlab.com/originsro/originsro/-/issues/1325

Thanks in advance.

[Haruka Mayumi]

		case UNT_WHISTLE:
		case UNT_ASSASSINCROSS:
		case UNT_POEMBRAGI:
		case UNT_APPLEIDUN:
		case UNT_HUMMING:
		case UNT_DONTFORGETME:
		case UNT_FORTUNEKISS:
		case UNT_SERVICEFORYOU:
+			if(bl->type == BL_HOM) return 0;
			if (sg->src_id==bl->id && !(sc && sc->data[SC_SPIRIT] && sc->data[SC_SPIRIT]->val2 == SL_BARDDANCER))
				return 0;

			if (!sc) return 0;
			if (!sce)
				sc_start4(ss, bl,type,100,sg->skill_lv,sg->val1,sg->val2,0,sg->limit);
			else if (sce->val4 == 1) { //Readjust timers since the effect will not last long.
				sce->val4 = 0; //remove the mark that we stepped out
				delete_timer(sce->timer, status_change_timer);
				sce->timer = add_timer(tick+sg->limit, status_change_timer, bl->id, type); //put duration back to 3min
			}
			break;

 

[iamjhigz]

@Humble_Bee will not be affected by song cause its Over power. spamming caprice + super attackspeed. in official it should not be affect by song.

Hope you can help me brother.

@Humble_Bee settting the max aspd at castime reduce? 
ill try it later.. nice idea thou. Thanks for replying  

@Humble_Bee Thanks for the effort  You'll help many server owner didn't know how to fix this issue.
does this remove all songs? like Assassin  Cross of Sunset?

Edited May 21, 2020 by iamjhigz

[Humble_Bee]

6 hours ago, iamjhigz said:

@Humble_Bee Thanks for the effort  You'll help many server owner didn't know how to fix this issue.
does this remove all songs? like Assassin  Cross of Sunset?

It should remove all songs that cause a buff, including Assassin Cross of Sunset and Apple of Idun's heal and the others. What I don't think it is does is stop damage songs from causing damage to your homun or other people's homun. Again, note, please test it out first before sending it live if possible, as that way you can see if it causes any bugs on your server. Mess around playing with a homun quite a bit with it, as my bard using a homun (which they normally don't) had some map server crashes, but they may be related to my bard using a homun or to other server issues I might have.

[Humble_Bee]

I believe this is the answer: Go to your skill.cpp file. Here you will make 2 changes.

Change #1
Look for this section of code:
 

Spoiler

    if( skill_get_inf2(sg->skill_id)&(INF2_SONG_DANCE|INF2_ENSEMBLE_SKILL) && map_getcell(bl->m, bl->x, bl->y, CELL_CHKBASILICA) )
        return 0; //Songs don't work in Basilica

Right below it, add:
 

Spoiler

    if( skill_get_inf2(sg->skill_id)&(INF2_SONG_DANCE|INF2_ENSEMBLE_SKILL) && bl->type==BL_HOM )
        return 0; //Songs don't work on homunculus

Change #2
Look for this section of code:
 

Spoiler

        case UNT_APPLEIDUN: { //Apple of Idun [Skotlex]
                int heal;
#ifdef RENEWAL
                struct mob_data *md = BL_CAST(BL_MOB, bl);

                if (md && md->mob_id == MOBID_EMPERIUM)
                    break;
#endif

Right below the #endif, add:

Spoiler

                if (bl->type == BL_HOM)
                    break;

Note: Damage songs will still likely hit your homun, because I didn't mess with that. This just gets rid of the buffs and heals from songs. Also, I would try this on a test server before hitting live with it.

Edited July 24, 2020 by Humble_Bee
I believe I have the fix.