Having a problem with my script

Noire · April 14, 2020

When i try to kill player inside those error pop up whats wrong with this script ? >.<

Edited May 1, 2020 by Noire

Functor · April 14, 2020

https://rathena.org/board/topic/119467-pvp-ladder-error-and-debug/

Noire · April 14, 2020

solved thanks

uhmmm,, can i ask for help again ! when i tried to kill a monster im having an error like this >.<

Radian · April 14, 2020

Im not sure about this, because i only see a screenshot and cannot see the script well.. try putting it like this

OnMVPDeath:
		end;
OnInit:

Noire · April 15, 2020

here sorry >>.<<

Edited April 15, 2020 by Noire

Radian · April 15, 2020

What's the result of the changes?

Noire · April 15, 2020

still same T_T after kill the monster

Edited April 15, 2020 by Noire

Patskie · April 15, 2020

Please share the whole script

Noire · April 15, 2020

here sorry for not uploading

Edited May 1, 2020 by Noire
codebox

-Chuck- · April 15, 2020

I didnt look how the npc works, only fixed the error...

Could you try this please?

Spoiler

prontera,119,168,6 script Skormy 641,{
    if(getgmlevel()<.gmlevel) end;
    set .@MVPID,-3;

L_Menu:
    mes .NPC$;
    mes "Select an option from the menu below and click [ ^0000FFSummon!^000000 ] when you're done.";
    next;

    if(.@MVPID == -3){
       set .@tmp$,"Random MVP";
   } else if ( .@MVPID ) {
       set .@tmp$,getmonsterinfo(.@MVPID,0);
   } else {
       set .@tmp$,"NULL";
   }

    Switch(select("Monster ID ( ^0000FF"+.@tmp$+"^000000 ) :Map Name ( ^0000FF"+.@MAPNAME$+"^000000 ) :Amount ( ^0000FF"+.@AMOUNT+"^000000 ):[ ^0000FFSummon!^000000 ]")) {
        case 1:
            mes .NPC$;
            mes "Input the id of the monster you'd like to spawn.";
            next;
            input(.@MVPID);
            while(!query_sql("(SELECT `ID` from `mob_db` where `ID` = "+.@MVPID+") UNION ALL (SELECT `ID` from `mob_db2` where `ID` = "+.@MVPID+" LIMIT 1);",.@a))
                input(.@MVPID);

            if( compare(.blacklist$,"|"+.@MVPID+"|" ) ) {
                message strcharinfo(0),"I'm sorry but that monster was blacklisted!";
                message strcharinfo(0),"Please use a different id.";
                set(.@MVPID,0);
            }

            goto L_Menu;

        case 2:
            mes .NPC$;
            mes "Input the name of the map you'd like to spawn the monster on.";
            next;
            input(.@MAPNAME$);
            while(mobcount(.@MAPNAME$,"all")==-1){
                input(.@MAPNAME$);
                if(mobcount(.@MAPNAME$,"all")!=-1){
                    mes "Would you like to spawn "+(.@MVPID==-3?"Random MVPs":getmonsterinfo(.@MVPID,0))+" on the map "+.@MAPNAME$+"?";
                    next;
                    if(select("Yes:No")-1) { set .@MAPNAME$,""; continue; } else { break; }
                }
            }
            goto L_Menu;

        case 3:
            mes .NPC$;
            mes "Input the amount you'd like to spawn.";
            mes "( Maximum "+.Lamount+" )";
            next;
            input(.@AMOUNT);
            while(.@AMOUNT<=0||.@AMOUNT>.Lamount) {
                input(.@AMOUNT);
                if(.@AMOUNT>0&&.@AMOUNT<=.Lamount) {
                    mes "Would you like to spawn "+.@AMOUNT+" monsters?";
                    next;
                    if(select("Yes:No")-1) { set .@AMOUNT,0; continue; } else { break; }
                }
            }
            goto L_Menu;

        case 4:
            if( mobcount(.@MAPNAME$,"all")==-1 || .@AMOUNT<=0 ) {
                if(!.fiesta) {
                    mes .NPC$;
                    mes "I'm sorry you need to fill-out all the fields before summoning a monster!";
                    next;
                    goto L_Menu;
                } else {
                    if(mobcount(.@MAPNAME$,"all")==-1) set .@MAPNAME$,"this";
                    if(.@AMOUNT<=0) set .@AMOUNT,.fiesta;
                }
            }

            if(.Mamount){
                if(mobcount(.@MAPNAME$,"Skormy::OnMVPDeath")+.@AMOUNT>.Mamount&&.Mamount>0) {
                    mes .NPC$;
                    mes "I'm sorry but there can only be "+.Mamount+" MVPs in one map.";
                    set .@tmp,.Mamount-mobcount(.@MAPNAME$,"Skormy::OnMVPDeath");
                    if(.@tmp>0) {
                        mes "Would you like to spawn "+.@tmp+" instead?";
                        if(select("Yes:No")-1) { mes "Ok!"; close; }
                        announce ""+strcharinfo(0)+" : Summoned "+.@AMOUNT+" "+.@tmp$+"(s) in "+(.@MAPNAME$=="this"?strcharinfo(3):.@MAPNAME$)+".",bc_all,"0x"+.fontcolor$;
                        monster .@MAPNAME$,0,0,"--ja--",.@MVPID,.@tmp,"Skormy::OnMVPDeath";
                        close;
                    }
                    next;
                    goto L_Menu;
                }
            }

            announce ""+strcharinfo(0)+" : Summoned "+.@AMOUNT+" "+.@tmp$+"(s) in "+(.@MAPNAME$=="this"?strcharinfo(3):.@MAPNAME$)+".",bc_all,"0x"+.fontcolor$;
            monster .@MAPNAME$,0,0,"--ja--",.@MVPID,.@AMOUNT,"Skormy::OnMVPDeath";
            close;
    }
    end;

OnMVPDeath:
    end;

OnInit:
    //=-=-=-=-=-=Configuration=-=-=-=-=-=
    set .NPC$,"[ ^D2691ESkormy^000000 ]"; // Npc Name
    set .gmlevel,60; //Minimum Gm level allowed to spawn MVPS.
    set .fiesta,0; // If enabled will spawn that many random MVPs on the players map if no other information is provided! (Off=0) Will bypass Maximum amount!
    set .fontcolor$,"FFFF00"; // Hexi color text is announced in.
    set .Lamount,20; // Maximum amount of mvps that can be spawned at once.
    set .Mamount,100; // Maximum amount of mvps on one map at a time. (Off=0)
    set .blacklist$,"|1288|1003|1004|1005|";
    //=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
}

Edited April 15, 2020 by luanwg

Noire · April 15, 2020

31 minutes ago, -Chuck- said:

I didnt look how the npc works, only fixed the error...

Could you try this please?

Reveal hidden contents

prontera,119,168,6 script Skormy 641,{
    if(getgmlevel()<.gmlevel) end;
    set .@MVPID,-3;

L_Menu:
    mes .NPC$;
    mes "Select an option from the menu below and click [ ^0000FFSummon!^000000 ] when you're done.";
    next;

    if(.@MVPID == -3){
       set .@tmp$,"Random MVP";
   } else if ( .@MVPID ) {
       set .@tmp$,getmonsterinfo(.@MVPID,0);
   } else {
       set .@tmp$,"NULL";
   }

    Switch(select("Monster ID ( ^0000FF"+.@tmp$+"^000000 ) :Map Name ( ^0000FF"+.@MAPNAME$+"^000000 ) :Amount ( ^0000FF"+.@AMOUNT+"^000000 ):[ ^0000FFSummon!^000000 ]")) {
        case 1:
            mes .NPC$;
            mes "Input the id of the monster you'd like to spawn.";
            next;
            input(.@MVPID);
            while(!query_sql("(SELECT `ID` from `mob_db` where `ID` = "+.@MVPID+") UNION ALL (SELECT `ID` from `mob_db2` where `ID` = "+.@MVPID+" LIMIT 1);",.@a))
                input(.@MVPID);

            if( compare(.blacklist$,"|"+.@MVPID+"|" ) ) {
                message strcharinfo(0),"I'm sorry but that monster was blacklisted!";
                message strcharinfo(0),"Please use a different id.";
                set(.@MVPID,0);
            }

            goto L_Menu;

        case 2:
            mes .NPC$;
            mes "Input the name of the map you'd like to spawn the monster on.";
            next;
            input(.@MAPNAME$);
            while(mobcount(.@MAPNAME$,"all")==-1){
                input(.@MAPNAME$);
                if(mobcount(.@MAPNAME$,"all")!=-1){
                    mes "Would you like to spawn "+(.@MVPID==-3?"Random MVPs":getmonsterinfo(.@MVPID,0))+" on the map "+.@MAPNAME$+"?";
                    next;
                    if(select("Yes:No")-1) { set .@MAPNAME$,""; continue; } else { break; }
                }
            }
            goto L_Menu;

        case 3:
            mes .NPC$;
            mes "Input the amount you'd like to spawn.";
            mes "( Maximum "+.Lamount+" )";
            next;
            input(.@AMOUNT);
            while(.@AMOUNT<=0||.@AMOUNT>.Lamount) {
                input(.@AMOUNT);
                if(.@AMOUNT>0&&.@AMOUNT<=.Lamount) {
                    mes "Would you like to spawn "+.@AMOUNT+" monsters?";
                    next;
                    if(select("Yes:No")-1) { set .@AMOUNT,0; continue; } else { break; }
                }
            }
            goto L_Menu;

        case 4:
            if( mobcount(.@MAPNAME$,"all")==-1 || .@AMOUNT<=0 ) {
                if(!.fiesta) {
                    mes .NPC$;
                    mes "I'm sorry you need to fill-out all the fields before summoning a monster!";
                    next;
                    goto L_Menu;
                } else {
                    if(mobcount(.@MAPNAME$,"all")==-1) set .@MAPNAME$,"this";
                    if(.@AMOUNT<=0) set .@AMOUNT,.fiesta;
                }
            }

            if(.Mamount){
                if(mobcount(.@MAPNAME$,"Skormy::OnMVPDeath")+.@AMOUNT>.Mamount&&.Mamount>0) {
                    mes .NPC$;
                    mes "I'm sorry but there can only be "+.Mamount+" MVPs in one map.";
                    set .@tmp,.Mamount-mobcount(.@MAPNAME$,"Skormy::OnMVPDeath");
                    if(.@tmp>0) {
                        mes "Would you like to spawn "+.@tmp+" instead?";
                        if(select("Yes:No")-1) { mes "Ok!"; close; }
                        announce ""+strcharinfo(0)+" : Summoned "+.@AMOUNT+" "+.@tmp$+"(s) in "+(.@MAPNAME$=="this"?strcharinfo(3):.@MAPNAME$)+".",bc_all,"0x"+.fontcolor$;
                        monster .@MAPNAME$,0,0,"--ja--",.@MVPID,.@tmp,"Skormy::OnMVPDeath";
                        close;
                    }
                    next;
                    goto L_Menu;
                }
            }

            announce ""+strcharinfo(0)+" : Summoned "+.@AMOUNT+" "+.@tmp$+"(s) in "+(.@MAPNAME$=="this"?strcharinfo(3):.@MAPNAME$)+".",bc_all,"0x"+.fontcolor$;
            monster .@MAPNAME$,0,0,"--ja--",.@MVPID,.@AMOUNT,"Skormy::OnMVPDeath";
            close;
    }
    end;

OnMVPDeath:
    end;

OnInit:
    //=-=-=-=-=-=Configuration=-=-=-=-=-=
    set .NPC$,"[ ^D2691ESkormy^000000 ]"; // Npc Name
    set .gmlevel,60; //Minimum Gm level allowed to spawn MVPS.
    set .fiesta,0; // If enabled will spawn that many random MVPs on the players map if no other information is provided! (Off=0) Will bypass Maximum amount!
    set .fontcolor$,"FFFF00"; // Hexi color text is announced in.
    set .Lamount,20; // Maximum amount of mvps that can be spawned at once.
    set .Mamount,100; // Maximum amount of mvps on one map at a time. (Off=0)
    set .blacklist$,"|1288|1003|1004|1005|";
    //=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
}

image.png.1a4b35c5585664877d9aeb429c74363d.png

still having an error, this npc works like summoning an MVP mobs or Normal mobs.

-Chuck- · April 15, 2020

Ive just tried it here and got no errors.. I will paste into code..

Was reading this code, is called OnMVPDeath, but there is nothing on this event.. just a end;

 prontera,119,168,6	script	Skormy	641,{
	if(getgmlevel()<.gmlevel) end;
	set .@MVPID,-3;
	
L_Menu:
	mes .NPC$;
	mes "Select an option from the menu below and click [ ^0000FFSummon!^000000 ] when you're done.";
	next;
	
	if(.@MVPID == -3){
		set .@tmp$,"Random MVP";
	} else if ( .@MVPID ) {
		set .@tmp$,getmonsterinfo(.@MVPID,0);
	} else {
		set .@tmp$,"NULL";
	}

	Switch(select("Monster ID ( ^0000FF"+.@tmp$+"^000000 ) :Map Name ( ^0000FF"+.@MAPNAME$+"^000000 ) :Amount ( ^0000FF"+.@AMOUNT+"^000000 ):[ ^0000FFSummon!^000000 ]")) {
		case 1:
			mes .NPC$;
			mes "Input the id of the monster you'd like to spawn.";
			next;
			input(.@MVPID);
			while(!query_sql("(SELECT `ID` from `mob_db` where `ID` = "+.@MVPID+") UNION ALL (SELECT `ID` from `mob_db2` where `ID` = "+.@MVPID+" LIMIT 1);",.@a))
				input(.@MVPID);
				
			if( compare(.blacklist$,"|"+.@MVPID+"|" ) ) {
				message strcharinfo(0),"I'm sorry but that monster was blacklisted!";
				message strcharinfo(0),"Please use a different id.";
				set(.@MVPID,0);
			}
			
			goto L_Menu;
			
		case 2:
			mes .NPC$;
			mes "Input the name of the map you'd like to spawn the monster on.";
			next;
			input(.@MAPNAME$);
			while(mobcount(.@MAPNAME$,"all")==-1){
				input(.@MAPNAME$);
				if(mobcount(.@MAPNAME$,"all")!=-1){
					mes "Would you like to spawn "+(.@MVPID==-3?"Random MVPs":getmonsterinfo(.@MVPID,0))+" on the map "+.@MAPNAME$+"?";
					next;
					if(select("Yes:No")-1) { set .@MAPNAME$,""; continue; } else { break; }
				}
			}
			goto L_Menu;
			
		case 3:
			mes .NPC$;
			mes "Input the amount you'd like to spawn.";
			mes "( Maximum "+.Lamount+" )";
			next;
			input(.@AMOUNT);
			while(.@AMOUNT<=0||.@AMOUNT>.Lamount) {
				input(.@AMOUNT);
				if(.@AMOUNT>0&&.@AMOUNT<=.Lamount) {
					mes "Would you like to spawn "+.@AMOUNT+" monsters?";
					next;
					if(select("Yes:No")-1) { set .@AMOUNT,0; continue; } else { break; }
				}
			}
			goto L_Menu;
			
		case 4:
			if( mobcount(.@MAPNAME$,"all")==-1 || .@AMOUNT<=0 ) {
				if(!.fiesta) {
					mes .NPC$;
					mes "I'm sorry you need to fill-out all the fields before summoning a monster!";
					next;
					goto L_Menu;
				} else {
					if(mobcount(.@MAPNAME$,"all")==-1) set .@MAPNAME$,"this";
					if(.@AMOUNT<=0) set .@AMOUNT,.fiesta;
				}
			}
			
			if(.Mamount){
				if(mobcount(.@MAPNAME$,"Skormy::OnMVPDeath")+.@AMOUNT>.Mamount&&.Mamount>0) {
					mes .NPC$;
					mes "I'm sorry but there can only be "+.Mamount+" MVPs in one map.";
					set .@tmp,.Mamount-mobcount(.@MAPNAME$,"Skormy::OnMVPDeath");
					if(.@tmp>0) {
						mes "Would you like to spawn "+.@tmp+" instead?";
						if(select("Yes:No")-1) { mes "Ok!"; close; }
						announce ""+strcharinfo(0)+" : Summoned "+.@AMOUNT+" "+.@tmp$+"(s) in "+(.@MAPNAME$=="this"?strcharinfo(3):.@MAPNAME$)+".",bc_all,"0x"+.fontcolor$;
						monster .@MAPNAME$,0,0,"--ja--",.@MVPID,.@tmp,"Skormy::OnMVPDeath";
						close;
					}
					next;
					goto L_Menu;
				}
			}
		
			announce ""+strcharinfo(0)+" : Summoned "+.@AMOUNT+" "+.@tmp$+"(s) in "+(.@MAPNAME$=="this"?strcharinfo(3):.@MAPNAME$)+".",bc_all,"0x"+.fontcolor$;
			monster .@MAPNAME$,0,0,"--ja--",.@MVPID,.@AMOUNT,"Skormy::OnMVPDeath";
			close;
	}
	end;
	
OnMVPDeath:
	end;
			
OnInit:
	//=-=-=-=-=-=Configuration=-=-=-=-=-=
	set .NPC$,"[ ^D2691ESkormy^000000 ]"; // Npc Name
	set .gmlevel,60; //Minimum Gm level allowed to spawn MVPS.
	set .fiesta,0; // If enabled will spawn that many random MVPs on the players map if no other information is provided! (Off=0) Will bypass Maximum amount!
	set .fontcolor$,"FFFF00"; // Hexi color text is announced in.
	set .Lamount,20; // Maximum amount of mvps that can be spawned at once.
	set .Mamount,100; // Maximum amount of mvps on one map at a time. (Off=0)
	set .blacklist$,"|1288|1003|1004|1005|";
	//=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
}

Radian · April 15, 2020

Tested it and to solve the issue replaced all

MVP Spawner

into

Skormy

that would solve the missing label.

Noire · April 15, 2020

solved sorry my bad didnt see the script properly thanks u guys!

2 hours ago, Radian said:
Tested it and to solve the issue replaced all
MVP Spawner
into
Skormy
that would solve the missing label.

can add announcement for killing an mvp boss? but the announcement is like this for example i summon random mvp bosses each id will be include. ( Player "name" killed amonra boss and so on. advance tanks for helping me out

Edited April 15, 2020 by Noire

Radian · April 15, 2020

2 hours ago, Noire said:

solved sorry my bad didnt see the script properly thanks u guys!

can add announcement for killing an mvp boss? but the announcement is like this for example i summon random mvp bosses each id will be include. ( Player "name" killed amonra boss and so on. advance tanks for helping me out

After a few test, I manage to make it work. here you go!

OnMVPDeath:
	@name$ = getmonsterinfo( killedrid, MOB_NAME);
	announce strcharinfo(0) + " has killed the monster " + @name$ + " !! ",bc_all;
    	end;

Noire · April 15, 2020

22 minutes ago, Radian said:

After a few test, I manage to make it work. here you go!


OnMVPDeath:
	@name$ = getmonsterinfo( killedrid, MOB_NAME);
	announce strcharinfo(0) + " has killed the monster " + @name$ + " !! ",bc_all;
    	end;

all done thanks you guys !! ive learned alot sorry for asking too much!!

Sign In

Having a problem with my script

Question

Noire

15 answers to this question

Recommended Posts

Functor

Noire

Radian

Noire

Radian

Noire

Patskie

Noire

-Chuck-

Noire

-Chuck-

Radian

Noire

Radian

Noire

Join the conversation

Recently Browsing 0 members

Docs

Get Started

Github

Community

My Account