Absorb Spirit / Dispel cancels Asura (if cast finished first)

[CenturyGothic]

Hello everyone, this is how currently rAthena works. When you cast asura to anyone, regardless if you got dispelled/absorbed spirit, the asura will still continue and deal damage.

However in the old times, when absorb spirit / dispel finishes first, the asura will miss. (no damage) Does anyone have a diff to this?

Similar to when you cast asura to a player, and the player hides, asura miss (currently works in rAthena). The same thing needs to happen with Absorb Spirit and Dispel

 

Thanks in advance!

[Haruka Mayumi]

		case KO_ZANZOU: {
				int c = 0;

				i = map_foreachinmap(skill_check_condition_mob_master_sub, sd->bl.m, BL_MOB, sd->bl.id, MOBID_ZANZOU, skill_id, &c);
				if( c >= skill_get_maxcount(skill_id,skill_lv) || c != i) {
					clif_skill_fail(sd , skill_id, USESKILL_FAIL_LEVEL, 0);
					return false;
				}
			}
			break;
+		case MO_EXTREMITYFIST:
+				if( !sd->spiritball || !sd->sc.data[SC_EXPLOSIONSPIRITS]){
+					clif_skill_fail(sd , skill_id, USESKILL_FAIL_LEVEL, 0);
+					return false;
+				}
+			break;
	}

in skill.cpp

Edited January 9, 2020 by Haruka Mayumi

[CenturyGothic]

Thanks @Haruka Mayumi Testing the above. Will get back to this

Edit:

18 hours ago, Haruka Mayumi said:

		case KO_ZANZOU: {
				int c = 0;

				i = map_foreachinmap(skill_check_condition_mob_master_sub, sd->bl.m, BL_MOB, sd->bl.id, MOBID_ZANZOU, skill_id, &c);
				if( c >= skill_get_maxcount(skill_id,skill_lv) || c != i) {
					clif_skill_fail(sd , skill_id, USESKILL_FAIL_LEVEL, 0);
					return false;
				}
			}
			break;
+		case MO_EXTREMITYFIST:
+				if( !sd->spiritball || !sd->sc.data[SC_EXPLOSIONSPIRITS]){
+					clif_skill_fail(sd , skill_id, USESKILL_FAIL_LEVEL, 0);
+					return false;
+				}
+			break;
	}

in skill.cpp

 

The above worked! Thank you

Edited January 10, 2020 by Dublin