Avoid MATK Overflow

[Danilov3s]

Hey all! Greetings,

Recently I've been trying to avoid the MATK infamous overflow when it reaches the maximum, but no success at all.

I tried protecting the values from getting bigger than SHRT_MAX (32727) but still nothing changed

I tried poking aroud in the status.cpp, and found that when it executes this piece of code at line 5239
 

if (bl->type&BL_PC && sd->matk_rate != 100) {

            status->matk_max = status->matk_max * sd->matk_rate/100;

            status->matk_min = status->matk_min * sd->matk_rate/100;

}

And the matk_max is greater than 30097, the result is 87 (I'm not 100% sure about these values, but they're approximated)

I've also tried changing the matk_min and matk_max to int, but I'm not sure if I did it right..

This is what I mean by "overflow" (the values just go negative)

Spoiler

Thank you!

Edited December 16, 2019 by Slim

[Litro Endemic]

cap it to the desired value, use min or max or cap_value function 

[Danilov3s]

On 12/21/2019 at 7:50 AM, Litro Endemic said:

cap it to the desired value, use min or max or cap_value function 

Doesn't work, tried setting the status->matk_max before the formula but it still "overflow". I don't even know if the correct name is overflow

[Humble_Bee]

Try looking for this in status.cpp:

 

Spoiler

if(sd->matk_rate < 0)
        sd->matk_rate = 0;

And try adding right below it:
 

Spoiler

if(sd->matk_rate > yourdesiredmaxvalue)
        sd->matk_rate = yourdesiredmaxvalue;

Doing something like this for regen had worked for me in making a cap. If that doesn't work, I'll probably offer a few other things to try, but I'm relatively new to messing with code as well.

[Danilov3s]

14 hours ago, Humble_Bee said:

Try looking for this in status.cpp:

 

  Hide contents

if(sd->matk_rate < 0)
        sd->matk_rate = 0;

And try adding right below it:
 

  Hide contents

if(sd->matk_rate > yourdesiredmaxvalue)
        sd->matk_rate = yourdesiredmaxvalue;

Doing something like this for regen had worked for me in making a cap. If that doesn't work, I'll probably offer a few other things to try, but I'm relatively new to messing with code as well.

Thank you for your suggestion, but I got it working already...

I've changed the data types from both min and max to unsigned int, and changed every place that modify these values to cast it to int instead of short, and changed the caps from SHRT_MAX to USHRT_MAX. Also did some improvements in some formulas, like instead of using matk_max = matx_max + something, just matk_max += something; And last I changed the piece of code that calls clif to do a check whether the initial matk is 0 and reduce the max matk by 1.