Jump to content

Danilov3s

Members
  • Posts

    9
  • Joined

  • Last visited

Everything posted by Danilov3s

  1. I have started the work on this but didn't have any time nor interest to finish but I could get a proof of concept working. The concept is somewhat basic but I took a different approach than the officials, where they create a clone from your character and open the stall using that clone. I used the existing system for auctions and hooked an external web app to list the auctions. That external app would be able to buy the items, notifying the running server and then the server would send mails to both the seller and the buyer with their items. The external app talk via REST to a NodeJS/Express server which connects to rAthena via TCP streams and exchange raw packets. It seems a bit complicated, but once you get the hang of how packets work you'll be fine. On the rAthena side I've hooked some methods and packets to open/close auctions and to send mails. Node/Express server can be found here https://github.com/Danil0v3s/react.cp rAthena modifications can be found here https://github.com/Danil0v3s/broriginal/pull/11 And the external app I've created to use as a launcher using Electron.JS can be found here https://github.com/Danil0v3s/broriginal-launcher None of these wouldn't be possible without the help from Norminator, Nitrous, Zell and many others. If you have any questions regarding any of these, I'll keep an eye on this thread. And please, bear in mind that I haven't created any of these to be used by anyone else but me, so you won't find any comments or anything explaining anything and some solutions are completely hammered just to work
  2. It looks like it's not included in newer clients anymore
  3. Recently I heard of the new "offline vending" in official servers And I've been wondering how to achieve that, either it be on a "as close as possible" basis where I have the vending to work with inventory items and then on succesfully creating the vending the items would be removed from player's inventory and he could manage it from the server website (to cancel/change price/etc). Once cancelled or sold get the stuff back by RodEx, like in the video. From what I can see in the video, it looks like they create a fake cart for the player and then add the player's items to that cart and display the normal vending screen with a limited number of 4 items, since that's the max items you can send via RodEx. After proceeding with the vending, it allows you to aim and then creates a copy of your player with a vending (lol ?) Any directions on how to accomplish this would be much appreciated. So far I can create a vending using an atcommand I've created by cloning the contents of void clif_openvendingreq(struct map_session_data* sd, int num) and setting a state variable to bypass the vending control which checks if the vending was opened by using the skill
  4. Thank you for your suggestion, but I got it working already... I've changed the data types from both min and max to unsigned int, and changed every place that modify these values to cast it to int instead of short, and changed the caps from SHRT_MAX to USHRT_MAX. Also did some improvements in some formulas, like instead of using matk_max = matx_max + something, just matk_max += something; And last I changed the piece of code that calls clif to do a check whether the initial matk is 0 and reduce the max matk by 1.
  5. Doesn't work, tried setting the status->matk_max before the formula but it still "overflow". I don't even know if the correct name is overflow
  6. Hey all! Greetings, Recently I've been trying to avoid the MATK infamous overflow when it reaches the maximum, but no success at all. I tried protecting the values from getting bigger than SHRT_MAX (32727) but still nothing changed I tried poking aroud in the status.cpp, and found that when it executes this piece of code at line 5239 if (bl->type&BL_PC && sd->matk_rate != 100) { status->matk_max = status->matk_max * sd->matk_rate/100; status->matk_min = status->matk_min * sd->matk_rate/100; } And the matk_max is greater than 30097, the result is 87 (I'm not 100% sure about these values, but they're approximated) I've also tried changing the matk_min and matk_max to int, but I'm not sure if I did it right.. This is what I mean by "overflow" (the values just go negative) Thank you!
  7. Dude, this saved me! Is this code yours? I'd like to thank the owner if not. Thank you, again!
  8. Hi! i got it working by using another NEMO version.. Thank you anyways! I've used the one anacondaqq links on a tutorial in hercules
  9. Hi! I was using the 2014.10.22bRagexe together with a data from brAthena and was able to connect normally. After upgrading the client to 2018-06-21aRagexeRE I'm not able to connect anymore, I've updated the data to RoenglishRE together with its System folder and kRO dlls and stuff. The server version is the most recent from rAthena git. This is my client folder with everything inside, including my data and patched client Everything opens normally but after typing any password I just get the message "Disconnected from server" and there's nothing on the login-server logs, which got me thinking it could be somewhat related to the clientinfo.xml, so I've diffed (using NEMO) the option to select a custom clientinfo.xml and put the sclientinfo.xml. I'm not able to select Always Call SelectKoreaClientInfo() which checking the nemo wiki, I can see that my client won't support it. So I have nowhere to go now... I'm using this sclientinfo.xml <?xml version="1.0" encoding="euc-kr" ?> <clientinfo> <desc>Ragnarok Client Information</desc> <servicetype>korea</servicetype> <servertype>primary</servertype> <connection> <display>Local</display> <address>127.0.0.1</address> <port>6900</port> <version>55</version> <langtype>1</langtype> <registrationweb>www.ragnarok.com</registrationweb> <loading> <image>loading00.jpg</image> <image>loading01.jpg</image> <image>loading02.jpg</image> <image>loading03.jpg</image> <image>loading04.jpg</image> <image>loading05.jpg</image> <image>loading06.jpg</image> </loading> </connection> </clientinfo> I might be wrong but does the absence of a <aid> makes no difference unless I specify on NEMO to ignore GM clothes? PS: I can see the sclientinfo.xml file is being read by the client because if I change the <servertype> to Sakray or the <langtype> to anything but 0/1 the client won't open with a bunch of errors. Thanks!
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use and Privacy Policy.