Jump to content
  • 0

How can i restrict autotrade players from getting reward?

Nero

Asked by Nero,

 Share

Question

Nero Poring

Nero

Posted
  • Group:  Members
  • Topic Count:  74
  • Topics Per Day:  0.02
  • Content Count:  194
  • Reputation:   2
  • Joined:  12/18/11
  • Last Seen:  
Posted

How can i restrict them from getting reward in this script: 

-	script	guild_vs1s2	-1,{

	OnAgitEnd:
		callsub( L_reward,0, "guild_vs1" );
		end;
		
	OnAgitEnd2:
		callsub( L_reward,1, "guild_vs1" );
		end;
	
	L_reward:
		.@type = getarg( 0,0 );
		.@map$ = getarg( 1,"" );
		
		if ( .@type == 0) {	// woe fe
			setarray .@item_master,
				30206,2;
			setarray .@item_member,
				30206,1;
		}
		else {	// woe se
			setarray .@item_master,
				30206,2;
			setarray .@item_member,
				30206,1;
		}
		.@item_master_size = getarraysize( .@item_master ) - 1;
		.@item_member_size = getarraysize( .@item_member ) - 1;
		
		if ( .@map$ != "" ) {
			.@gid = getcastledata( .@map$,1 );
			if ( .@gid > 0 ) {
				getguildmember .@gid,1;
				getguildmember .@gid,2;
				.@master_id = getcharid( 3, getguildmaster( .@gid ) );
				while ( .@i < $@guildmembercount ) {
					.@x = 0;
					if ( isloggedin( $@guildmemberaid[.@i],$@guildmembercid[.@i] ) ) {
						if ( $@guildmemberaid[.@i] == .@master_id ) {
							while ( .@x < .@item_master_size ) {
								getitem .@item_master[.@x],.@item_master[.@x+1],$@guildmemberaid[.@i];
								.@x += 2;
							}
						}
						else {
							while ( .@x < .@item_member_size ) {
								getitem .@item_member[.@x],.@item_member[.@x+1],$@guildmemberaid[.@i];
								.@x += 2;
							}
						}
					}
					.@i++;
				}
			}
		}
		return;
}

Where to put this one  if(    ( checkvending() == 2 && !.autotrade ) ?

 

Link to comment
Share on other sites

11 answers to this question

Recommended Posts

  • 0
Keitenai Marin

Keitenai

Posted
  • Group:  Members
  • Topic Count:  18
  • Topics Per Day:  0.00
  • Content Count:  98
  • Reputation:   75
  • Joined:  12/04/14
  • Last Seen:  
Posted (edited)


  

while ( .@x < .@item_master_size ) {

if ( CheckVending() ) end; 

	getitem .@item_master[.@x],.@item_master[.@x+1],$@guildmemberaid[.@i];
			.@x += 2;
}

 

Edited by Keitenai
  • Upvote 1
Link to comment
Share on other sites
  • 0
Nero Poring

Nero

Posted
  • Group:  Members
  • Topic Count:  74
  • Topics Per Day:  0.02
  • Content Count:  194
  • Reputation:   2
  • Joined:  12/18/11
  • Last Seen:  
  • Author
Posted

Wow thanks!!! Fast answer!

Link to comment
Share on other sites
  • 0
Keitenai Marin

Keitenai

Posted
  • Group:  Members
  • Topic Count:  18
  • Topics Per Day:  0.00
  • Content Count:  98
  • Reputation:   75
  • Joined:  12/04/14
  • Last Seen:  
Posted
1 minute ago, Nero said:

Wow thanks!!! Fast answer!

you need to do thesame with members

if ( CheckVending() ) end; 

getitem .@item_member[.@x],.@item_member[.@x+1],$@guildmemberaid[.@i];

 

  • Upvote 1
Link to comment
Share on other sites
  • 0
Nero Poring

Nero

Posted
  • Group:  Members
  • Topic Count:  74
  • Topics Per Day:  0.02
  • Content Count:  194
  • Reputation:   2
  • Joined:  12/18/11
  • Last Seen:  
  • Author
Posted (edited)

Hmm i got some problem. No error on script but members doesnt receive the reward. even if the player is not in vend/autotrade

Edited by Nero
Link to comment
Share on other sites
  • 0
hendra814 Ghostring

hendra814

Posted
  • Group:  Members
  • Topic Count:  59
  • Topics Per Day:  0.01
  • Content Count:  1281
  • Reputation:   170
  • Joined:  06/12/12
  • Last Seen:  
Posted
3 hours ago, Nero said:

Hmm i got some problem. No error on script but members doesnt receive the reward. even if the player is not in vend/autotrade

try like this 

while ( .@x < .@item_master_size ) {
if ( CheckVending() ){
    end;
    }
	getitem .@item_master[.@x],.@item_master[.@x+1],$@guildmemberaid[.@i];
			.@x += 2;
}

 

Link to comment
Share on other sites
  • 0
Nero Poring

Nero

Posted
  • Group:  Members
  • Topic Count:  74
  • Topics Per Day:  0.02
  • Content Count:  194
  • Reputation:   2
  • Joined:  12/18/11
  • Last Seen:  
  • Author
Posted
1 hour ago, hendra814 said:

try like this 


while ( .@x < .@item_master_size ) {
if ( CheckVending() ){
    end;
    }
	getitem .@item_master[.@x],.@item_master[.@x+1],$@guildmemberaid[.@i];
			.@x += 2;
}

  

-	script	guild_vs1s2	-1,{

	OnAgitEnd:
		callsub( L_reward,0, "guild_vs1" );
		end;
		
	OnAgitEnd2:
		callsub( L_reward,1, "guild_vs1" );
		end;
	
	L_reward:
		.@type = getarg( 0,0 );
		.@map$ = getarg( 1,"" );
		
		if ( .@type == 0) {	// woe fe
			setarray .@item_master,
				30206,2;
			setarray .@item_member,
				30206,1;
		}
		else {	// woe se
			setarray .@item_master,
				30206,2;
			setarray .@item_member,
				30206,1;
		}
		.@item_master_size = getarraysize( .@item_master ) - 1;
		.@item_member_size = getarraysize( .@item_member ) - 1;
		
		if ( .@map$ != "" ) {
			.@gid = getcastledata( .@map$,1 );
			if ( .@gid > 0 ) {
				getguildmember .@gid,1;
				getguildmember .@gid,2;
				.@master_id = getcharid( 3, getguildmaster( .@gid ) );
				while ( .@i < $@guildmembercount ) {
					.@x = 0;
					if ( isloggedin( $@guildmemberaid[.@i],$@guildmembercid[.@i] ) ) {
						if ( $@guildmemberaid[.@i] == .@master_id ) {
							while ( .@x < .@item_master_size ) {
								getitem .@item_master[.@x],.@item_master[.@x+1],$@guildmemberaid[.@i];
								.@x += 2;
							}
						}
						else {
							while ( .@x < .@item_member_size ) {
								if ( CheckVending() ){
									end;
									}
								getitem .@item_member[.@x],.@item_member[.@x+1],$@guildmemberaid[.@i];
								.@x += 2;
								
							}
						}
					}
					.@i++;
				}
			}
		}
		return;
}

Still not getting anything. 

Link to comment
Share on other sites
  • 0
Keitenai Marin

Keitenai

Posted
  • Group:  Members
  • Topic Count:  18
  • Topics Per Day:  0.00
  • Content Count:  98
  • Reputation:   75
  • Joined:  12/04/14
  • Last Seen:  
Posted (edited)

try this @Nero: 

-	script	guild_vs1s2	-1,{

	OnAgitEnd:
		callsub( L_reward,0, "guild_vs1" );
		end;
		
	OnAgitEnd2:
		callsub( L_reward,1, "guild_vs1" );
		end;
	
	L_reward:
		.@type = getarg( 0,0 );
		.@map$ = getarg( 1,"" );
		
		if ( .@type == 0) {	// woe fe
			setarray .@item_master,
				30206,2;
			setarray .@item_member,
				30206,1;
		}
		else {	// woe se
			setarray .@item_master,
				30206,2;
			setarray .@item_member,
				30206,1;
		}
		.@item_master_size = getarraysize( .@item_master ) - 1;
		.@item_member_size = getarraysize( .@item_member ) - 1;
		
		if ( .@map$ != "" ) {
			.@gid = getcastledata( .@map$,1 );
			if ( .@gid > 0 ) {
				getguildmember .@gid,1;
				getguildmember .@gid,2;
				.@master_id = getcharid( 3, getguildmaster( .@gid ) );
				while ( .@i < $@guildmembercount ) {
					.@x = 0;
					if ( isloggedin( $@guildmemberaid[.@i],$@guildmembercid[.@i] ) ) {
						if ( $@guildmemberaid[.@i] == .@master_id ) {
							while ( .@x < .@item_master_size ) {
								if(!checkvending(strcharinfo(0,$@guildmembercid[.@i])))
									getitem .@item_master[.@x],.@item_master[.@x+1],$@guildmemberaid[.@i];
								.@x += 2;
							}
						}
						else {
							while ( .@x < .@item_member_size ) {
								if(!checkvending(strcharinfo(0,$@guildmembercid[.@i])))
									getitem .@item_member[.@x],.@item_member[.@x+1],$@guildmemberaid[.@i];
								.@x += 2;
							}
						}
					}
					.@i++;
				}
			}
		}
		return;
}

 

 

Edited by Keitenai
Link to comment
Share on other sites
  • 0
Nero Poring

Nero

Posted
  • Group:  Members
  • Topic Count:  74
  • Topics Per Day:  0.02
  • Content Count:  194
  • Reputation:   2
  • Joined:  12/18/11
  • Last Seen:  
  • Author
Posted
On 3/2/2018 at 7:44 PM, Keitenai said:

try this @Nero: 


-	script	guild_vs1s2	-1,{

	OnAgitEnd:
		callsub( L_reward,0, "guild_vs1" );
		end;
		
	OnAgitEnd2:
		callsub( L_reward,1, "guild_vs1" );
		end;
	
	L_reward:
		.@type = getarg( 0,0 );
		.@map$ = getarg( 1,"" );
		
		if ( .@type == 0) {	// woe fe
			setarray .@item_master,
				30206,2;
			setarray .@item_member,
				30206,1;
		}
		else {	// woe se
			setarray .@item_master,
				30206,2;
			setarray .@item_member,
				30206,1;
		}
		.@item_master_size = getarraysize( .@item_master ) - 1;
		.@item_member_size = getarraysize( .@item_member ) - 1;
		
		if ( .@map$ != "" ) {
			.@gid = getcastledata( .@map$,1 );
			if ( .@gid > 0 ) {
				getguildmember .@gid,1;
				getguildmember .@gid,2;
				.@master_id = getcharid( 3, getguildmaster( .@gid ) );
				while ( .@i < $@guildmembercount ) {
					.@x = 0;
					if ( isloggedin( $@guildmemberaid[.@i],$@guildmembercid[.@i] ) ) {
						if ( $@guildmemberaid[.@i] == .@master_id ) {
							while ( .@x < .@item_master_size ) {
								if(!checkvending(strcharinfo(0,$@guildmembercid[.@i])))
									getitem .@item_master[.@x],.@item_master[.@x+1],$@guildmemberaid[.@i];
								.@x += 2;
							}
						}
						else {
							while ( .@x < .@item_member_size ) {
								if(!checkvending(strcharinfo(0,$@guildmembercid[.@i])))
									getitem .@item_member[.@x],.@item_member[.@x+1],$@guildmemberaid[.@i];
								.@x += 2;
							}
						}
					}
					.@i++;
				}
			}
		}
		return;
}

 

 

Im having error in this one  

[Error]: script error in file 'npc/rage/koe.txt' line 158 column 39
    parse_callfunc: expected ')' to close argument list
   155:                                         if ( isloggedin( $@guildmemberaid[.@i],$@guildmembercid[.@i] ) ) {
   156:                                                 if ( $@guildmemberaid[.@i] == .@master_id ) {
   157:                                                         while ( .@x < .@item_master_size ) {
*  158:                                                                 if(!checkvending(strcharinfo(0,$@guildmembercid[.@i])))
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
   159:                                                                         getitem .@item_master[.@x],.@item_master[.@x+1],$@guildmemberaid[.@i];
   160:                                                                 .@x += 2;
   161:                                                         }

 if(!checkvending(strcharinfo(0,$@guildmembercid

Link to comment
Share on other sites
  • 0
Nero Poring

Nero

Posted
  • Group:  Members
  • Topic Count:  74
  • Topics Per Day:  0.02
  • Content Count:  194
  • Reputation:   2
  • Joined:  12/18/11
  • Last Seen:  
  • Author
Posted

up please help

 

Nid help everyone :(

Link to comment
Share on other sites
  • 0
Keitenai Marin

Keitenai

Posted
  • Group:  Members
  • Topic Count:  18
  • Topics Per Day:  0.00
  • Content Count:  98
  • Reputation:   75
  • Joined:  12/04/14
  • Last Seen:  
Posted (edited)
1 hour ago, Nero said:

Nid help everyone :(

Check your whole script.

i'm not getting your error upon testing.

 

Try making a separate txt file for the "guild_vs1s2" script so that you can trace where exactly is your missing ")"

Edited by Keitenai
Link to comment
Share on other sites
  • 0
Emistry Deviling

Emistry

Posted
  • Group:  Forum Moderator
  • Topic Count:  93
  • Topics Per Day:  0.02
  • Content Count:  10018
  • Reputation:   2369
  • Joined:  10/28/11
  • Last Seen:  
Posted

in Herc it use 3 parameters

https://github.com/HerculesWS/Hercules/blob/stable/doc/script_commands.txt#L2376-L2384 

*strcharinfo(<type>{, <default value>{, <GID>}})

This function will return either the name, party name or guild name for
the invoking character. Whatever it returns is determined by type.
(0) PC_NAME		- Character's name.
(1) PC_PARTY	- The name of the party they're in if any.
(2) PC_GUILD	- The name of the guild they're in if any.
(3) PC_MAP		- The name of the map the character is in.
(4) PC_CLAN   - The name of the clan they're in if any.

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to question listing
×
×
  • Create New...