Setting packetver in the newest rA revision.

[Eisetley]

When you open packets.h it says

Quote

/// Do NOT edit this line! To set your client version, please do this instead:
    /// In Windows: Add this line in your src\custom\defines_pre.h file: #define PACKETVER YYYYMMDD

I go to defines_pre.h and do it. It looks like this:

// Copyright (c) rAthena Dev Teams - Licensed under GNU GPL
// For more information, see LICENCE in the main folder
#ifndef _CONFIG_CUSTOM_DEFINES_PRE_H_
#define _CONFIG_CUSTOM_DEFINES_PRE_H_
//#define PACKETVER 20120410
/**
 * rAthena configuration file (http://rathena.org)
 * For detailed guidance on these check http://rathena.org/wiki/SRC/config/
 **/

#define PACKETVER 20120410

#endif // _CONFIG_CUSTOM_DEFINES_PRE_H_

I get a bunch of errors when trying to compile (attachment). When I paste #define PACKETVER 20151104 into defines_pre.h (the one that's in packets.h by default) it compiles fine.

Also, should I change packet version somewhere else, like clientinfo.xml? I'm using 2012-04-10aRagexeRE.

[crazyarashi]

to edit the packet version 

	/// Do NOT edit this line! To set your client version, please do this instead:
	/// In Windows: Add this line in your src\custom\defines_pre.h file: #define PACKETVER YYYYMMDD
	/// In Linux: The same as above or run the following command: ./configure --enable-packetver=YYYYMMDD
	#define PACKETVER 20170614 //packet version here

and your error is coming from battle.cpp :))

[Eisetley]

I can compile with #define PACKETVER 20170614, when I change it to 20120410 it gives me this battle.cpp error.

#if PACKETVER > 20120000 && PACKETVER < 20130515 /* Exact date (when it started) not known */
	if (battle_config.feature_auction) {
		ShowWarning("conf/battle/feature.conf:feature.auction is enabled but it is not stable on PACKETVER "EXPAND_AND_QUOTE(PACKETVER)", disabling...\n");
		ShowWarning("conf/battle/feature.conf:feature.auction change value to '2' to silence this warning and maintain it enabled\n");
		battle_config.feature_auction = 0;
	}

That's the part that gives an error.

Edited December 29, 2017 by Eisetley

[sader1992]

it's from rathena

if you want a fix fast just do this

comment this like 

ShowWarning("conf/battle/feature.conf:feature.auction is enabled but it is not stable on PACKETVER "EXPAND_AND_QUOTE(PACKETVER)", disabling...\n");

in battle.cpp line 8583

so this

#if PACKETVER > 20120000 && PACKETVER < 20130515 /* Exact date (when it started) not known */
	if (battle_config.feature_auction) {
		ShowWarning("conf/battle/feature.conf:feature.auction is enabled but it is not stable on PACKETVER "EXPAND_AND_QUOTE(PACKETVER)", disabling...\n");
		ShowWarning("conf/battle/feature.conf:feature.auction change value to '2' to silence this warning and maintain it enabled\n");
		battle_config.feature_auction = 0;
	}

will became like this

#if PACKETVER > 20120000 && PACKETVER < 20130515 /* Exact date (when it started) not known */
	if (battle_config.feature_auction) {
		//ShowWarning("conf/battle/feature.conf:feature.auction is enabled but it is not stable on PACKETVER "EXPAND_AND_QUOTE(PACKETVER)", disabling...\n");
		ShowWarning("conf/battle/feature.conf:feature.auction change value to '2' to silence this warning and maintain it enabled\n");
		battle_config.feature_auction = 0;
	}

 

if you are not in harry you can wait for rathena to fix it

 

https://github.com/rathena/rathena/pull/2743

Edited December 29, 2017 by sader1992
Adding PR link

[Eisetley]

Thanks, Megumin. I hope your panties are ok.

How about clientinfo.xml and packet_db.txt? How should they look for this client version? I can't find packet_db inside rA folder by the way.

Edited December 29, 2017 by Eisetley

[chowking]

On 12/29/2017 at 11:15 PM, Eisetley said:

I can't find packet_db inside rA folder by the way.

packet_db.txt was removed it will now work if you've configured packets and recompiled its good
clientinfo.xml is the same as always