MVP announcer

[Antares]

Hello,

 

I have found some similar topics, and I managed to get this working:

-	script	MVPAnnouncer	-1,{
OnNPCKillEvent: 
	if ( getmonsterinfo(killedrid,MOB_MVPEXP) )
		announce strcharinfo(0)+" has defeated "+getmonsterinfo(killedrid,0)+" at "+strcharinfo(3),0,0xFF0101;
	end;
}

The problem with this script is that it announces @clones with "null" name, and another problem that it is not announcing NPC spawned mvps, like Lord of Death, Thanatos, Nydhogg's Shadow.

 

Additionally, I want to extend the script, to only display kills below gmlvl 99, but I think I got this part. So how do I modify the script to counter the above problems?

 

My script currently:

-	script	MVPAnnouncer	-1,{
OnNPCKillEvent: 
	if ( getmonsterinfo(killedrid,MOB_MVPEXP) && (getgmlevel() < 99) )
		announce strcharinfo(0)+" has defeated "+getmonsterinfo(killedrid,0)+" at "+strcharinfo(3),0,0xFF0101;
	end;
}

Another question: What are the default OnEvents? I was thinking about using OnMobKill, but I'm not sure if it's a default event... I'm also unsure if it's wise to run a ckeck on every mobkill... isn't there any other option to announce MVP kills (npc and player spawned ones as well)?

[Emistry]

default event label for mob ??

OnNPCKillEvent:

why it doesnt announce for Lord Of Death / Thanatos / Instances monster ??

Because these monster have their own npc with own npc label.

each monster can only have 1 event label.

 

any monster that doesnt have any event label will trigger the OnNPCKillEvent label.

[Antares]

So what is the solution? How to announce every mvp? The client always gets the info from the server who is the mvp. Does it have any event or can we use that somehow?

[Emistry]

add the announce part to every single script that related to mvp ...instances ... LOD...Bio lab MVP..

[Antares]

What if I collect all the labels of the script mvps? Are those labels global? Can I process them from my own script?

 

What I mean:

OnNPCKillEvent:
OnMyMobDead:
OnLoDDead:
On.....
.....
.....
.....
....
....
....
	<if MVP then announce the kill>

[Emistry]

no .... you have to search for each npc label then add the announce part.

[Capuche]

Another way should be to call both label when you kill a mob

https://github.com/rathena/rathena/blob/master/src/map/mob.c#L2672