Broken: How reduce is applied in rAthena

[Yuka]

The way rAthena applies the reduces seems to be broken.

I have found out that the formulas are like the iRo damage formulas, but the reduce is applied in a total value, not step by step.

So instead of applying demi-human reduce THEN property reduce THEN long-range reduce, it applys (demi-human reduce + property reduce + long-range reduce) all at once.

 

So for example Acid Demonstration will miss on 45% Long Range Reduce, 27% neutral reduce and 29% demi-human reduce. (45+27+29 = 101)

Instead the reduces should be applied step by step:

1k AD = 1k*0.65*0.73*0.71 = 336

Bump.

Bump. D:

Edited June 12, 2014 by Yuka

[Yuka]

Okay, I have fixed it.

It is fixed in all rAthena versions newer than 13th March 2014. (but Harmony won't work on the latest rAthena version. )

So what I did is applying the commits manually: https://github.com/rathena/rathena/commit/165609d487f2ca82655c27c166ea16110fe2017d

Note that there are two follow ups...

Edited June 15, 2014 by Yuka

[Winz]

try to check the calculations on ratemyserver.net. make sure you are taking the renewal (if your server is renewal) or pre-re (otherwise). as I know, rAthena and official kRO server has the same calculations

[Winz]

...

 

I should have asked you, "Are you using the latest GIT for the rAthena?"