Upgrade Weapon Skill Announcement Request

[nasagnilac]

/// Presents a list of weapon items that can be refined [Taken from jAthena] (ZC_NOTIFY_WEAPONITEMLIST).
/// 0221 <packet len>.W { <index>.W <name id>.W <refine>.B <card1>.W <card2>.W <card3>.W <card4>.W }*
void clif_item_refine_list(struct map_session_data *sd)
{
	int i,c;
	int fd;
	uint16 skill_lv;
	int wlv;
	int refine_item[5];

	nullpo_retv(sd);

	skill_lv = pc_checkskill(sd,WS_WEAPONREFINE);

	fd=sd->fd;

	refine_item[0] = -1;
	refine_item[1] = pc_search_inventory(sd,1010);
	refine_item[2] = pc_search_inventory(sd,1011);
	refine_item[3] = refine_item[4] = pc_search_inventory(sd,984);

	WFIFOHEAD(fd, MAX_INVENTORY * 13 + 4);
	WFIFOW(fd,0)=0x221;
	for(i=c=0;i<MAX_INVENTORY;i++){
		if(sd->status.inventory[i].nameid > 0 && sd->status.inventory[i].refine < skill_lv &&
			sd->status.inventory[i].identify && (wlv=itemdb_wlv(sd->status.inventory[i].nameid)) >=1 &&
			refine_item[wlv]!=-1 && !(sd->status.inventory[i].equip&EQP_ARMS)){
			WFIFOW(fd,c*13+ 4)=i+2;
			WFIFOW(fd,c*13+ 6)=sd->status.inventory[i].nameid;
			WFIFOB(fd,c*13+ 8)=sd->status.inventory[i].refine;
			clif_addcards(WFIFOP(fd,c*13+9), &sd->status.inventory[i]);
			c++;
		}
	}
	WFIFOW(fd,2)=c*13+4;
	WFIFOSET(fd,WFIFOW(fd,2));
	if (c > 0) {
		sd->menuskill_id = WS_WEAPONREFINE;
		sd->menuskill_val = skill_lv;
	}
}

Hello I found this in src/map/clif.c and my suggestion is I want to add an announcement when a whitesmith refined a weapon to +7 or higher. The example message will be "Citizens of Midgard,Lady Luck shines upon [super Whitesmith]!! He/She successfully refined [ Blade [4] ] to +7.".

 

"He/She" on this part of the announcement message .

If the char is a male the message will be "He successfully refined [ Blade [4] ] to +7"

If the char is a female the message will be "She successfully refined [ Blade [4] ] to +7"

Edited May 16, 2014 by gmprestige

[sandbox]

https://github.com/rathena/rathena/blob/master/npc/merchants/refine.txt#L749

https://github.com/rathena/rathena/blob/master/npc/merchants/refine.txt#L858

 

Add below

announce "Citizens of Midgard, Lady Luck shines upon ["+strcharinfo(0)+"]!!! "+(Sex?"He":"She")+" successfully refined ["+getequipname(.@part)+"] to +"+getequiprefinerycnt(.@part)+".",bc_all;

 

Nvm, you were talking about the skill =/

[nasagnilac]

yup