sandbox Posted March 13, 2014 Group: Members Topic Count: 38 Topics Per Day: 0.01 Content Count: 949 Reputation: 174 Joined: 06/12/12 Last Seen: April 29 Share Posted March 13, 2014 Since the start(I think) we have those dummy name values after every entry in skill_require_db. But it seems that the skills starting 1st Class up to the Transcendent classes have its dummy skill name values into japanese instead of english. 5,0,0,8:8:8:8:8:15:15:15:15:15,0,0,0,0:1:2:3:4:5:6:7:8:9:10:12:13:14:15:16:17:18:19:20:21:22,0,0,none,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 //SM_BASH#バッシュ# ... 3029,0,0,20:30:40:50:60,0,0,0,99,0,0,none,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 //OB_AKAITSUKI#Akaitsuki# Moving to the main point, should we translate it into english, or should we remove them? Since they're merely used for reference, and we already have its skill name. So I think there is no point on using skill_require_db.txt to refer for its japanese/english names. Not to mention that they're already in skill_db, which should be the main reference for skill information. 5,0,0,8:8:8:8:8:15:15:15:15:15,0,0,0,0:1:2:3:4:5:6:7:8:9:10:12:13:14:15:16:17:18:19:20:21:22,0,0,none,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 //SM_BASH#Bash# or 5,0,0,8:8:8:8:8:15:15:15:15:15,0,0,0,0:1:2:3:4:5:6:7:8:9:10:12:13:14:15:16:17:18:19:20:21:22,0,0,none,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0 //SM_BASH I'm willing to do it, if this gets approved by the devs. 3 Link to comment Share on other sites More sharing options...
Pneuma Posted March 13, 2014 Group: Members Topic Count: 82 Topics Per Day: 0.02 Content Count: 846 Reputation: 138 Joined: 02/26/14 Last Seen: March 7, 2018 Share Posted March 13, 2014 I say simply remove it since the //SKILL is already there Link to comment Share on other sites More sharing options...
Cydh Posted March 13, 2014 Group: Developer Topic Count: 153 Topics Per Day: 0.03 Content Count: 2285 Reputation: 748 Joined: 06/16/12 Last Seen: February 21 Share Posted March 13, 2014 just make it .... //AEGIS_NAME those dummies because simply copy-paste from skill_db.txt. It makes easy to find. (for people like me who lazy to open skill_db.txt to find skill ID then open skill_require_db.txt to find the skill requirements) Link to comment Share on other sites More sharing options...
sandbox Posted March 13, 2014 Group: Members Topic Count: 38 Topics Per Day: 0.01 Content Count: 949 Reputation: 174 Joined: 06/12/12 Last Seen: April 29 Author Share Posted March 13, 2014 So is it granted? I'll make a PR for you. Link to comment Share on other sites More sharing options...
Cydh Posted March 13, 2014 Group: Developer Topic Count: 153 Topics Per Day: 0.03 Content Count: 2285 Reputation: 748 Joined: 06/16/12 Last Seen: February 21 Share Posted March 13, 2014 because those comments just like leftovers and just make that file messy for me. xD if you want, go ahead. Link to comment Share on other sites More sharing options...
sandbox Posted March 13, 2014 Group: Members Topic Count: 38 Topics Per Day: 0.01 Content Count: 949 Reputation: 174 Joined: 06/12/12 Last Seen: April 29 Author Share Posted March 13, 2014 Sure thing, i'll do it tomorrow morning Link to comment Share on other sites More sharing options...
Recommended Posts