Peopleperson49 Posted December 28, 2013 Group: Members Topic Count: 219 Topics Per Day: 0.05 Content Count: 1181 Reputation: 141 Joined: 01/27/12 Last Seen: April 15 Share Posted December 28, 2013 Request that Emistry's rentitem2 be added to the svn. It works just like getitem2 but for rental items and is a great supplement to the rentitem script command. Peopleperson49 http://rathena.org/board/topic/59677-rentitem2/?hl=rentitem 1 Link to comment Share on other sites More sharing options...
GmOcean Posted December 31, 2013 Group: Members Topic Count: 31 Topics Per Day: 0.01 Content Count: 666 Reputation: 93 Joined: 04/27/12 Last Seen: August 17, 2015 Share Posted December 31, 2013 I don't see why not. It would seem like this would be a long over due addition to rA. Also, since the work has been done for us, surely there can't be a real big reason as to why we don't add it. +1 for this. Link to comment Share on other sites More sharing options...
Cydh Posted January 1, 2014 Group: Developer Topic Count: 153 Topics Per Day: 0.03 Content Count: 2285 Reputation: 748 Joined: 06/16/12 Last Seen: February 21 Share Posted January 1, 2014 if someone make the pull request for it, I'll merge it. I approve this suggestion. Link to comment Share on other sites More sharing options...
Euphy Posted January 1, 2014 Group: Members Topic Count: 72 Topics Per Day: 0.02 Content Count: 2997 Reputation: 1132 Joined: 05/27/12 Last Seen: June 1, 2017 Share Posted January 1, 2014 if someone make the pull request for it, I'll merge it.What he said! In general, if you want to add a feature that already exists, making a pull request will greatly increase the chances of us adding it (as well as speeding up the process). Link to comment Share on other sites More sharing options...
Peopleperson49 Posted January 1, 2014 Group: Members Topic Count: 219 Topics Per Day: 0.05 Content Count: 1181 Reputation: 141 Joined: 01/27/12 Last Seen: April 15 Author Share Posted January 1, 2014 I'm not sure what a pull request is. Peopleperson49 Link to comment Share on other sites More sharing options...
Euphy Posted January 1, 2014 Group: Members Topic Count: 72 Topics Per Day: 0.02 Content Count: 2997 Reputation: 1132 Joined: 05/27/12 Last Seen: June 1, 2017 Share Posted January 1, 2014 I'm not sure what a pull request is.See the Pull Request Q&A. Link to comment Share on other sites More sharing options...
Brian Posted January 13, 2014 Group: Members Topic Count: 75 Topics Per Day: 0.02 Content Count: 2223 Reputation: 593 Joined: 10/26/11 Last Seen: June 2, 2018 Share Posted January 13, 2014 I'll do it! haha I remember at the time I didn't think this would be useful ... but I guess it is! hello...i meet some problem in make a rental item....can u teach me? i wan to make a +10 formal suit for 30days with a ghostring card...how to do that? Currently there is only a 'rentitem' script command. You would need 'rentitem2' (similar to getitem2) to specify refine rate and cards. or maybe you could use 'rentitem', then @kick them and modify the item in SQL... 1 Link to comment Share on other sites More sharing options...
AnnieRuru Posted January 13, 2014 Group: Members Topic Count: 18 Topics Per Day: 0.00 Content Count: 2044 Reputation: 682 Joined: 10/09/12 Last Seen: December 20, 2020 Share Posted January 13, 2014 Brian *makeitem2 command too I want to make a script where a signed item is dropped on the floor http://rathena.org/board/topic/73454-how-to-do-skull-will-be-auto-loot-on-pvp/?p=152141 1 Link to comment Share on other sites More sharing options...
Cydh Posted February 8, 2014 Group: Developer Topic Count: 153 Topics Per Day: 0.03 Content Count: 2285 Reputation: 748 Joined: 06/16/12 Last Seen: February 21 Share Posted February 8, 2014 Implemented rentitem2 and makeitem2, 339c0a8 Link to comment Share on other sites More sharing options...
Recommended Posts