player variable +1

[Vincent]

Hi,

i try to make a script where a player var get every time +1. For some reason it dont work. Here is my script:

payon,111,110,5	script	Crazy Man	757,{

set player_point, player_point==0;

OnHit:
if (player_point==5)						
{ getitem 999,1;							 
}
else{
set player_point, player_point++;
mes ""+player_point+"";
goto L_change;
}
L_change:

mes "....";
end;

												}

 

[Ryokem]

..in C not in script npc, and it's about script npc here

My bad about that then, but Kenpachi said it correctly:

 

 

In that case *Athena has a bug. ^^

BTW; That's not just in C but in every other language I know.

These are standards which everybody should follow them.

[Emistry]

player_point++;
if( player_point == 5 ){
    getitem 999,1;
    mes "Get item.";
}else{
    mes ""+player_point;
}
close;

like this ?

[Vincent]

Also dont work. Still the message say "1". points dont count higher....

[Kenpachi]

Just for clarification:

set player_point, player_point++;

 

You try to set the veriable player_point to the result of player_point++. The result is, that player_point still holds the same value. Why?

The result of an i++ operation wont change until the operation was finally executed while ++i knows the result while executing the operation.
I'm bad in explaining. Maybe this explains it better: http://stackoverflow.com/questions/24853/what-is-the-difference-between-i-and-i

 

Try this:

OnHit:
if (player_point==5)						
    getitem 999,1;
else
{
    player_point++; // set player_point, player_point + 1; would do the same
    mes ""+player_point+"";
    goto L_change;
}

 

 

[Vincent]

Also dont work. Maybe the varianle is set every time to "0" because of this:

 

payon,111,110,5	script	Crazy Man	757,{

set player_point, player_point==0;

[Kenpachi]

Yes, every time the player clicks on the NPC.

 

EDIT: Actually it's not always 0. It can be 1 if player_point equals 0. That's because player_point will have the value of the result of that comparison (player_point==0):

[Vincent]

Yes, every time the player clicks on the NPC.

 

EDIT: Actually it's not always 0. It can be 1 if player_point equals 0. That's because player_point will have the value of the result of that comparison (player_point==0):

And how can i fix it because if have to initialize the var befor i can use it or not?

[Kenpachi]

No, in *Athena you don't have to declare/initialize variables, just use them. If you try to access a non-existing variable 0 (or an empty string) will be returned.

[Capuche]

You try to set the veriable player_point to the result of player_point++. The result is, that player_point still holds the same value.

You mean the variable player_point stay the same ?

player_point -> 0

set player_point, player_point++; -> 0 ?

Coz that's not true

 

prontera,155,181,5	script	test	100,{
	set @player_point, @player_point++;
	dispbottom "Click number "+ @player_point;
	end;
}

[Ryokem]

You try to set the veriable player_point to the result of player_point++. The result is, that player_point still holds the same value.

You mean the variable player_point stay the same ?

player_point -> 0

set player_point, player_point++; -> 0 ?

Coz that's not true

 

Actually, he is correct speaking about the instance scope.

But you are correct as well, because the variable check is located in another scope.

 

a = 1;
b = a++;
//b stores 1, not 2.
 
a = 1;
b = ++a;
//b stores 2

That's what Kenpachi means. During the execution command, a "var++" command is executed after the scope of the command it is located. Practically, as it is the same variable you are using, it makes no difference but to set an unneeded command; otherwise, if you work with more than 1 variable, it may land out in weird errors.

set a, a++;
//Is equal to:
set a, a;
a++;

 

 

 

Hi,

i try to make a script where a player var get every time +1. For some reason it dont work. Here is my script:

payon,111,110,5	script	Crazy Man	757,{

set player_point, player_point==0;

OnHit:
if (player_point==5)						
{ getitem 999,1;							 
}
else{
set player_point, player_point++;
mes ""+player_point+"";
goto L_change;
}
L_change:

mes "....";
end;

												}

It's really long I don't script for Ragnarok Online, so I don't really know if OnHit actually is a viable On-label event or not, what it does or if you recall it through a onevent command.

Just remember that each time you click on the NPC, you get your variable resetted. So, to trigger the getitem thing, you need to activate the "OnHit" label 5 times without clicking on the NPC.

Also, the L_change label is pretty much useless 'cause you jump in there in any case.

 

payon,111,110,5    script    Crazy Man    757,{

set player_point, player_point==0; //I don't know if you need a reset here... but well...

OnHit:
    player_point++;
    if( player_point == 5 )                        
        getitem 999,1;                             
    dispbottom "...";
    end;
}

[Capuche]

That's what Kenpachi means. During the execution command, a "var++" command is executed after the scope of the command it is located.

..in C not in script npc, and it's about script npc here

prontera,150,182,5	script	jiknju	56,{
	.@b = 1;
	.@a = .@b++;// set b before a
	dispbottom .@a +": is a";
	dispbottom .@b +": is b";
	end;
}

[Kenpachi]

You try to set the veriable player_point to the result of player_point++. The result is, that player_point still holds the same value.

You mean the variable player_point stay the same ?

player_point -> 0

set player_point, player_point++; -> 0 ?

Coz that's not true

 

prontera,155,181,5	script	test	100,{
	set @player_point, @player_point++;
	dispbottom "Click number "+ @player_point;
	end;
}

In that case *Athena has a bug. ^^

BTW; That's not just in C but in every other language I know.

static void Main(string[] args)
{
    int x = 0;
    int y = 0;
    for (int i = 0; i < 10; i++)
    {
      y = x++;
      Console.WriteLine(y.ToString());
    }
    Console.ReadKey();
}

http://www.pic-upload.de/view-20951045/08.10.jpg.html

 

If it's desired to work like you said, the operation should be ++i instead of i++. These are standards which everybody should follow them.

static void Main(string[] args)
{
    int x = 0;
    int y = 0;
    for (int i = 0; i < 10; i++)
    {
      y = ++x;
      Console.WriteLine(y.ToString());
    }
    Console.ReadKey();
}

http://www.pic-upload.de/view-20951176/08.10-2.jpg.html

[Vincent]

Thanks to all poster. Fixed it by using the var without ini it.