Request source mod to prevent @warp/jump/etc... while in a dialog box.

[Peopleperson49]

Currently if you are in a script dialog box you can still be recalled with guild/party recall, use jump, warp, etc... This is especially bad for some scripts such as securty scripts upon login. But affects a much wider range of other things. I request a source mod to prevent anything that can warp/jump/recall player while their in a dialog box (modify the current commands to prevent). Need to have a allow setting for the group.conf that allows ADMIN to bypass this.

Peopleperson49

Edited November 28, 2012 by Peopleperson49

[Aleos]

You could have a check in pc_setpos() to see if the character is talking to a NPC, but would this affect the warp script function.

if (sd->npc_id)
  return 1;

Return 1 actually returns an invalid map_index, so it's not a good return value but you'd have to create your own value (return 3) and have each function (warp, jump, recall, etc) check for return 3 as a player talking to a NPC. -- Banter. Can read if you wish.

So in short, you'd have to go through each command that changes a player's position (uses the pc_setpos() function) and have the check I used above, but instead of return 1 you would return -1. So you'd end up with:

if (sd->npc_id && get_group_level(sd) < X) {
  clif_displaymessage(fd, "You're talking to a NPC, failed to warp.");
  return -1;
}

You can add a battle_config flag if you want but that just seems like a little more work if you're only going to allow the admin group to bypass the check.

Edited November 28, 2012 by Aleos

[Peopleperson49]

I really think that something like this should be implemented in the SVN.

The group.conf setting for admin comes into play if a char is stuck in a script thats missing a close or something. Recalling them closes the dialog and gives the admin some flexability without the player having to close out of the game. Granted you never plan for errors but they happen. If you use non-admin chars test scripts this could be useful.

So far I figured out that you would have to modufy warp, warpto, jump, go, recall, recall guild/party/partner.

Peopleperson49