Ind Posted November 8, 2012 Posted November 8, 2012 currently this mempool implementation sirius black has added is not used so it wastes the thread it creates on server boot and is broken, for example if(p->num_nodes_free < p->elem_realloc_thresh) racond_signal(l_async_cond); if the free nodes are out and the spawner thread hasnt been run yet and you try to get another node it crashes the main thread. Do we get rid of it? is it there any point in it anymore(since greenbox has overhauled the ERS system)?
GreenBox Posted November 8, 2012 Posted November 8, 2012 Sirius mempool is thread safe and we will need it if someone plans to continue developing multithread support.
Ind Posted November 8, 2012 Author Posted November 8, 2012 I understand it was designed to be thread safe, but at its current stage it is not -- nevertheless you have a good point.
Cookie Posted November 24, 2012 Posted November 24, 2012 I'll follow-up with SB on this, and if he has intentions of [truly] finishing this... we'll update the thread 'Rejected'. Otherwise, I'm going to accept the removal.
xazax Posted November 26, 2012 Posted November 26, 2012 Has this stuff been merged into trunk? O.o IMO it was too early then.
Recommended Posts