Jump to content

mempool discussion


Ind

Recommended Posts


  • Group:  Members
  • Topic Count:  169
  • Topics Per Day:  0.04
  • Content Count:  1260
  • Reputation:   750
  • Joined:  11/19/11
  • Last Seen:  

currently this mempool implementation sirius black has added is not used so it wastes the thread it creates on server boot and is broken, for example

if(p->num_nodes_free < p->elem_realloc_thresh)
	racond_signal(l_async_cond);

if the free nodes are out and the spawner thread hasnt been run yet and you try to get another node it crashes the main thread.

Do we get rid of it? is it there any point in it anymore(since greenbox has overhauled the ERS system)?

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  9
  • Topics Per Day:  0.00
  • Content Count:  303
  • Reputation:   101
  • Joined:  11/13/11
  • Last Seen:  

Sirius mempool is thread safe and we will need it if someone plans to continue developing multithread support.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  169
  • Topics Per Day:  0.04
  • Content Count:  1260
  • Reputation:   750
  • Joined:  11/19/11
  • Last Seen:  

I understand it was designed to be thread safe, but at its current stage it is not -- nevertheless you have a good point.

Link to comment
Share on other sites

  • 3 weeks later...

  • Group:  Members
  • Topic Count:  20
  • Topics Per Day:  0.00
  • Content Count:  213
  • Reputation:   109
  • Joined:  05/21/12
  • Last Seen:  

I'll follow-up with SB on this, and if he has intentions of [truly] finishing this... we'll update the thread 'Rejected'. Otherwise, I'm going to accept the removal.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  11
  • Topics Per Day:  0.00
  • Content Count:  427
  • Reputation:   123
  • Joined:  11/17/11
  • Last Seen:  

Has this stuff been merged into trunk? O.o

IMO it was too early then.

Link to comment
Share on other sites

  • 4 weeks later...
×
×
  • Create New...