Ind Posted November 8, 2012 Group: Members Topic Count: 169 Topics Per Day: 0.03 Content Count: 1260 Reputation: 750 Joined: 11/19/11 Last Seen: April 11, 2013 Share Posted November 8, 2012 currently this mempool implementation sirius black has added is not used so it wastes the thread it creates on server boot and is broken, for example if(p->num_nodes_free < p->elem_realloc_thresh) racond_signal(l_async_cond); if the free nodes are out and the spawner thread hasnt been run yet and you try to get another node it crashes the main thread. Do we get rid of it? is it there any point in it anymore(since greenbox has overhauled the ERS system)? Link to comment Share on other sites More sharing options...
GreenBox Posted November 8, 2012 Group: Members Topic Count: 9 Topics Per Day: 0.00 Content Count: 303 Reputation: 101 Joined: 11/13/11 Last Seen: October 11, 2023 Share Posted November 8, 2012 Sirius mempool is thread safe and we will need it if someone plans to continue developing multithread support. Link to comment Share on other sites More sharing options...
Ind Posted November 8, 2012 Group: Members Topic Count: 169 Topics Per Day: 0.03 Content Count: 1260 Reputation: 750 Joined: 11/19/11 Last Seen: April 11, 2013 Author Share Posted November 8, 2012 I understand it was designed to be thread safe, but at its current stage it is not -- nevertheless you have a good point. Link to comment Share on other sites More sharing options...
Cookie Posted November 24, 2012 Group: Members Topic Count: 20 Topics Per Day: 0.00 Content Count: 213 Reputation: 109 Joined: 05/21/12 Last Seen: December 27, 2014 Share Posted November 24, 2012 I'll follow-up with SB on this, and if he has intentions of [truly] finishing this... we'll update the thread 'Rejected'. Otherwise, I'm going to accept the removal. Link to comment Share on other sites More sharing options...
xazax Posted November 26, 2012 Group: Members Topic Count: 11 Topics Per Day: 0.00 Content Count: 427 Reputation: 123 Joined: 11/17/11 Last Seen: December 31, 2022 Share Posted November 26, 2012 Has this stuff been merged into trunk? O.o IMO it was too early then. Link to comment Share on other sites More sharing options...
lekkereten Posted December 23, 2012 Group: Members Topic Count: 8 Topics Per Day: 0.00 Content Count: 148 Reputation: 46 Joined: 11/02/11 Last Seen: November 25, 2024 Share Posted December 23, 2012 Mempool was disabled in r17021. Link to comment Share on other sites More sharing options...
Recommended Posts