Jump to content
  • 0

help me with this in src =(


Aya

Question


  • Group:  Members
  • Topic Count:  35
  • Topics Per Day:  0.01
  • Content Count:  125
  • Reputation:   2
  • Joined:  08/27/12
  • Last Seen:  

http://rathena.org/board/tracker/issue-6755-devotion-skill-bug/

I want the pally to be the one to recv the damage only.

I tried using this fix by icescope http://www.eathena.ws/board/index.php?autocom=bugtracker&showbug=3189

but it triggered an error in the battle.c and idk how to fix it :x PLEASE HELP ME THANK YOU!

here are my skill.c, battle.c and my status.c

http://www.mediafire.com/?nv760om1dquund5

Link to comment
Share on other sites

12 answers to this question

Recommended Posts


  • Group:  Members
  • Topic Count:  25
  • Topics Per Day:  0.01
  • Content Count:  198
  • Reputation:   47
  • Joined:  08/01/12
  • Last Seen:  


  • Group:  Members
  • Topic Count:  35
  • Topics Per Day:  0.01
  • Content Count:  125
  • Reputation:   2
  • Joined:  08/27/12
  • Last Seen:  

Can you revert that for me sir? Since I've uploaded my files here? Coz when I tried reverting it, it has 1 error in battle.c and I dont know how to debug it =(

24nnsiv.png

This is the error sir

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  25
  • Topics Per Day:  0.01
  • Content Count:  198
  • Reputation:   47
  • Joined:  08/01/12
  • Last Seen:  

try to dl ur files then compile using the visual c++ to see what is/are the error(s)

sorry, i've got a work to do also, so i can't revert your src =(

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  6
  • Topics Per Day:  0.00
  • Content Count:  134
  • Reputation:   35
  • Joined:  02/27/12
  • Last Seen:  

I didn't test, but, try it(It would only work on recent versions, rAthena 15185+):

Open:

src/map/battle.c

Find:

if( sc && sc->data[sC_DEVOTION] && damage > 0 && skill_id != PA_PRESSURE && skill_id != CR_REFLECTSHIELD )
 damage = 0;

Change it to:

if( sc && sc->data[sC_DEVOTION] && damage > 0)
 damage = 0;

Open:

src/map/skill.c

Find:

 if( !sc || (!sc->data[sC_DEVOTION] && skillid != CR_REFLECTSHIELD) )

Change it to:

if( !sc || (!sc->data[sC_DEVOTION] )

Find:

battle_delay_damage(tick, dmg.amotion,bl,src,0,CR_REFLECTSHIELD,0,rdamage,ATK_DEF,0);

Change it to:

battle_delay_damage(tick, dmg.amotion,bl,src,0,0,0,rdamage,ATK_DEF,0);

Find:

if( sc && sc->data[sC_DEVOTION] && skillid != PA_PRESSURE )

Change it to:

if( sc && sc->data[sC_DEVOTION] )

Edited by MarkZD
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  35
  • Topics Per Day:  0.01
  • Content Count:  125
  • Reputation:   2
  • Joined:  08/27/12
  • Last Seen:  

Doesn't work, Mark. It has an error.

skill.c: In function âskill_attackâ:

skill.c:2539: error: expected â)â before âstatus_damageâ

skill.c:2544: error: expected expression before â}â token

make[1]: *** [obj_sql/skill.o] Error 1

make[1]: Leaving directory `/eathena/src/map'

make: *** [map_sql] Error 2

[root@elite-ro eathena]#

line 2539: status_fix_damage(src,bl,damage,dmg.dmotion); //Deal damage before knockback to allow stuff like firewall+storm gust combo.

line 2544: }

Please help me sir =(

Sir I've implemented your battle.c and It somehow solves my problem. Here's the new situation after implementing your battle.c

2 pally, 2 champ.

Let: Party1 = pally1 + champ 1

Party2 = pally2 + champ 2

this is what is happening now, assuming that Champ 1 gets a Devotion from his party member (pally1), then, champ2 (wearing Orc Lord Card Armor) also gets devoted by his pally, when Champ1 asura champ2 (who is wearing Orc Lord Card), the champ2's pally died, but the problem is, my pally didn't receive any damage at all.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  81
  • Topics Per Day:  0.02
  • Content Count:  1654
  • Reputation:   583
  • Joined:  08/09/12
  • Last Seen:  

Not sure about this, but it seems you're trying to mix eAthena code with rAthena trunk.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  35
  • Topics Per Day:  0.01
  • Content Count:  125
  • Reputation:   2
  • Joined:  08/27/12
  • Last Seen:  

=( PLEASE HELP ME ;(

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  35
  • Topics Per Day:  0.01
  • Content Count:  125
  • Reputation:   2
  • Joined:  08/27/12
  • Last Seen:  

bump

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  35
  • Topics Per Day:  0.01
  • Content Count:  125
  • Reputation:   2
  • Joined:  08/27/12
  • Last Seen:  

FIXED.

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  6
  • Topics Per Day:  0.00
  • Content Count:  134
  • Reputation:   35
  • Joined:  02/27/12
  • Last Seen:  

FIXED.

It's fine you've got it.

Would you like to share how you did it?. ;D

Edited by MarkZD
Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  35
  • Topics Per Day:  0.01
  • Content Count:  125
  • Reputation:   2
  • Joined:  08/27/12
  • Last Seen:  

Hard code in battle.c, pc.c and skill.c

I did it in C++

Link to comment
Share on other sites


  • Group:  Members
  • Topic Count:  155
  • Topics Per Day:  0.03
  • Content Count:  647
  • Reputation:   16
  • Joined:  11/21/11
  • Last Seen:  

can you share us your fix?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...