Renewal EDP is not working - Please Help me

[Dvrstle]

   if( sc->data[sC_EDP] ){
		    switch(skill_num){
			 case AS_SPLASHER:			   case AS_VENOMKNIFE:
			 case ASC_METEORASSAULT:
			 break;
#ifdef RENEWAL_EDP
			 case AS_SONICBLOW:
			 case ASC_BREAKER:
			 case GC_COUNTERSLASH:
			 case GC_CROSSIMPACT:
			  ATK_RATE(50); // only modifier is halved but still benefit with the atk and weapon bonus
			  break;
#else
			 case ASC_BREAKER: break;
			 default:
			  ATK_ADDRATE(sc->data[sC_EDP]->val3);//It doesn't exist in RENEWAL
#endif
		    }
  }
 }

/// renewal enchant deadly poison algorithm
///
/// leave this line to enable the renewed EDP algorithm
/// under renewal mode:
///  - damage is NOT increased by 400%
///  - it does NOT affect grimtooth
///  - weapon and status ATK are increased
#define RENEWAL_EDP

help

[MarkZD]

What exactly is not working?

It increases wAtk and eAtk(actually it's increasing bAtk in source, maybe it's right) in Renewal the way it should.

But this code you posted is not the currently in source, it's the one I posted that I think is near to official.

If you implement this code you posted in your file "battle.c" replacing the actual piece, it should work from my tests.

http://rathena.org/board/tracker/issue-6066-edp-should-no-longer-increase-final-damage/

Edited June 24, 2012 by MarkZD

[Dvrstle]

i've already copied it . . . but its not working . . . as far as i know.. . Cross impact damage should be halved right?

help me please =)

[MarkZD]

i've already copied it . . . but its not working . . . as far as i know.. . Cross impact damage should be halved right?

help me please =)

It's halved in this piece:

case GC_CROSSIMPACT:
							  ATK_RATE(50);

Its damage is still increased by EDP, but it's halved after increased.

Edited June 24, 2012 by MarkZD

[Dvrstle]

ahh . . . so i will not notice it that it was halved?

[MarkZD]

Well, let's say that if it was not halved and you're hitting 30k it'd hit 60k.

It's halved but because of beeing affected by EDP before it'll, probably, always do greater damage than without EDP.

[Dvrstle]

i can see that the base atk increases . . . but here's d dmage. . . no edp = 400 w/ edp = 1k

[MarkZD]

i can see that the base atk increases . . . but here's d dmage. . . no edp = 400 w/ edp = 1k

It's because it's not the 400 damage that will be halved.

You used EDP so your bATK and eATK increased, so your attack will be higher because it depends on your bATK and eATK that you can check in alt+q.

Sample:

You have 200 bATK, you will damage =400-100(def) = 300.

After EDP you'll have 800 bAtk, so it'll damage = 1600/2(halved edp) = 800(-100def) = 700.

Of course this is not the formula of damage in the source, it's just a sample so you can see that damage with EDP will, probably, always be higher than normal even with halved damage.

[Dvrstle]

ah so still . . renewal edp will balance the TGK/THANA and IP effects?

[MarkZD]

Only tests will say.

I didn't check it yet.

[Dvrstle]

btw . . . where should i put thana/ip . . . it should be on left hand right?

[Lelouch vi Britannia]

I dont know if im wrong i think "Enchant Deadly Poison" is not working in Pre-RE and RE i used r16353 . also i noticed no EDP logo appears in the upper right side of the screen

[dice4real]

where should i put this please help. Having EDP problem to my server.

[Kaito Kid]

where should i put this please help. Having EDP problem to my server.

battle.c