Auto MVP Summoner not working

[rkhin28]

Can anybody modify this script so it could run for rAthena?

//============================================================
//= Auto MVP Summoner
//===== By: =======================Modified By:=========
//= xMachina / Acetito    Emistry
//===== Current Version: =====================================
//= 1.0
//===== Compatible With: =====================================
//= eA SVN 5000+
//===== Additional Comments: =================================
//= v1.0 Testing Mode
//============================================================

gonryun,155,181,5 script MVP Attack 437,{
mes "[ ^0065DFxMachina^000000 ]";
if(getgmlevel() < 20) {
if(!.Event) mes "There is no MVP Attack Event now.";
else {
 mes "There is a MVP Attack Event on now!";
 mes "Location: " + $@Map$;
 mes "Special MVP: " + $@SpecialMVP;
 mes "Normal MVP: " + $@NormalMVP;
}
close;
}
Main:
mes "Please customize the MVP Attack Event:";
while(1){
switch(select("Item ["+getitemname($@ItemID)+" x "+$@Amount+"]:Location [" + $@Map$ + "]:MVP [special "+$@SpecialMVP+" |Normal "+$@NormalMVP+"]:Start/END Event")) {
Case 1:
  mes "What item to be given to MVP Killer ?";
  next;
  do{
  message strcharinfo(0),"Enter a VALID itemID. Example 501 - Red Potion.";
  input $@ItemID,501,32767;
  }while( getitemname( $@ItemID ) == "null" );
  mes "Input the Amount of Item to be Rewarded for Special MVP Killer.";
  input $@Amount,1,30000;
  next;
  break;
Case 2:
  mes "Which map would you like me to host this event?";
  mes "Input a ^FF0000VALID^000000 mapname.";
  do{
  message strcharinfo(0),"Enter a VALID mapname . Example : prt_maze02";
  input $@Map$;
  }while( getmapmobs( $@Map$ ) == -1 );
  next;
  break;
Case 3:
  mes "How many ^FF0000Special^000000 MVP would you like me to summon?";
  input $@SpecialMVP;
  next;
  mes "How many ^FF0000Normal^000000 MVP would you like me to summon?";
  input $@NormalMVP;
  dispbottom "Special MVP = "+$@SpecialMVP+"   and   Normal MVP = "+$@NormalMVP+" ";
  next;
  break;
Case 4:
  if( getmapmobs( $@Map$ ) == -1 || $@SpecialMVP == 0 ){
  mes "Please make sure your have do the Correct Configuration.";
  next;
  break;
  }
 if( !.Event ){
  mes "Starting the event now...";
  set .Event,1;
  monster $@Map$,0,0,"--ja--",-3,$@SpecialMVP,strnpcinfo(3)+"::OnSpecialKill";
  monster $@Map$,0,0,"--ja--",-3,$@NormalMVP,strnpcinfo(3)+"::OnNormalKill";
  announce "Map Invasion Begin : "+$@SpecialMVP+" Special MVP has invaded in "+$@Map$+". Hurry Up..",0,0x98FB98;
 }else{
  mes "Ending the event now...";
  announce "The MVP Attack Event is now over!",0,0x98FB98;
  killmonster $@Map$,"All";
  set .Event,0;
  }
 close;
}
}

OnSpecialKill:
announce "["+strcharinfo(0)+"] has killed 1 Special MVP and Gained Mystery Items .  Left "+mobcount($@Map$,strnpcinfo(3)+"::OnSpecialKill")+" Special MVP.",0;
getitem $@ItemID,$@Amount;
if( mobcount( $@Map$,strnpcinfo(3)+"::OnSpecialKill" ) == 0 ){ announce "The MVP Attack Event is now over!",0,0x98FB98;
killmonster $@Map$,"All";
set .Event,0;
}
end;

OnNormalKill:
dispbottom "You killed Normal MVP ( No Reward ).  Special MVP Left : "+mobcount($@Map$,strnpcinfo(3)+"::OnSpecialKill")+" .";
end;
OnClock0000:
OnClock0400:
OnClock0800:
OnClock1200:
OnClock1600:
OnClock2000:
if( getmapmobs( $@Map$ ) == -1 || $@SpecialMVP == 0 ){
announce "MVP Invasion Event Failed due to MisConfiguration of Event. Please Report to Staffs.",0;
end;
}
set .Event,1;
monster $@Map$,0,0,"--ja--",-3,$@SpecialMVP,strnpcinfo(3)+"::OnSpecialKill";
monster $@Map$,0,0,"--ja--",-3,$@NormalMVP,strnpcinfo(3)+"::OnNormalKill";
announce "Map Invasion Begin : "+$@SpecialMVP+" Special MVP has invaded in "+$@Map$+". Hurry Up..",0,0x98FB98;
end;
}

Thanks!

[Rikimaru]

Check this part :

 mes "Location: " + $@Map$;
 mes "Special MVP: " + $@SpecialMVP;
 mes "Normal MVP: " + $@NormalMVP;

Shouldn't it be :

 mes "Location: " + $@Map$ + ".";
 mes "Special MVP: " + $@SpecialMVP + ".";
 mes "Normal MVP: " + $@NormalMVP + ".";

??

That's all I found atm.

[rkhin28]

The error is always parse_simpleexpr: unmatch ')' on the command }while( getmapmobs( $@Map$ ) == -1 );

[Emistry]

change

  do{
  message strcharinfo(0),"Enter a VALID mapname . Example : prt_maze02";
  input $@Map$;
  }while( getmapmobs( $@Map$ ) == -1 );

into

  message strcharinfo(0),"Enter a VALID mapname . Example : prt_maze02";
  input $@Map$;

getmapmob command has been removed in rAthena

[rkhin28]

Took that out and all getmapmobs tag but when ingame and putting the mapname already it is stuck in there and there is no next or close.