[Linux] athena-start

[Calmcacil]

The athena-start script could use some improvement, this is just a suggestion for a quick fix.

What this does is basically telling the start script to sleep for 5 seconds before executing the map-server, I think this is useful due to the whole issue where you run restart and your map server doesnt get started because its still waiting for the old instance to close (cant bind Ip due to port in use.) that you generally experience upon calling a restart making the restart command not really do much unless the map server has actually crashed.

edit: Adding a check to see if map server is already running, then posting new diff.

edit2: Added check to see if the map server is already running, if it is the script will output this information to the user, wait for 5 seconds and then start the server, if its not found. It will start the map server normally.

athena-start.diff

Edited January 8, 2012 by Calmcacil

[CalciumKid]

I havent ever used the athena-start file without modifying it to use screen.

Perhaps something that should be considered.

[Maki]

I have personally never used it either. I've always used each server on its own screen (Screens: Login/Char/Map). Would be an interesting idea of athena-start automatically started all servers in their respective screens =]

[CalciumKid]

#!/bin/sh
# athena starting script by rowla
# modified by [email protected] (NL101541)

PATH=./:$PATH

L_SRV=login-server_sql
C_SRV=char-server_sql
M_SRV=map-server_sql

print_start() {
#    more << EOF
echo "Athena Starting..."
echo "		    (c) 2003 Athena Project"
echo "			  modified by [email protected]"
echo ""
#echo "Debug informations will appear,"
#echo "since this is a test release."
#echo ""
echo "checking..."
#EOF
}

check_files() {

   for i in ${L_SRV} ${C_SRV} ${M_SRV}
   do
    if [ ! -f ./$i ]; then
	    echo "$i does not exist, or can't run."
	    echo "Stop. Check your compile."
	    exit 1;
    fi
   done

#    more << EOF
echo "Check complete."
echo "Looks good, a nice Athena!"
#EOF
}


case $1 in
   'start')
    print_start
    check_files

    exec screen -d -m -S login .{L_SRV}&
    exec screen -d -m -S char ./${C_SRV}&
    exec screen -d -m -S map ./${M_SRV}&

    echo "Now Started Athena."
    echo "To view one of the servers type as shown:"
    echo "Login: screen -r login"
    echo "Char : screen -r char"
    echo "Map  : screen -r map"
    echo "To stop viewing a screen hold Ctrl+A and tap D"
;;
   'stop')
    ps ax | grep -E "${L_SRV}|${C_SRV}|${M_SRV}" | awk '{print $1}' | xargs kill
;;
   'restart')
    $0 stop
    $0 start
;;
   *)
    echo "Usage: athena-start { start | stop | restart }"
;;
esac

as you wish sir.

[Lighta]

Better use a while loop if you wanna do this check, since it may not finish on 5s.

http://pastebin.com/jR91fv1U

Also you check it's quite overkill with ps -ax, juste like the one in stop in fact instead using pkill. (btw stop quite annoying if you have multiple server running with same name).

http://mywiki.wooledge.org/ProcessManagement

Oh and little note I said to update this thing a month ago at least..

Edited January 9, 2012 by Lighta

[fabs]

Honestly, I don't see the point in improving the script when there are better alternatives. I use daemontools's supervise. My run scripts look similar to this:

#!/bin/sh
cd /eathena/server/trunk
exec /eathena/server/trunk/char-server_sql > /dev/null

This way, if the server crashes it automatically restarts.