Release: @hidepet / @hidepetall commands

[Daegaladh]

View File

@hidepet / @hidepetall commands

---

@hidepet allows to hide all pets except the player's, whereas @hidepetall hides all pets, including the player's.

This mod also allows to set a default parameter in battle_conf, just add

hide_pet: 1

To set all pets hidden except the player's, or 2 for all pets period.

 

 

---

• Submitter
  Daegaladh
• Submitted
  08/21/24
• Category
  Source Modifications
• Video
  https://youtu.be/VUCVy5i3M64
• Content Author
  Daegaladh

 

[Poring King]

I hope this will add to rA Master . This is really cool idea

[Ice Bear]

Is this safe @Daegaladh ?

 

Edited August 26, 2024 by Ice Bear

[Daegaladh]

5 hours ago, Ice Bear said:

Is this safe @Daegaladh ?

 

I made this for the lastest rAthena, so just update your rAthena, or use sd->fd instead

[Ice Bear]

@Daegaladh thanks manage to solve it. anyone who experience the same error can dm me for the changes thanks again

Edited August 26, 2024 by Ice Bear

[Ice Bear]

Thanks ill check the latest one for this part ill try

[Daegaladh]

I've improved it a bit and added a version compatible with the old clif_clearunit_single for older rAthena versions.

[studying]

very useful features command for player love it works fine thanks

[drigoguille]

Hello! this warning appeared on the console like this even using the old_clearunit version

In file included from ../common/cbasetypes.hpp:338:0,
                 from atcommand.hpp:7,
                 from atcommand.cpp:4:
../custom/atcommand.inc: In function ‘int atcommand_hidepet_sub(block_list*, __va_list_tag*)’:
../custom/atcommand.inc:449:18: warning: ‘bool’ is promoted to ‘int’ when passed through ‘...’
  if (!va_arg(ap, bool) && sd->pd != nullptr && sd->pd->bl.id == bl->id) {
                  ^
../custom/atcommand.inc:449:18: note: (so you should pass ‘int’ not ‘bool’ to ‘va_arg’)
../custom/atcommand.inc:449:18: note: if this code is reached, the program will abort
../custom/atcommand.inc:450:17: warning: ‘uint8 {aka unsigned char}’ is promoted to ‘int’ when passed through ‘...’
   if(va_arg(ap, uint8) == 2)
                 ^
../custom/atcommand.inc:450:17: note: if this code is reached, the program will abort

@edit

Solvet change bool and unit8 to int.  "If this will break I don't know but it worked"

+	if (!va_arg(ap, bool) && sd->pd != nullptr && sd->pd->bl.id == bl->id) {
+		if(va_arg(ap, uint8) == 2)
+			clif_spawn(&sd->pd->bl, true);
+		return 0;
+	}
+

TO

+	if (!va_arg(ap, int) && sd->pd != nullptr && sd->pd->bl.id == bl->id) {
+		if(va_arg(ap, int) == 2)
+			clif_spawn(&sd->pd->bl, true);
+		return 0;
+	}
+

 

Edited September 18, 2024 by drigoguille

[Daegaladh]

On 9/18/2024 at 2:40 PM, drigoguille said:

Hello! this warning appeared on the console like this even using the old_clearunit version

In file included from ../common/cbasetypes.hpp:338:0,
                 from atcommand.hpp:7,
                 from atcommand.cpp:4:
../custom/atcommand.inc: In function ‘int atcommand_hidepet_sub(block_list*, __va_list_tag*)’:
../custom/atcommand.inc:449:18: warning: ‘bool’ is promoted to ‘int’ when passed through ‘...’
  if (!va_arg(ap, bool) && sd->pd != nullptr && sd->pd->bl.id == bl->id) {
                  ^
../custom/atcommand.inc:449:18: note: (so you should pass ‘int’ not ‘bool’ to ‘va_arg’)
../custom/atcommand.inc:449:18: note: if this code is reached, the program will abort
../custom/atcommand.inc:450:17: warning: ‘uint8 {aka unsigned char}’ is promoted to ‘int’ when passed through ‘...’
   if(va_arg(ap, uint8) == 2)
                 ^
../custom/atcommand.inc:450:17: note: if this code is reached, the program will abort

@edit

Solvet change bool and unit8 to int.  "If this will break I don't know but it worked"

+	if (!va_arg(ap, bool) && sd->pd != nullptr && sd->pd->bl.id == bl->id) {
+		if(va_arg(ap, uint8) == 2)
+			clif_spawn(&sd->pd->bl, true);
+		return 0;
+	}
+

TO

+	if (!va_arg(ap, int) && sd->pd != nullptr && sd->pd->bl.id == bl->id) {
+		if(va_arg(ap, int) == 2)
+			clif_spawn(&sd->pd->bl, true);
+		return 0;
+	}
+

 

When is your rAthena from? I used one from January 1st 2024 as a base for the old clif_clearunit_single version.

Not sure why you get that warning, since all and prev_state are defined as bool and uint8 respectively.

 

It seems to be an issue with the compiler, I'll fix it on the next version

Edited September 25, 2024 by Daegaladh

[louigui0224]

How to fix this?

clif_clearunit_single(bl->id, CLR_OUTSIGHT, *sd);

[Daegaladh]

15 hours ago, louigui0224 said:

How to fix this?

clif_clearunit_single(bl->id, CLR_OUTSIGHT, *sd);

Just use the old clif_clearunit_single version or update your rAthena 

[EAJ_BASEMASK]

clif_clearunit_single(bl->id, CLR_OUTSIGHT, fd);

 

[Daegaladh]

10 hours ago, EAJ_BASEMASK said:

clif_clearunit_single(bl->id, CLR_OUTSIGHT, fd);

 

That's incorrect, there's no direct access to fd on that function. Plus I already provided a fix for that specific version.

[EAJ_BASEMASK]

6 hours ago, Daegaladh said:

That's incorrect, there's no direct access to fd on that function. Plus I already provided a fix for that specific version.

i just realized it was changed, the headers changes as well in this commit: https://github.com/rathena/rathena/commit/5df7de2b15959b234d0b1a73c534b1720e3acc21

[Daegaladh]

That's why I released 2 versions of the patch, for before and after clif_clearunit_single changes.