Jump to content
  • 0

Script command 'callfunc' returned failure.

Dolphin86

Asked by Dolphin86,

 Share

Question

Dolphin86 Pouring

Dolphin86

Posted
  • Group:  Members
  • Topic Count:  280
  • Topics Per Day:  0.06
  • Content Count:  757
  • Reputation:   17
  • Joined:  01/07/12
  • Last Seen:  
Posted (edited)

As state in question, kinda lost of what i did was wrong, could someone help me fix this script of mine.. thanks.. 

[Error]: buildin_callfunc: Function not found! [F_restore]
Spoiler 
moc_para01,46,36,4	script	Guild Blacksmith	826,{
	
	if(countitem(40056) < 1){
		goto notmember;
	}
//============================
// functions
//============================
// F_restore 
	function	F_restore	{
	.@rental_item = getarg(0);
	.@item_1 = getarg(1);
	.@item_2 = getarg(2);
	.@item_3 = getarg(3);
	
	if(rentalcountitem(.@rental_item) < 1){
		clear;
		soundeffect "menu.wav",0;
		mes "^ce7e00 === Hafiz === ^000000";
		mes "You don't have a ";
		mes ""+ getitemname(.@rental_item) +".";
		close;
	}
	if(countitem(.@item_1) < 1){
		clear;
		soundeffect "menu.wav",0;
		mes "^ce7e00 === Hafiz === ^000000";
		mes "You don't have a "+ getitemname(.@item_1) +"."; 
		close;
	}
	if(countitem(.@item_2) < 10){
		clear;
		soundeffect "menu.wav",0;
		mes "^ce7e00 === Hafiz === ^000000";
		mes "You don't have 10 "+ getitemname(.@item_2) +"."; 
		close;
	}
	
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Great, here is your new "+ getitemname(.@item_3) +".";
	delitem (.@rental_item), 1;
	delitem (.@item_1), 1;
	delitem (.@item_2), 10;
	getitem (.@item_3), 1;
	close;

	}

// Text
//=============================
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Oh hello there, how can i help you ?";
	switch(select("- Restore:- Upgread Item Gred:- Cancel")){
		case 1:
			goto restore1;
		case 2:
			goto upgreadclass;
		case 3:
			end;
	}

// Restore
//=============================
restore1:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Oh you need restore ?";
	switch(select("- Restore Information:- Restore Item:- Cancel")){
		case 1:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Well your item usually come"
			mes "with 7 days rental period,";
			mes "but if you wish to extend";
			mes "that rental period";
			mes "you can come to me";
			mes "for a complete restore";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "To restore weapons or armor, i will need";
			mes "- 1 Restore Token";
			mes "- 10 Durengo Coin";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Just for the records.. i will only";
			mes "restore Tier 2 and above items..";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "For tools i will just need";
			mes "- 1 Restore Token";
			mes "- 5 Durengo Coin";
			close;
		case 2:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Ok then, what item do you need to restore ?";
			switch(select("- Weapon:- Armor:- Tools:- Cancel")){
				case 1:
					goto wep_restore;
				case 2:
					goto armor_restore;
				case 3:
					goto tool_restore;
				case 4:
					end;
			}
		case 3:
			end;
	}
	
wep_restore:
		clear;
		soundeffect "menu.wav",0;
		mes "^ce7e00 === Hafiz === ^000000";
		mes "Select Weapon Tier";
		switch(select("- Tier 2:- Cancel")){
			case 1:
				clear;
				soundeffect "menu.wav",0;
				mes "^ce7e00 === Hafiz === ^000000";
				mes "Select the weapon you wish to restore";
				switch(select("- Improvise Dagger:- Cancel")){
					case 1:
						goto improdaggres;
					case 2:
						end;
				}
			case 2:
				end;
		}
		
improdaggres:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Select Dagger Gred";
	switch(select("- Gred A:- Gred B:- Gred C:- Gred D:- Gred E:- Cancel")){
		case 1:
			callfunc "F_restore",40081,40225,40016,40082;
		case 2:
			end;
		case 3:
			end;
		case 4:
			end;
		case 5:
			end;
		case 6:
			end;
	}
		
armor_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;
	
tool_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;
	
// Upgrade
//=============================
upgreadclass:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;

// Members
//=============================
notmember:
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "You need to be a member before i can asist you.";
	close;
}

 

 

Edited by Dolphin86
Link to comment
Share on other sites

8 answers to this question

Recommended Posts

  • 0
Poring King Eggring

Poring King

Posted
  • Group:  Members
  • Topic Count:  63
  • Topics Per Day:  0.02
  • Content Count:  1016
  • Reputation:   191
  • Joined:  11/27/14
  • Last Seen:  
Posted 
moc_para01,46,36,4	script	Guild Blacksmith	826,{

	if(countitem(40056) < 1){
		goto notmember;
	}
	
//============================
// functions
//============================
// F_restore 
	function	F_restore	{
		.@rental_item = getarg(0);
		.@item_1 = getarg(1);
		.@item_2 = getarg(2);
		.@item_3 = getarg(3);
		
		if(rentalcountitem(.@rental_item) < 1){
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "You don't have a ";
			mes ""+ getitemname(.@rental_item) +".";
			close;
		}
		if(countitem(.@item_1) < 1){
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "You don't have a "+ getitemname(.@item_1) +"."; 
			close;
		}
		if(countitem(.@item_2) < 10){
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "You don't have 10 "+ getitemname(.@item_2) +"."; 
			close;
		}
		
		clear;
		soundeffect "menu.wav",0;
		mes "^ce7e00 === Hafiz === ^000000";
		mes "Great, here is your new "+ getitemname(.@item_3) +".";
		delitem (.@rental_item, 1);
		delitem (.@item_1, 1);
		delitem (.@item_2, 10);
		getitem (.@item_3, 1);
		close;
	}

// Text
//=============================
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Oh hello there, how can I help you ?";
	switch(select("- Restore:- Upgrade Item Grade:- Cancel")){
		case 1:
			goto restore1;
		case 2:
			goto upgradeclass;
		case 3:
			end;
	}

// Restore
//=============================
restore1:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Oh, you need restore?";
	switch(select("- Restore Information:- Restore Item:- Cancel")){
		case 1:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Well, your item usually comes"
			mes "with a 7-day rental period,";
			mes "but if you wish to extend";
			mes "that rental period,";
			mes "you can come to me";
			mes "for a complete restore.";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "To restore weapons or armor, I will need";
			mes "- 1 Restore Token";
			mes "- 10 Durengo Coins";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Just for the record, I will only";
			mes "restore Tier 2 and above items.";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "For tools, I will just need";
			mes "- 1 Restore Token";
			mes "- 5 Durengo Coins";
			close;
		case 2:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Ok then, what item do you need to restore?";
			switch(select("- Weapon:- Armor:- Tools:- Cancel")){
				case 1:
					goto wep_restore;
				case 2:
					goto armor_restore;
				case 3:
					goto tool_restore;
				case 4:
					end;
			}
		case 3:
			end;
	}
	
wep_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Select Weapon Tier";
	switch(select("- Tier 2:- Cancel")){
		case 1:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Select the weapon you wish to restore";
			switch(select("- Improvise Dagger:- Cancel")){
				case 1:
					goto improdaggres;
				case 2:
					end;
			}
		case 2:
			end;
	}
		
improdaggres:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Select Dagger Grade";
	switch(select("- Grade A:- Grade B:- Grade C:- Grade D:- Grade E:- Cancel")){
		case 1:
			callfunc "F_restore",40081,40225,40016,40082;
			break;
		case 2:
			end;
		case 3:
			end;
		case 4:
			end;
		case 5:
			end;
		case 6:
			end;
	}
		
armor_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;
	
tool_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;
	
// Upgrade
//=============================
upgradeclass:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;

// Members
//=============================
notmember:
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "You need to be a member before I can assist you.";
	close;
}

Try this
 

  • Added missing semicolons.
  • Corrected "Upgread Item Gred" to "Upgrade Item Grade".
  • Fixed indentation and logical flow.
  • Corrected misspelled words.
  • Ensured all cases in switches are properly closed with end; or break;.
Link to comment
Share on other sites
  • 0
Dolphin86 Pouring

Dolphin86

Posted
  • Group:  Members
  • Topic Count:  280
  • Topics Per Day:  0.06
  • Content Count:  757
  • Reputation:   17
  • Joined:  01/07/12
  • Last Seen:  
  • Author
Posted
5 minutes ago, Poring King said: 
moc_para01,46,36,4	script	Guild Blacksmith	826,{

	if(countitem(40056) < 1){
		goto notmember;
	}
	
//============================
// functions
//============================
// F_restore 
	function	F_restore	{
		.@rental_item = getarg(0);
		.@item_1 = getarg(1);
		.@item_2 = getarg(2);
		.@item_3 = getarg(3);
		
		if(rentalcountitem(.@rental_item) < 1){
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "You don't have a ";
			mes ""+ getitemname(.@rental_item) +".";
			close;
		}
		if(countitem(.@item_1) < 1){
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "You don't have a "+ getitemname(.@item_1) +"."; 
			close;
		}
		if(countitem(.@item_2) < 10){
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "You don't have 10 "+ getitemname(.@item_2) +"."; 
			close;
		}
		
		clear;
		soundeffect "menu.wav",0;
		mes "^ce7e00 === Hafiz === ^000000";
		mes "Great, here is your new "+ getitemname(.@item_3) +".";
		delitem (.@rental_item, 1);
		delitem (.@item_1, 1);
		delitem (.@item_2, 10);
		getitem (.@item_3, 1);
		close;
	}

// Text
//=============================
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Oh hello there, how can I help you ?";
	switch(select("- Restore:- Upgrade Item Grade:- Cancel")){
		case 1:
			goto restore1;
		case 2:
			goto upgradeclass;
		case 3:
			end;
	}

// Restore
//=============================
restore1:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Oh, you need restore?";
	switch(select("- Restore Information:- Restore Item:- Cancel")){
		case 1:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Well, your item usually comes"
			mes "with a 7-day rental period,";
			mes "but if you wish to extend";
			mes "that rental period,";
			mes "you can come to me";
			mes "for a complete restore.";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "To restore weapons or armor, I will need";
			mes "- 1 Restore Token";
			mes "- 10 Durengo Coins";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Just for the record, I will only";
			mes "restore Tier 2 and above items.";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "For tools, I will just need";
			mes "- 1 Restore Token";
			mes "- 5 Durengo Coins";
			close;
		case 2:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Ok then, what item do you need to restore?";
			switch(select("- Weapon:- Armor:- Tools:- Cancel")){
				case 1:
					goto wep_restore;
				case 2:
					goto armor_restore;
				case 3:
					goto tool_restore;
				case 4:
					end;
			}
		case 3:
			end;
	}
	
wep_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Select Weapon Tier";
	switch(select("- Tier 2:- Cancel")){
		case 1:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Select the weapon you wish to restore";
			switch(select("- Improvise Dagger:- Cancel")){
				case 1:
					goto improdaggres;
				case 2:
					end;
			}
		case 2:
			end;
	}
		
improdaggres:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Select Dagger Grade";
	switch(select("- Grade A:- Grade B:- Grade C:- Grade D:- Grade E:- Cancel")){
		case 1:
			callfunc "F_restore",40081,40225,40016,40082;
			break;
		case 2:
			end;
		case 3:
			end;
		case 4:
			end;
		case 5:
			end;
		case 6:
			end;
	}
		
armor_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;
	
tool_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;
	
// Upgrade
//=============================
upgradeclass:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;

// Members
//=============================
notmember:
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "You need to be a member before I can assist you.";
	close;
}

Try this
 

  • Added missing semicolons.
  • Corrected "Upgread Item Gred" to "Upgrade Item Grade".
  • Fixed indentation and logical flow.
  • Corrected misspelled words.
  • Ensured all cases in switches are properly closed with end; or break;.

still the same error

Link to comment
Share on other sites
  • 0
Poring King Eggring

Poring King

Posted
  • Group:  Members
  • Topic Count:  63
  • Topics Per Day:  0.02
  • Content Count:  1016
  • Reputation:   191
  • Joined:  11/27/14
  • Last Seen:  
Posted (edited)

This is your error 

[Error]: buildin_callfunc: Function not found! [F_restore]

So meaning you write your call function it should be

Quote

function[tab]script[tab][functionname[tab]{

The bold script is the one you are missing



Function should be written like this .

reference of writing npc script can be found inside script_commands line 1638 

*callfunc "<function>"{,<argument>,...<argument>};
*callfunc("<function>"{,<argument>,...<argument>})

This command lets you call up a function NPC. A function NPC can be called from
any script on any map server. Using the 'return' command it will come back to
the place that called it.

	place,50,50,6%TAB%script%TAB%Woman%TAB%115,{
		mes "[Woman]"
		mes "Let's see if you win...";
		callfunc "funcNPC";
		mes "Well done, you have won!";
		close;
	}
	function%TAB%script%TAB%funcNPC%TAB%{
		.@win = rand(2);
		if (.@win == 0)
			return;
		mes "Sorry, you lost.";
		close;
	}


So it will look like this 

	place,50,50,6%TAB%script%TAB%Woman%TAB%115,{
		mes "[Woman]"
		mes "Let's see if you win...";
		callfunc "funcNPC";
		mes "Well done, you have won!";
		close;
	}
	function%TAB%script%TAB%funcNPC%TAB%{
		.@win = rand(2);
		if (.@win == 0)
			return;
		mes "Sorry, you lost.";
		close;
	}
Edited by Poring King
Link to comment
Share on other sites
  • 0
Dolphin86 Pouring

Dolphin86

Posted
  • Group:  Members
  • Topic Count:  280
  • Topics Per Day:  0.06
  • Content Count:  757
  • Reputation:   17
  • Joined:  01/07/12
  • Last Seen:  
  • Author
Posted

well i did this 

function	script	F_res	{

came with this error now 

[Error]:
script error on npc/custom/guild_hall.txt line 433
    expect ';' or '{' at function syntax
   428 :
   429 : //============================
   430 : // functions
   431 : //============================
   432 : // F_restore
*  433 : function       script' 'F_res  {
   434 :                .@rental_item = getarg(0);
   435 :                .@item_1 = getarg(1);
   436 :                .@item_2 = getarg(2);
   437 :                .@item_3 = getarg(3);
   438 :

 

Link to comment
Share on other sites
  • 0
Poring King Eggring

Poring King

Posted
  • Group:  Members
  • Topic Count:  63
  • Topics Per Day:  0.02
  • Content Count:  1016
  • Reputation:   191
  • Joined:  11/27/14
  • Last Seen:  
Posted (edited)

Its a tab not space

And make sure there is a "}" in the end of function . The error already tell the complete detail of whats going wrong 

function%TAB%script%TAB%funcNPC%TAB%{
Edited by Poring King
Link to comment
Share on other sites
  • 0
Dolphin86 Pouring

Dolphin86

Posted
  • Group:  Members
  • Topic Count:  280
  • Topics Per Day:  0.06
  • Content Count:  757
  • Reputation:   17
  • Joined:  01/07/12
  • Last Seen:  
  • Author
Posted

it is tab, and i did make sure it is close properly

Spoiler 
moc_para01,46,36,4	script	Guild Blacksmith	826,{

	if(countitem(40056) < 1){
		goto notmember;
	}
	
//============================
// functions
//============================
// F_restore 
function	script	F_res	{
		.@rental_item = getarg(0);
		.@item_1 = getarg(1);
		.@item_2 = getarg(2);
		.@item_3 = getarg(3);
		
		if(rentalcountitem(.@rental_item) < 1){
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "You don't have a ";
			mes ""+ getitemname(.@rental_item) +".";
			close;
		}
		if(countitem(.@item_1) < 1){
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "You don't have a "+ getitemname(.@item_1) +"."; 
			close;
		}
		if(countitem(.@item_2) < 10){
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "You don't have 10 "+ getitemname(.@item_2) +"."; 
			close;
		}
		
		clear;
		soundeffect "menu.wav",0;
		mes "^ce7e00 === Hafiz === ^000000";
		mes "Great, here is your new "+ getitemname(.@item_3) +".";
		delitem (.@rental_item, 1);
		delitem (.@item_1, 1);
		delitem (.@item_2, 10);
		getitem (.@item_3, 1);
		close;
	}

// Text
//=============================
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Oh hello there, how can I help you ?";
	switch(select("- Restore:- Upgrade Item Grade:- Cancel")){
		case 1:
			goto restore1;
		case 2:
			goto upgradeclass;
		case 3:
			end;
	}

// Restore
//=============================
restore1:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Oh, you need restore?";
	switch(select("- Restore Information:- Restore Item:- Cancel")){
		case 1:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Well, your item usually comes";
			mes "with a 7-day rental period,";
			mes "but if you wish to extend";
			mes "that rental period,";
			mes "you can come to me";
			mes "for a complete restore.";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "To restore weapons or armor, I will need";
			mes "- 1 Restore Token";
			mes "- 10 Durengo Coins";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Just for the record, I will only";
			mes "restore Tier 2 and above items.";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "For tools, I will just need";
			mes "- 1 Restore Token";
			mes "- 5 Durengo Coins";
			close;
		case 2:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Ok then, what item do you need to restore?";
			switch(select("- Weapon:- Armor:- Tools:- Cancel")){
				case 1:
					goto wep_restore;
				case 2:
					goto armor_restore;
				case 3:
					goto tool_restore;
				case 4:
					end;
			}
		case 3:
			end;
	}
	
wep_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Select Weapon Tier";
	switch(select("- Tier 2:- Cancel")){
		case 1:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Select the weapon you wish to restore";
			switch(select("- Improvise Dagger:- Cancel")){
				case 1:
					goto improdaggres;
				case 2:
					end;
			}
		case 2:
			end;
	}
		
improdaggres:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Select Dagger Grade";
	switch(select("- Grade A:- Grade B:- Grade C:- Grade D:- Grade E:- Cancel")){
		case 1:
			callfunc "F_res",40081,40225,40016,40082;
			break;
		case 2:
			end;
		case 3:
			end;
		case 4:
			end;
		case 5:
			end;
		case 6:
			end;
	}
		
armor_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;
	
tool_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;
	
// Upgrade
//=============================
upgradeclass:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;

// Members
//=============================
notmember:
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "You need to be a member before I can assist you.";
	close;
}

 

 

Link to comment
Share on other sites
  • 0
Poring King Eggring

Poring King

Posted
  • Group:  Members
  • Topic Count:  63
  • Topics Per Day:  0.02
  • Content Count:  1016
  • Reputation:   191
  • Joined:  11/27/14
  • Last Seen:  
Posted

Try to re-write the script okay ? At least try it to your self . Do it with clean function first and try 1 by 1 so you can solve your things by your self . Because it might happen to you everytime

Link to comment
Share on other sites
  • 0
Tokei Garling

Tokei

Posted
  • Group:  Members
  • Topic Count:  16
  • Topics Per Day:  0.00
  • Content Count:  695
  • Reputation:   721
  • Joined:  11/12/12
  • Last Seen:  
Posted

You're trying to define a function within a script; those two should be separated. Usually you'd put functions in a different script file, but that's me nitpicking a little. Your script would look like this: 

script function F_res...

NPC scripts below

You have to put the script functions before the NPC scripts otherwise they won't be recognized while parsing the script. But... clearly, you wanted to use callsub rather than callfunc, which is slightly different. "callfunc" functions are global and can be used by all scripts, in different files, while "callsub" are functions that can be used within the current script only.

A callsub would look like this: 

//============================
// functions
//============================
// F_restore 
F_res:
	.@rental_item = getarg(0);
	.@item_1 = getarg(1);
	.@item_2 = getarg(2);
	.@item_3 = getarg(3);
	
	if(rentalcountitem(.@rental_item) < 1){
//...
	return;
// Then you call the function with:
callsub "F_res",40081,40225,40016,40082;

Your script also relies way too much on gotos. If the goto isn't used more than once, then it has no reason to be. It's harder to follow your script the way it is now than simply putting the code in the right place it belongs to. Well, not that it matters too much, just a general suggestion. Anyway, using callsub, your script would look like this: 

moc_para01,46,36,4	script	Guild Blacksmith	826,{
	if(countitem(40056) < 1){
		goto notmember;
	}

// Text
//=============================
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Oh hello there, how can I help you ?";
	switch(select("- Restore:- Upgrade Item Grade:- Cancel")){
		case 1:
			goto restore1;
		case 2:
			goto upgradeclass;
		case 3:
			end;
	}
	
	end;
// Restore
//=============================
restore1:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Oh, you need restore?";
	switch(select("- Restore Information:- Restore Item:- Cancel")){
		case 1:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Well, your item usually comes";
			mes "with a 7-day rental period,";
			mes "but if you wish to extend";
			mes "that rental period,";
			mes "you can come to me";
			mes "for a complete restore.";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "To restore weapons or armor, I will need";
			mes "- 1 Restore Token";
			mes "- 10 Durengo Coins";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Just for the record, I will only";
			mes "restore Tier 2 and above items.";
			next;
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "For tools, I will just need";
			mes "- 1 Restore Token";
			mes "- 5 Durengo Coins";
			close;
		case 2:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Ok then, what item do you need to restore?";
			switch(select("- Weapon:- Armor:- Tools:- Cancel")){
				case 1:
					goto wep_restore;
				case 2:
					goto armor_restore;
				case 3:
					goto tool_restore;
				case 4:
					end;
			}
		case 3:
			end;
	}
	
wep_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Select Weapon Tier";
	switch(select("- Tier 2:- Cancel")){
		case 1:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Select the weapon you wish to restore";
			switch(select("- Improvise Dagger:- Cancel")){
				case 1:
					goto improdaggres;
				case 2:
					end;
			}
		case 2:
			end;
	}
	end;
//============================
// functions
//============================
// F_restore 
F_res:
	.@rental_item = getarg(0);
	.@item_1 = getarg(1);
	.@item_2 = getarg(2);
	.@item_3 = getarg(3);
	
	if(rentalcountitem(.@rental_item) < 1){
		clear;
		soundeffect "menu.wav",0;
		mes "^ce7e00 === Hafiz === ^000000";
		mes "You don't have a ";
		mes ""+ getitemname(.@rental_item) +".";
		close;
	}
	if(countitem(.@item_1) < 1){
		clear;
		soundeffect "menu.wav",0;
		mes "^ce7e00 === Hafiz === ^000000";
		mes "You don't have a "+ getitemname(.@item_1) +"."; 
		close;
	}
	if(countitem(.@item_2) < 10){
		clear;
		soundeffect "menu.wav",0;
		mes "^ce7e00 === Hafiz === ^000000";
		mes "You don't have 10 "+ getitemname(.@item_2) +"."; 
		close;
	}
	
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Great, here is your new "+ getitemname(.@item_3) +".";
	delitem (.@rental_item, 1);
	delitem (.@item_1, 1);
	delitem (.@item_2, 10);
	getitem (.@item_3, 1);
	close;
improdaggres:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Select Dagger Grade";
	switch(select("- Grade A:- Grade B:- Grade C:- Grade D:- Grade E:- Cancel")){
		case 1:
			callsub "F_res",40081,40225,40016,40082;
			break;
		case 2:
			end;
		case 3:
			end;
		case 4:
			end;
		case 5:
			end;
		case 6:
			end;
	}
		
armor_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;
	
tool_restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;
	
// Upgrade
//=============================
upgradeclass:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Work In Progress";
	close;

// Members
//=============================
notmember:
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "You need to be a member before I can assist you.";
	close;
}

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to question listing
×
×
  • Create New...