Jump to content
  • 0

Rental Item Not Deleted

Dolphin86

Asked by Dolphin86,

 Share

Question

Dolphin86 Pouring

Dolphin86

Posted
Posted (edited)

as title my current script does not delete the rental item right after it is completed. 

setarray(.@product_recipe,40004,1,  40005,1,1, 40225,0,1, 40016,0,10);

as u can see 40005 is a rental item but it does not deleted right after completed..

full script below.

Spoiler 
moc_para01,46,36,4	script	Guild Blacksmith	826,{
	
	if(countitem(40056) < 1){
		goto notmember;
	}
	
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Oh hello there, how can i help you ?";
	switch(select("- Restore :- Cancel")){
		case 1:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Hafiz === ^000000";
			mes "Oh you need to restore ?";
			switch(select("- Restore:- Restore Information :- Cancel")){
				case 1:
					goto restore;
				case 2:
					goto restoreinfo;
				case 3:
					end;
			}
		case 2:
			end;
	}
	
restore:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Ok then, what type of item you wish to restore ?";
	switch(select("- Weapon:- Armor :- Tool:- Cancel")){
		case 1:
			goto weapon;
		case 2:
			end;
		case 3:
			end;
		case 4:
			end;
	}
		
restoreinfo:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Well you do have an equipment or tool";
	mes "with you right?, well those item have";
	mes "rental period, which means when the";
	mes "time is up, your rental item will be";
	mes "gone for good..";
	next;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "But i can restore those item";
	mes "back to box form, which means";
	mes "you can use it much more longer";
	next;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "But i do need 1 Restore Token";
	mes "and 10 Durengo Coin";
	mes "in oder for me to restore";
	close;
	
weapon:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "And the weapon tiers ?";
	switch(select("- Tier 1:- Cancel")){
		case 1:
			goto wt1;
		case 2:
			end;
	}
	
wt1:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Hafiz === ^000000";
	mes "Ok then, what is the weapon ?";
	switch(select("- Stone Knife:- Cancel")){
		case 1:
			clear;
			soundeffect "menu.wav",0;
			setarray(.@product_recipe, 40004, 1, 40005, 1, 1, 40225, 0, 1, 40016, 0, 10);
			break;
		case 2:
			end;
	}
	
	if(getarraysize(.@product_recipe) == 0) {
		end;
	}

	.@product_id = .@product_recipe[0];
	.@product_amount = .@product_recipe[1];

	for(.@i = 2; .@i < getarraysize(.@product_recipe); .@i += 3) {
		.@next_start_index = getarraysize(.@product_requirements);

		.@product_requirements[.@next_start_index] = .@product_recipe[.@i];
		.@product_requirements[.@next_start_index + 1] = .@product_recipe[.@i + 1];
		.@product_requirements[.@next_start_index + 2] = .@product_recipe[.@i + 2];
	}

	clear;
	soundeffect "menu.wav",0;
	mes "Require";
	for(.@i = 0; .@i < getarraysize(.@product_requirements); .@i += 3) {
		if(.@product_requirements[.@i + 1] == 1) {
			.@item_amount = rentalcountitem(.@product_requirements[.@i]);
		} else {
			.@item_amount = countitem(.@product_requirements[.@i]);
		}

		.@item_requirement_text$ = .@product_requirements[.@i + 2] + " " + getitemname(.@product_requirements[.@i]);
		if(.@item_amount < .@product_requirements[.@i + 2]) {
			.@not_enough_items = 1;

			mes "^ff0000- " + .@item_requirement_text$ + "^000000";
		} else {
			mes "^8fce00- " + .@item_requirement_text$ + "^000000";
		}
	}

	if(.@not_enough_items == 1) {
		close;
	}
	next;
	soundeffect "menu.wav",0;
	select("- Start");
	close2;
	progressbar("ffffff", 3);
	soundeffect "make.wav",0;
	
	for(.@i = 0; .@i < getarraysize(.@product_requirements); .@i += 3) {
		if(.@product_requirements[.@i + 1] == 0) {
			delitem(.@product_requirements[.@i], .@product_requirements[.@i + 2]);
		}
	}

	getitem(.@product_id, .@product_amount);
}

 

please help?

Edited by Dolphin86

2 answers to this question

Recommended Posts

  • 0
Poring King Eggring

Poring King

Posted
Posted

Your script works like getting item from NPC and it works like getting item from NPC single item with no rental features. You should use the rentalitem3 instead of "getitem". The rentalitem4 is very specific rental reward base item

  

rentitem4 "<item name>",<time>,<identify>,<refine>,<attribute>,<card1>,<card2>,<card3>,<card4>,<grade>,<RandomIDArray>,<RandomValueArray>,<RandomParamArray>{,<account_id>};


Please read the rental item info  

https://github.com/rathena/rathena/blob/master/doc/script_commands.txt


If you want to do it using getitem . Then add a script to your item look for script attribute and add your custom function that it will delete the item . If you dont know how to do that then just use the rentitem4 instead of using getitem



Advise:
Please before you explore so much at least give time to read the script_commands.txt file that you can find in your server files . It will enhance your scripting ... even the search engine is available
 

  • 0
Dolphin86 Pouring

Dolphin86

Posted
  • Author
Posted
44 minutes ago, Poring King said:

Your script works like getting item from NPC and it works like getting item from NPC single item with no rental features. You should use the rentalitem3 instead of "getitem". The rentalitem4 is very specific rental reward base item

  

rentitem4 "<item name>",<time>,<identify>,<refine>,<attribute>,<card1>,<card2>,<card3>,<card4>,<grade>,<RandomIDArray>,<RandomValueArray>,<RandomParamArray>{,<account_id>};


Please read the rental item info  

https://github.com/rathena/rathena/blob/master/doc/script_commands.txt


If you want to do it using getitem . Then add a script to your item look for script attribute and add your custom function that it will delete the item . If you dont know how to do that then just use the rentitem4 instead of using getitem



Advise:
Please before you explore so much at least give time to read the script_commands.txt file that you can find in your server files . It will enhance your scripting ... even the search engine is available
 

the script was created by @Winterfox and it is way too complicated for my script knowladge.. i was hoping someone could re-write the script for me, i do know how to make it happen with my current script knowladge but it would be manually item per item, line per line which could lead to tons of line... here is an example working script that i try which is way too much...

Spoiler 
moc_para01,46,36,4	script	Guild Blacksmith	826,{
	
	if(countitem(40056) < 1){
		goto notmember;
	}
	
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Amir === ^000000";
	mes "I am the Guild Blacksmith,";
	mes "what do you need ?";
	switch(select("- Restore :- Cancel")){
		case 1:
			clear;
			soundeffect "menu.wav",0;
			mes "^ce7e00 === Amir === ^000000";
			mes "I can restore your rental item";
			mes "back to box, so you can keep your";
			mes "rental item much longer";
			switch(select("- Restore:- Requirement:- Cancel")){
				case 1:
					clear;
					soundeffect "menu.wav",0;
					mes "^ce7e00 === Amir === ^000000";
					mes "Good, now please select the type.";
					switch(select("- Weapons:- Armor:- Tools:- Cancel")){
						case 1:
							clear;
							soundeffect "menu.wav",0;
							mes "^ce7e00 === Amir === ^000000";
							mes "Please select the weapon tier.";
							switch(select("- Tier 1:- Cancel")){
								case 1:
									clear;
									soundeffect "menu.wav",0;
									mes "^ce7e00 === Amir === ^000000";
									mes "Now please select the weapon.";
									switch(select("- Stone Knife:- Makeshift Axe:- Makeshift Hammer:- Cancel")){
										case 1:
											if(countitem(40016) < 10 || countitem(40225) < 1 || rentalcountitem(40005) < 1){
											goto notenough;
											}
												delitem 40005, 1;
												delitem 40016, 10;
												delitem 40225, 1;
												getitem 40004, 1;
												clear;
												soundeffect "menu.wav",0;
												mes "^ce7e00 === Amir === ^000000";
												mes "Here is your new Stone Knife";
												close;
										case 2:
											if(countitem(40016) < 10 || countitem(40225) < 1 || rentalcountitem(40029) < 1){
											goto notenough;
											}
												delitem 40005, 1;
												delitem 40016, 10;
												delitem 40029, 1;
												getitem 40030, 1;
												clear;
												soundeffect "menu.wav",0;
												mes "^ce7e00 === Amir === ^000000";
												mes "Here is your new Makeshift Axe";
												close;
										case 3:
											if(countitem(40016) < 10 || countitem(40225) < 1 || rentalcountitem(40020) < 1){
											goto notenough;
											}
												delitem 40005, 1;
												delitem 40016, 10;
												delitem 40020, 1;
												getitem 40022, 1;
												clear;
												soundeffect "menu.wav",0;
												mes "^ce7e00 === Amir === ^000000";
												mes "Here is your new Makeshift Hammer";
												close;
										case 4:
											end;
									}
								case 2:
									end;
							}
						case 2:
							end;
						case 3:
							end;
						case 4:
							end;
					}
				case 2:
					clear;
					soundeffect "menu.wav",0;
					mes "^ce7e00 === Amir === ^000000";
					mes "In order to restore your rental item";
					mes "i will require:";
					mes "1 Restore Token";
					mes "10 Durengo Coin";
					mes "1 Selected rental item";
					close;
				case 3:
					end;
			}
		case 2:
			end;
	}

notenough:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Amir === ^000000";
	mes "Sorry did not have enough material";
	close;
	
notmember:
	clear;
	soundeffect "menu.wav",0;
	mes "^ce7e00 === Amir === ^000000";
	mes "I am sorry, you need to become a guild member.";
	close;
}

 

way too much unessary line for each items...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Answer this question...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to question listing

  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...