Custom Quest (quest_db.yml), finished but not gtting reward

[Dolphin86]

as mention above, i was testing to add custom quest to quest_db.yml, but when i have completed the quest i cant claim the reward, im sure there was a problem with the script, but i dont know which part..

script:

Spoiler

moc_para01,39,36,5	script	Quest Manager2	732,{

	if(countitem(40056) < 1) {
		soundeffect "menu.wav",0;
		mes "[^FF7700Quest Manager2^000000]";
		mes "Oh hello, im sorry,";
		mes "it seems you are not yet a register";
		mes "as a guild member, kindly register yourself";
		mes "at front desk to start accepting quest.";
		close;
		}
		
		soundeffect "menu.wav",0;
		mes "[^FF7700Quest Manager2^000000]";
		mes "Which type of quest would you like to start with?";
		switch(select("- Daily Quest:- Normal Quest:- Cancel")){
			case 1:
				clear;
				soundeffect "menu.wav",0;
				mes "[^FF7700Quest Manager2^000000]";
				mes "Please select your desire quest";
				switch(select("- Prontera Field Hunting 1 (Base level 1 - 40):- Reset:- Cancel")){
					case 1:
						if(#daily_quest != gettime(DT_DAYOFMONTH) && isbegin_quest(120000)!=0){
							erasequest 120000;}
						
						if(#daily_quest != gettime(DT_DAYOFMONTH) && isbegin_quest(120000)==0){
							clear;
							soundeffect "menu.wav",0;
							mes "[^FF7700Quest Manager2^000000]";
							mes "Please hunt the follwing monster list";
							mes "-100 Poring";
							mes "-100 Fabre";
							mes "-100 Pupa";
							setquest 120000;
							#daily_quest = gettime(DT_DAYOFMONTH);
							end;
						}else{
							clear;
							soundeffect "menu.wav",0;
							mes "[^FF7700Quest Manager2^000000]";
							mes "You already receive daily quest for today";
							end; 
						}
						if(checkquest(120000,HUNTING)==2){
							clear;
							soundeffect "menu.wav",0;
							mes "[^FF7700Quest Manager2^000000]";
							mes "Well good for you";
							mes "here is your reward";
							completequest 120000;
							getitem 40221, 1;
							getexp2 700,650;
						end;
						}
					
					case 2:
						clear;
						soundeffect "menu.wav",0;
						mes "[^FF7700Quest Manager2^000000]";
						mes "quest deleted";
						#daily_quest = 0;
						close;
					case 3:
						end;
				}
			case 2:
				mes "WIP";
				close;
			case 3:
				end;
	}
}

 

help...

[mrfizi]

What error out on your putty terminal?

It look like something wrong on your script on this line:

					case 1:
						if(#daily_quest != gettime(DT_DAYOFMONTH) && isbegin_quest(120000)!=0){
							erasequest 120000;}
						
						if(#daily_quest != gettime(DT_DAYOFMONTH) && isbegin_quest(120000)==0){
							clear;
							soundeffect "menu.wav",0;
							mes "[^FF7700Quest Manager2^000000]";
							mes "Please hunt the follwing monster list";
							mes "-100 Poring";
							mes "-100 Fabre";
							mes "-100 Pupa";
							setquest 120000;
							#daily_quest = gettime(DT_DAYOFMONTH);
							end;
						}else{
							clear;
							soundeffect "menu.wav",0;
							mes "[^FF7700Quest Manager2^000000]";
							mes "You already receive daily quest for today";
							end; 
						}
						if(checkquest(120000,HUNTING)==2){
							clear;
							soundeffect "menu.wav",0;
							mes "[^FF7700Quest Manager2^000000]";
							mes "Well good for you";
							mes "here is your reward";
							completequest 120000;
							getitem 40221, 1;
							getexp2 700,650;
						end;
						}

 

[Dolphin86]

3 hours ago, mrfizi said:

What error out on your putty terminal?

It look like something wrong on your script on this line:

					case 1:
						if(#daily_quest != gettime(DT_DAYOFMONTH) && isbegin_quest(120000)!=0){
							erasequest 120000;}
						
						if(#daily_quest != gettime(DT_DAYOFMONTH) && isbegin_quest(120000)==0){
							clear;
							soundeffect "menu.wav",0;
							mes "[^FF7700Quest Manager2^000000]";
							mes "Please hunt the follwing monster list";
							mes "-100 Poring";
							mes "-100 Fabre";
							mes "-100 Pupa";
							setquest 120000;
							#daily_quest = gettime(DT_DAYOFMONTH);
							end;
						}else{
							clear;
							soundeffect "menu.wav",0;
							mes "[^FF7700Quest Manager2^000000]";
							mes "You already receive daily quest for today";
							end; 
						}
						if(checkquest(120000,HUNTING)==2){
							clear;
							soundeffect "menu.wav",0;
							mes "[^FF7700Quest Manager2^000000]";
							mes "Well good for you";
							mes "here is your reward";
							completequest 120000;
							getitem 40221, 1;
							getexp2 700,650;
						end;
						}

 

there was no error, the npc simply does not detect as the quest was finish..?

 

[Racaae]

Hi. The script is using a if and else with both statements ending the conversation. Move the reward to before giving the quest.

Old:

if (#daily_quest != gettime(DT_DAYOFMONTH) && isbegin_quest(120000)==0) {
	mes "Please hunt the follwing monster list";
	END;
} else {
	mes "You already receive daily quest for today";
	END;
}

//THE NPC WILL NEVER GET TO THIS PART.

if (checkquest(120000,HUNTING)==2) {
	mes "here is your reward";
}

New:

if (checkquest(120000,HUNTING)==2) {
	mes "here is your reward";
	end;
}

if (#daily_quest != gettime(DT_DAYOFMONTH) && isbegin_quest(120000)==0) {
	mes "Please hunt the follwing monster list";
	end;
} else {
	mes "You already receive daily quest for today";
	end;
}