bubblegum not affecting @mi

[morrigon9]

hi,

 

good day everyone,

as stated on the title im having issue with @mi while using bubblegum.

 

i tried changing it in renewal.hpp and in conf/battle/gm.conf but still it changes nothing in @mi command

 

this is before using bubblegum

 

and this is after using bubblegum

 

 

im using ragexe 20180530 

[Chaos92]

4 hours ago, morrigon9 said:

hi,

 

good day everyone,

as stated on the title im having issue with @mi while using bubblegum.

 

i tried changing it in renewal.hpp and in conf/battle/gm.conf but still it changes nothing in @mi command

 

this is before using bubblegum

 

and this is after using bubblegum

 

 

im using ragexe 20180530 

its not changing at @mi or @monsterinfo if u are using bubble gum or HE gum.

[WhiteEagle]

17 hours ago, Chaos92 said:

its not changing at @mi or @monsterinfo if u are using bubble gum or HE gum.

It does.

[WhiteEagle]

Well, you can search in mob.cpp for:

if (src) {
		if (battle_config.drops_by_luk) // Drops affected by luk as a fixed increase [Valaris]
			drop_rate += status_get_luk(src) * battle_config.drops_by_luk / 100;
		if (battle_config.drops_by_luk2) // Drops affected by luk as a % increase [Skotlex]
			drop_rate += (int)(0.5 + drop_rate * status_get_luk(src) * battle_config.drops_by_luk2 / 10000.);

There should be a part with
 

if (sd->sc.getSCE(SC_ITEMBOOST))
                drop_rate_bonus += sd->sc.getSCE(SC_ITEMBOOST)->val1;

 

[Chaos92]

1 hour ago, WhiteEagle said:

It does.

well, it shouldn't as far as I know, because that's not how the calculation works.

https://github.com/rathena/rathena/issues/2203

@autoloot and @mobinfo are intentionally not affected by SC_ITEMBOOST. You will always autoloot the "original" items. Also it's not possible to get a loot chance of 100% (if it's not original) with SC_ITEMBOOST the maximum is 90%.

Try it again, by just counting your loot with and without SC_ITEMBOOST. You should see the effect.

Just a little addition to what @Jeybla said, "increased by" is different from "increased to"
https://www.divine-pride.net/database/item/12210/bubble-gum
What I mean is that "Item drop rate
increases by 100%" is not really raising the drop to 100% but instead it adds 100% of the current drop rate. In mathematical terms, if item1 currently has 1% chance of dropping, when you use bubble gum, it will be increased by another 1%
Hence,
Final drop rate = (100 + bubblegum_drop_mod)/100 x 1%
Final drop rate = (100 + 100)/100 x 1%
Final drop rate = 2 x 1%
Final drop rate = 2%

It's a different story when you say "Item drop rate is increased TO 100%" as sets the Final drop rate directly to 100%.

Just my 2 cents for future references.

Please correct me if I'm wrong since I referring to old issues that has been asked before in rathena.

[WhiteEagle]

You seem to have misunderstood his issue.
The problem is not about displaying the exact value with 5 decimal places or how its calculated ^^, but rather that nothing changes for him, whether with or without Bubble Gum active (SC_ITEMBOOST).
And you said, its not changing at @mi or @monsterinfo if u are using bubble gum or HE gum, but it does. I don't talk about the calculation for 100%, 200% or other SC_ITEMBOOST value.
Just, when you are using an Item with SC_ITEMBOOST, it's showing in @mi, that what he ask for.

Edited March 25 by WhiteEagle

[morrigon9]

1 hour ago, WhiteEagle said:

You seem to have misunderstood his issue.
The problem is not about displaying the exact value with 5 decimal places or how its calculated ^^, but rather that nothing changes for him, whether with or without Bubble Gum active (SC_ITEMBOOST).
And you said, its not changing at @mi or @monsterinfo if u are using bubble gum or HE gum, but it does. I don't talk about the calculation for 100%, 200% or other SC_ITEMBOOST value.
Just, when you are using an Item with SC_ITEMBOOST, it's showing in @mi, that what he ask for.

yes, this is my current issue. even after using bubblegum the percentage in @mi is not changing at all. I tried checking it in mob.cpp whiteeagle however I am quite not sure if I should change it because I think that is not the one causing the issue.

any Idea on how to display it in @mi? thank you for answering!

[WhiteEagle]

Looks like you use a really old version of rAthena.
Well, in atcommand.cpp, you can search for mobinfo and scroll down to // drops
In the latest rAthena, the part looks like this:

int droprate = mob_getdroprate( &sd->bl, mob, mob->dropitem[i].rate, drop_modifier );

            sprintf(atcmd_output2, " - %s  %02.02f%%", item_db.create_item_link( id ).c_str(), (float)droprate / 100);

So, if you want to get displayed in @mi your bubblegum, you need to add the part with the SC_ITEMBOOST in mob.cpp

[morrigon9]

15 hours ago, WhiteEagle said:

Looks like you use a really old version of rAthena.
Well, in atcommand.cpp, you can search for mobinfo and scroll down to // drops
In the latest rAthena, the part looks like this:

int droprate = mob_getdroprate( &sd->bl, mob, mob->dropitem[i].rate, drop_modifier );

            sprintf(atcmd_output2, " - %s  %02.02f%%", item_db.create_item_link( id ).c_str(), (float)droprate / 100);

So, if you want to get displayed in @mi your bubblegum, you need to add the part with the SC_ITEMBOOST in mob.cpp

hi white for rathena version this is the fullclient right? if it is im using the 20230404 one.

[hugebarren]

19 hours ago, WhiteEagle said:

You seem to have misunderstood his issue.
The problem is not about displaying the exact value with 5 decimal places or how its calculated ^^, but rather that nothing changes for him, whether with or without Bubble Gum active (SC_ITEMBOOST).
And you said, its not changing at @mi or @monsterinfo if u are using bubble gum or HE gum, but it does. I don't talk about the calculation for 100%, 200% or other SC_ITEMBOOST value.  dinosaur game
Just, when you are using an Item with SC_ITEMBOOST, it's showing in @mi, that what he ask for.

Decimals are the numbers, which consist of two parts namely, a whole number part and a fractional part separated by a decimal point. For example, 12.5 is a decimal number.

Edited March 26 by hugebarren

[WhiteEagle]

2 hours ago, morrigon9 said:

hi white for rathena version this is the fullclient right? if it is im using the 20230404 one.

You talk about the client date, not the rAthena version. Im confused how do you able to use rAthena when you don't know what rAthena is. xD