Custom Halter Lead Bug

[LewL]

i made a custom halter lead by copying it's item script

The Original

  - Id: 12622
    AegisName: Boarding_Halter
    Name: Reins Of Mount
    Type: Usable
    Flags:
      NoConsume: true
    Jobs:
      All: true
      Gunslinger: false
    Delay:
      Duration: 3000
      Status: All_Riding_Reuse_Limit
    Trade:
      Override: 100
      NoDrop: true
      NoTrade: true
      NoSell: true
      NoCart: true
      NoGuildStorage: true
      NoMail: true
      NoAuction: true
    Script: |
      setmounting();
    UnEquipScript: |
      if (ismounting()) setmounting();

 

i made 1 for Gunslinger

  - Id: 33014
    AegisName: Motorcycle_Key
    Name: Motorcycle Key
    Type: Usable
    Flags:
      NoConsume: true
    Jobs:
      Gunslinger: true
    Trade:
      Override: 100
      NoDrop: true
      NoTrade: true
      NoSell: true
      NoCart: true
      NoGuildStorage: true
      NoMail: true
      NoAuction: true
    Script: |
      setmounting();
    UnEquipScript: |
      if (ismounting()) setmounting();

the one i made for Gunslinger is working fine when i use it but when im on the mount and tried to use it again the mount wouldn't be release/remove

how do i fix it?

[Tokei]

Heya,

The Reins of Mount has special exceptions in the source. By default, while you are on a mount, you cannot use any item, and this includes the Reins of Mount itself. That is why there is an exception made for the item, and why you need to add an exception for your custom item as well.

In pc.cpp, look for "ITEMID_REINS_OF_MOUNT" in the pc_useitem function. Change 

if( nameid != ITEMID_REINS_OF_MOUNT && sd->sc.data[SC_ALL_RIDING] )

to

if( nameid != ITEMID_REINS_OF_MOUNT && nameid != 33014 && sd->sc.data[SC_ALL_RIDING] )

(Or in any other way you'd prefer, this is the most straightforward one I suppose.)

You may also want to look at other exceptions from ITEMID_REINS_OF_MOUNT and apply them too for yours. Goodluck!