Custom Skill Creation Guide?

[OscarScorp]

Hello everyone,

I have been looking for a proper and updated guide for creating a new custom skill / ability, but so far I've only found pieces of code here and there, and links to "rathena guides" lead me to 404 error, no page found.

If someone could help me out linking me a complete guide would be very much appreciated, otherwise, we could work together to build a proper and complete guide to create a new custom skill. Meaning, it should include:
- Modifying server-side files (such as skill.cpp, battle.c, skill.h, and so on).
- Adding Cooldown, Casting time to skill.
- Making a Passive, Active or Toggle ability.
- Adding a visual effect from the existing ones when using this ability.
- Modifying client-side files (such as skillid.lub, skilldescript.lub, skillinfolist.lub, skilltreeview.lub).
- Adding a custom BMP and SPR sprite to the Skill.
- Making it Platinum Quest required skill, meaning it should not be able to apply Skill Points when attempting to learn/level it up, because it would fail to learn/level up at the end.
- Common issues such as: "Skill forgotten/disabled when logging out, have to talk to Platinum Skill NPC to re-obtain/re-learn it,
 [Warning]: skill_castend_nodamage_id: Unknown skill used:10501.
 [Warning]: skill_castend_pos2: Unknown skill used:10500.
- Which text will be yelled in-game (i.e. "Double Strafe !!") or to make it so it does not say/yell anything at all.
- Revising anything else needed (such as new skill being affected by Vulture's Eye and Snake's Eye range,
 skill which requires a Cart equipped in order to be used,
 or skill unable to drag and drop to F12 bar.)

I will be waiting for your response,
Thanks in advance!

Edited October 21, 2017 by OscarScorp

[Cyro]

did u check this one? 

 

https://github.com/rathena/rathena/wiki/Adding_new_skills

 

Edited October 23, 2017 by Cyro

[OscarScorp]

Thanks for the link Cyro!
Sadly, it does not cover every point I'm looking for.

For example, I'm encountering this issue where, when the new skill is learned through an NPC (because it's a Platinum Skill) and the player levels up JOB, this new skill is forgotten (grayed out, unable to use). The player is forced to talk to the Platinum Skill NPC again in order to re-enable the new skill.

This appears in console when logging in:

[Warning]: mmo_char_fromsql: ignoring invalid skill (id=10500,lv=1) of character CHAR (AID=2000001,CID=150001)

EDIT:
Fixed by changing the Skill ID to 800 (found somewhere that IDs should be between 721 and 850 to "play it safe"), but this only resolves the issue of not showing a Warning error on console.
Forgetting skill when leveling Job up and logging in still remains.

Edited October 25, 2017 by OscarScorp