Endless Cellar Error

[Quesooo]

good day can someone help me how make endless cellar works on latest rathena files

 

maps are working also the last map is working

 

on this script not working any kind people can help thank you

 

heres the script

 

 

EndlessCellar.txt

[crazyarashi]

any specific errors in map server?

[Quesooo]

15 hours ago, crazyarashi said:

any specific errors in map server?

here are some but lots of errors

 

[Vietlubu]

56 minutes ago, Quesooo said:

here are some but lots of errors

 

 

has_instance has removed. You can check in is topic.

 

Edited October 19, 2017 by choidk

[Quesooo]

15 hours ago, choidk said:

has_instance has removed. You can check in is topic.

 

btw i do read this topic before but still cant fix it can you please help me to solve it

[Vietlubu]

8 minutes ago, Quesooo said:

btw i do read this topic before but still cant fix it can you please help me to solve it

You need to rewrite the script, a lot of modified. You can start with use new instance script commands.

I'm not sure but you can try to change something like this:

has_instance -> instance_mapname

With other fucntion has removed, you need to check in current script commands and change.

Good luck 

[Quesooo]

15 hours ago, choidk said:

You need to rewrite the script, a lot of modified. You can start with use new instance script commands.

I'm not sure but you can try to change something like this:

has_instance -> instance_mapname

With other fucntion has removed, you need to check in current script commands and change.

Good luck 

thank you for informations i already replace them and also the links on that topic are not working im stock on this problem any solution?

 

[Vietlubu]

19 hours ago, Quesooo said:

thank you for informations i already replace them and also the links on that topic are not working im stock on this problem any solution?

 

3

1. You if statement like this:

if(((EC_Lasttime + $EC_Cooldown > gettimetick(2) && EC_Lasttime < gettimetick(2)) || (EC_Lasttime > gettimetick(2) && EC_Lastinstid != instance_id(1))) && getgmlevel() < $EC_GM){

I'm not sure you current code but you can try to add 1 or 2 close parenthesis ) to end if statement.

2. Try to use this: set .@i,instance_id(0);

3. getmapmobs() already removed in rAthena.

Your script too old. I think you need to rewrite so much and not sure it can work.

[Quesooo]

15 hours ago, choidk said:

1. You if statement like this:

if(((EC_Lasttime + $EC_Cooldown > gettimetick(2) && EC_Lasttime < gettimetick(2)) || (EC_Lasttime > gettimetick(2) && EC_Lastinstid != instance_id(1))) && getgmlevel() < $EC_GM){

I'm not sure you current code but you can try to add 1 or 2 close parenthesis ) to end if statement.

2. Try to use this: set .@i,instance_id(0);

3. getmapmobs() already removed in rAthena.

Your script too old. I think you need to rewrite so much and not sure it can work.

i try that thank you

[Quesooo]

15 hours ago, choidk said:

1. You if statement like this:

if(((EC_Lasttime + $EC_Cooldown > gettimetick(2) && EC_Lasttime < gettimetick(2)) || (EC_Lasttime > gettimetick(2) && EC_Lastinstid != instance_id(1))) && getgmlevel() < $EC_GM){

I'm not sure you current code but you can try to add 1 or 2 close parenthesis ) to end if statement.

2. Try to use this: set .@i,instance_id(0);

3. getmapmobs() already removed in rAthena.

Your script too old. I think you need to rewrite so much and not sure it can work.

oh still not working im stock on this same error

[Vietlubu]

5 minutes ago, Quesooo said:

oh still not working im stock on this same error

What are you change? The code in my comment is your script (not the fixed code), you need to change it. add 1 or 2 close parentheses to end if statement.

[Quesooo]

15 hours ago, choidk said:

What are you change? The code in my comment is your script (not the fixed code), you need to change it. add 1 or 2 close parentheses to end if statement.

yes i also do that i add 2 or 1 ) to close the statement but still not working this is the edited  one that already have 1 error left

 

 

EndlessCellar.txt

[Vietlubu]

8 minutes ago, Quesooo said:

yes i also do that i add 2 or 1 ) to close the statement but still not working this is the edited  one that already have 1 error left

 

 

EndlessCellar.txt

Your current code at line 58:

if(set .@i,instance_id(0) && set .@i,instance_id(0) || set .@i,instance_id(0) && set .@i,instance_id(0))) && getgmlevel() < $EC_GM){

Please try change to this

if(set .@i,instance_id(0) && set .@i,instance_id(0) || set .@i,instance_id(0) && set .@i,instance_id(0) && getgmlevel() < $EC_GM){

 

Edited October 20, 2017 by choidk

[Quesooo]

15 hours ago, choidk said:

Your current code:

if(set .@i,instance_id(0) && set .@i,instance_id(0) || set .@i,instance_id(0) && set .@i,instance_id(0))) && getgmlevel() < $EC_GM){

Please try change to this

if(set .@i,instance_id(0) && set .@i,instance_id(0) || set .@i,instance_id(0) && set .@i,instance_id(0) && getgmlevel() < $EC_GM){

 

i tried it the error change

[Vietlubu]

1 minute ago, Quesooo said:

i tried it the error change

Why you define set function in if statement?

[Quesooo]

15 hours ago, choidk said:

Why you define set function in if statement?

what do you mean sir

[Quesooo]

15 hours ago, choidk said:

Your current code at line 58:

if(set .@i,instance_id(0) && set .@i,instance_id(0) || set .@i,instance_id(0) && set .@i,instance_id(0))) && getgmlevel() < $EC_GM){

Please try change to this

if(set .@i,instance_id(0) && set .@i,instance_id(0) || set .@i,instance_id(0) && set .@i,instance_id(0) && getgmlevel() < $EC_GM){

 

i do what you said here XD

[Vietlubu]

12 minutes ago, Quesooo said:

i do what you said here XD

I keep this because it forms your script file. My comment to fix if statement. But I don't understand why you use set function in if statement.
Why you use this in if statement: 

set .@i,instance_id(0)

Edited October 20, 2017 by choidk

[Quesooo]

15 hours ago, choidk said:

Your current code at line 58:

if(set .@i,instance_id(0) && set .@i,instance_id(0) || set .@i,instance_id(0) && set .@i,instance_id(0))) && getgmlevel() < $EC_GM){

Please try change to this

if(set .@i,instance_id(0) && set .@i,instance_id(0) || set .@i,instance_id(0) && set .@i,instance_id(0) && getgmlevel() < $EC_GM){

 

i follow this sir

[Vietlubu]

37 minutes ago, Quesooo said:

yes i also do that i add 2 or 1 ) to close the statement but still not working this is the edited  one that already have 1 error left

 

 

EndlessCellar.txt

In this file, your script, line 58. I see you have to define set in if statement. set .@i,instance_id(0). Why you use set function in if statement?

 

[Quesooo]

15 hours ago, choidk said:

In this file, your script, line 58. I see you have to define set in if statement. set .@i,instance_id(0). Why you use set function in if statement?

 

oh some one told me to do that i forgot who is he but any way how do i fix it sir

[Vietlubu]

58 minutes ago, choidk said:

1. You if statement like this:

if(((EC_Lasttime + $EC_Cooldown > gettimetick(2) && EC_Lasttime < gettimetick(2)) || (EC_Lasttime > gettimetick(2) && EC_Lastinstid != instance_id(1))) && getgmlevel() < $EC_GM){

I'm not sure you current code but you can try to add 1 or 2 close parenthesis ) to end if statement.

2. Try to use this: set .@i,instance_id(0);

3. getmapmobs() already removed in rAthena.

Your script too old. I think you need to rewrite so much and not sure it can work.

2

This comment to fix 3 errors in your image. only option 1 for if statement line 58. Option 2 and 3 for error in line 174 and 334.

[Quesooo]

15 hours ago, choidk said:

This comment to fix 3 errors in your image. only option 1 for if statement line 58. Option 2 and 3 for error in line 174 and 334.

ohw i already tried that but still not lucky

 

can you give me a fix 1 sir please

[Vietlubu]

37 minutes ago, Quesooo said:

ohw i already tried that but still not lucky

 

can you give me a fix 1 sir please

With line 58. Back to original: Not have any change

if(((EC_Lasttime + $EC_Cooldown > gettimetick(2) && EC_Lasttime < gettimetick(2)) || (EC_Lasttime > gettimetick(2) && EC_Lastinstid != instance_id(1))) && getgmlevel() < $EC_GM){

You can see instance_id(1). In current rAthena function instance_id() don't have any param so, you cannot add the argument to this function. Change you code line 58 to: I changed instance_id(1) => instance_id()

if(((EC_Lasttime + $EC_Cooldown > gettimetick(2) && EC_Lasttime < gettimetick(2)) || (EC_Lasttime > gettimetick(2) && EC_Lastinstid != instance_id())) && getgmlevel() < $EC_GM){

With this code, the error in line 58 will be fixed. But I think the function will not work correctly.

Please check your script, has many function instance_id(). It means has many errors with this.

If you keep argument for  instance_id() => has error

If you remove argument => logic feature will be wrong.

For the best way, I think you need to contact the author of the script in this topic. Or hire a dev in Third-Party Services to write new script compatible with new rAthena.

Edited October 20, 2017 by choidk

[Quesooo]

16 hours ago, choidk said:

With line 58. Back to original: Not have any change

if(((EC_Lasttime + $EC_Cooldown > gettimetick(2) && EC_Lasttime < gettimetick(2)) || (EC_Lasttime > gettimetick(2) && EC_Lastinstid != instance_id(1))) && getgmlevel() < $EC_GM){

You can see instance_id(1). In current rAthena function instance_id() don't have any param so, you cannot add the argument to this function. Change you code line 58 to: I changed instance_id(1) => instance_id()

if(((EC_Lasttime + $EC_Cooldown > gettimetick(2) && EC_Lasttime < gettimetick(2)) || (EC_Lasttime > gettimetick(2) && EC_Lastinstid != instance_id())) && getgmlevel() < $EC_GM){

With this code, the error in line 58 will be fixed. But I think the function will not work correctly.

Please check your script, has many function instance_id(). It means has many errors with this.

If you keep argument for  instance_id() => has error

If you remove argument => logic feature will be wrong.

For the best way, I think you need to contact the author of the script in this topic. Or hire a dev in Third-Party Services to write new script compatible with new rAthena.

i think im little bit closer  this is my error now

 

[crazyarashi]

i only changed the instance creation/enter phase part of the script so im not really sure if it the whole instance script will work havent tested it
cellar.txt

Edited October 20, 2017 by crazyarashi