Drop rate exceeding 100%

[Cinquedea]

I was wondering why my drop rate has exceeded 100% in spite of my drop rate which is only 600(x6).

The sticky mucus now has a chance of 120% drop rate. Is there a way to make it max to 100% even if I set the drop rate higher than it is now?

Pls see attached screenies for reference. I'm using rAthena version in Github Thanks in advance.

[Playtester]

Maybe you increased the maximum drop rate above 10000?

[Cinquedea]

No, i left everything untouched exept for the drop rate that i mentioned above.

[mytus001]

 

It can be vip'esta with very high value drope

[Emistry]

No, i left everything untouched exept for the drop rate that i mentioned above.

perhap you should show your settings/changes here.

[Cinquedea]

here's my settings.. I dunno what I did wrong. I hope this helps..

I just set my drop rate to 500%(x5) then an additional VIP drop to 100%.. which sums up to 600%

 

I'm having a feeling that the vip bonus drop overlaps with the current drop rate and doubles the amount which adds additional 20% to the drop chance that makes it 120% instead of 100% max.

 

I also have a similar topic in the source support which has no reply since 4/28/16:

https://rathena.org/board/topic/105723-vip-drop-rate-bonus/

 

 

// Item drop increase. Setting to 0 will disable.

// Note: 50 = 50% item_drop increase.

"// For item_rate = 200: 200 * 50 / 100 = 100 bonus rate added to the 200 base giving total rate of 300."

// Default: 50

vip_drop_increase: 20

Edited May 6, 2016 by Cinquedea

[Playtester]

It's just a display issue, drop rate still is 100%.

 

The drop rate is properly capped to 100% in mob.c::mob_dead.

 

Only the @mi command doesn't cap it in the display, check atcommand.c

#ifdef VIP_ENABLE
			// Display item rate increase for VIP.
			if (pc_isvip(sd) && battle_config.vip_drop_increase)
				droprate += (droprate * battle_config.vip_drop_increase) / 100;
#endif

This code isn't so good because it uses a different formula than what is used in mob_dead. You could just remove it so it no longer is displayed in @mi or copy what is used in mob.c:

			// Increase item drop rate for VIP.
			if (battle_config.vip_drop_increase && (sd && pc_isvip(sd))) {
				drop_rate += (int)(0.5 + (drop_rate * battle_config.vip_drop_increase) / 100);
				drop_rate = min(drop_rate,10000); //cap it to 100%
			}

[Cinquedea]

Replacing the 

#ifdef VIP_ENABLE
			// Display item rate increase for VIP.
			if (pc_isvip(sd) && battle_config.vip_drop_increase)
				droprate += (droprate * battle_config.vip_drop_increase) / 100;
#endif

gives error in compiling... But removing it solves the problem.. But another problem has occured, the drop chance in @mi of non-VIP and VIP players are the same. 

You're a great help, anyway...

Edited May 9, 2016 by Cinquedea

[Playtester]

You can't just replace it with the code in mob.c, you will need to code it yourself to do the same thing.

 

And removing it will still give VIP users more drops, they just won't see it with @mi.

 

Y'know something like:

                drop_rate += (int)(0.5 + (drop_rate * battle_config.vip_drop_increase) / 100);
                drop_rate = min(drop_rate,10000); //cap it to 100%

 

But of course in mobinfo the drop rate variable is called "droprate" and I'm not sure if you can do the rounding the same way, needs to check if it's the same variable type and stuff. Just too lazy to do it now as it's a really simple coding issue.