Ninja [Final Strike] damage BUG

[fallen0519]

I am using r17704, I see that ninja Final Strike damage is bug, whenever your vit is 1 or 9999 the damage didn't increase, since the description written increase while the NINJA hp increasing. Following is the src code for skills. Can anyone tell me how to fix this? Hmm.....

#else
		case NJ_ISSEN:
			wd.damage = 40 * sstatus->str + (8 / 100) * skill_lv * sstatus->hp;
			wd.damage2 = 0;
			break;
		case LK_SPIRALPIERCE:
		case ML_SPIRALPIERCE:
			if (sd) {
				short index = sd->equip_index[EQI_HAND_R];

				if (index >= 0 &&
					sd->inventory_data[index] &&
					sd->inventory_data[index]->type == IT_WEAPON)
					wd.damage = sd->inventory_data[index]->weight*8/100; //80% of weight

				ATK_ADDRATE(wd.damage, wd.damage2, 50*skill_lv); //Skill modifier applies to weight only.
			} else {
				wd.damage = battle_calc_base_damage(sstatus, &sstatus->rhw, sc, tstatus->size, sd, 0); //Monsters have no weight and use ATK instead
			}

			i = sstatus->str/10;
			i*=i;
			ATK_ADD(wd.damage, wd.damage2, i); //Add str bonus.
			switch (tstatus->size) { //Size-fix. Is this modified by weapon perfection?
				case SZ_SMALL: //Small: 125%
					ATK_RATE(wd.damage, wd.damage2, 125);
					break;
				//case SZ_MEDIUM: //Medium: 100%
				case SZ_BIG: //Large: 75%
					ATK_RATE(wd.damage, wd.damage2, 75);
					break;

Edited March 30, 2014 by fallen0519

[Kichi]

wd.damage = 40 * sstatus->str + (8 / 100) * skill_lv * sstatus->hp;

example:

level 1 Final Strike

(STR*40) + (HP*8%)

mean VIT 1 / 9999 will not affect the damage (based on formula)

only STR and HP are affect the damage.

As long as your HP increase, your damage will be increase.

Or there are max damage limit

[nemesis1987]

same here there's a bug in final strike damage can anyone help us thanks in advance

[Normynator]

Do you have activated renewal?

[chriser]

https://github.com/rathena/rathena/commit/1d1a58cdcb88fb0ba294d3ba827a1da653598cbe#commitcomment-6061944

 

the issue was fixed here:

 

https://github.com/rathena/rathena/commit/f7c09d95fdf0825f2c10fab8b516681797fa4f44#diff-d96b6365b4bdad78139e676d6e7e3295

Edited October 26, 2014 by chriser