Need tester for MaxHP - MaxSP calculation

[Cydh]

Related this conversation until the last comment from @Lighta

 

We need to re-structure the MaxHP and MaxSP calculation, because well, current calculation give us far away from official MaxHP/SP calculation. For u that play official servers, you can compare our current MaxHP/SP with official server. (well, I tested on idRO)

 

Here, I need someone can test this diff.

• If you have official account, you can check, if the max HP/SP results are good for mob, hom, etc with/without buff. Maybe the problem like "my hom didn't get any HP/SP bonus from buff", "the HP/SP of X isn't calculated", "the mob with buff skill to add maxHP, after it casting the skill, the MaxHP isn't added", etc.
• If you don't have official account, what I need, please check the HP/SP for each ur chars there, then try give same equips, stats, cards, levels, jobs (that will affected HP/SP) on ur rAthena after this diff.

The references are http://irowiki.org/wiki/Max_HP and http://irowiki.org/wiki/Max_SP

 

And this diff, will throw away the job_maxhpsp_db.txt which unused here, except someone has idea to keep it as Max HP/SP limiter instead on current limiter on battle conf.

 

diff: status_maxhpsp.diff

 

Changes:

Implemented new and updated configs:

• max_parameter: 99
• max_trans_parameter: 99
• max_third_parameter: 135
• max_third_trans_parameter: 135
• max_baby_parameter: 80
• max_baby_third_parameter: 108
• max_extended_parameter: 125 (Oboro/Kagerou and Rebellion)

Added:

• db/pre-re/job_param_db.txt
• db/re/job_param_db.txt

Removed:

• db/pre-re/job_maxhpsp_db.txt
• db/re/job_maxhpsp_db.txt

Can be test them online (ingame), here.

or just add this connection on clientinfo.xml

<connection>
<display>ChyraRO!</display>
<balloon>ChyraRO!</balloon>
<desc>ChyraRO!</desc>
<address>198.23.187.123</address>
<port>6900</port>
<version>45</version>
<langtype>1</langtype>
<registrationweb>http://pservero.com/chyraro</registrationweb>
</connection>

[Cydh]

moved from staff discussion

[exneval]

 static bool pc_readdb_job1(char* fields[], int columns, int current){
 	int idx, class_;
 	unsigned int i;
 #ifndef HP_SP_TABLES
-	unsigned int k = 0, val;
+	unsigned int k = 0;//, val;
 #endif

wrong diff I guess?

[Cydh]

yeah just leftover. updated the attached file

 

hmm, just think better if I make branch for this.

 

but hmm, I'm still war with inactive admins

[exneval]

haha, just keep it flow agan cydh, time will tell,

for the diff, i want try it in iRO, i have an aco in there

Edited December 11, 2013 by exneval

[Cydh]

haha, just keep it flow agan cydh, time will tell,

for the diff, i want try it in iRO, i have an aco in there

 

my IP can't reach iRO. 

I just can try it on idRO, on my first tests, the results are good.

[exneval]

just commit it out, if the result already good

[Cydh]

just commit it out, if the result already good

 

it's only good for me, but it's not great if no one can confirm. and I don't want make critical bug (for users who always update) and need me to stand-by a whole day to fix the bug encounter

[Cydh]

if anyone want try it on my server, here u go https://db.tt/91Pc4NBI

 

NOTE: I just got 100Mbit connection for that VPS, F2P, don't give any DDoS :v

[Kido]

downloading it, i hope with my lilttle help i can contribuate to something :DD!

the client does not run D:

Edited December 18, 2013 by Kido

[Cydh]

then, just go add this connection on clientinfo.xml

<connection>
<display>ChyraRO!</display>
<balloon>ChyraRO!</balloon>
<desc>ChyraRO!</desc>
<address>198.23.187.123</address>
<port>6900</port>
<version>45</version>
<langtype>1</langtype>
<registrationweb>http://pservero.com/chyraro</registrationweb>
</connection>

[GmOcean]

So what were trying to test here, is that it my be more effecient to calculate the max HP/SP all through src, without the use of a table? Seems, good, but would it not be better to have a db/conf file that does this for us so to speak. Example:

db file, will consist of what we have now more or less...

and conf file, will just have modifier changes like:

//Vit HP percent modifier. Increase HP by x/10000% of MaxHP per vit. ( 0 to disable )
vit_permodifier: 1
//Vit HP Base modifier. Increase HP by x per vit. ( 0 to disable )
vit_basemodifier: 50

//Int SP percent modifier. Increase SP by x/10000% of MaxSP per int. ( 0 to disable )
int_permodifier: 1
//Int SP Base modifier. Increase SP by x per int. ( 0 to disable )

Now, I don't know how realistic or functional this may seem, but if the only reason were changing the calculation is because were not equal to official servers, perhaps were taking the wrong approach in trying to find the right formula and could get it done by doing something like this.

[Cydh]

ahh thx guys for talking and watching this, this is going to anywhere. and even some f****** admins not give any response, thx god.