Serious Issue with weapon research

[iraciz]

SOMETHING IS WRONG IN THE Trunk/SCR/map/ BATTLE.C  OF THE VERSION SVN 17516

 

THE WHOLE THING HAS BEEN CHANGED FROM 1 REVISION TO ANOTHER

THERES NO WAY TO FIND OUT WICH LINE WE HAVE TO EDIT IN ORDER TO APPLY THE DAMAGE OF THE WEAPONRESEARCH

as it should be!

 

this is battle.c line of a funcional bs_weaponresearch

THE WEAPON RESEARCH WORKS PERFECTLY HEARE

if( sd ) {
            // Weaponry Research hidden bonus
            if ((skill = pc_checkskill(sd,BS_WEAPONRESEARCH)) > 0)
                hitrate += hitrate * ( 2 * skill ) / 100;

            if( (sd->status.weapon == W_1HSWORD || sd->status.weapon == W_DAGGER) &&
               (skill = pc_checkskill(sd, GN_TRAINING_SWORD))>0 )
                hitrate += 3 * skill;
        }

        hitrate = cap_value(hitrate, battle_config.min_hitrate, battle_config.max_hitrate);

        if(rnd()%100 >= hitrate)
            wd.dmg_lv = ATK_FLEE;
        else
            flag.hit = 1;
    }    //End hit/miss calculation

this is  other  line in the same document where I found something about the bs_weaponresearch and shows the following

//Here ends flag.hit section, the rest of the function applies to both hitting and missing attacks
      else if(wd.div_ < 0) //Since the attack missed...
        wd.div_ *= -1;


    if(sd && (skill=pc_checkskill(sd,BS_WEAPONRESEARCH)) > 0)
        ATK_ADD(skill*2);

now this is the newer version, that LACKS DAMAGE APPLICATION

if(sd && (skill=pc_checkskill(sd,BS_WEAPONRESEARCH)) > 0) // weapon research bonus applies to all weapons
        damage += skill*2;
        
    if(sd->sc.data[SC_GN_CARTBOOST]) // cart boost adds mastery type damage
        damage += 10*sd->sc.data[SC_GN_CARTBOOST]->val1;

    return damage;
}

This is other line in the same document thatn mention bs_weaponresearch

if( sd ) {
        // Weaponry Research hidden bonus
        if ((skill = pc_checkskill(sd,BS_WEAPONRESEARCH)) > 0)
            hitrate += hitrate * ( 2 * skill ) / 100;

        if( (sd->status.weapon == W_1HSWORD || sd->status.weapon == W_DAGGER) &&
            (skill = pc_checkskill(sd, GN_TRAINING_SWORD))>0 )
            hitrate += 3 * skill;
    }

    hitrate = cap_value(hitrate, battle_config.min_hitrate, battle_config.max_hitrate);
    return (rnd()%100 < hitrate);
}

I tried to replace that, but I got compile errors, due to the high sensitivity of this new version, console is more rude and detect a lot of errors and warnings that did'nt appear in previous revisions

 

I will attach my battle .c

 

please, fix  my file, I realy need get this solved, 

• Normal hits can miss based on the player's hit and the target's flee. However, when any skill or regular attack "misses", a small damaged hit is still guaranteed from Weaponry Research. We use CT, This means the player will always have a chance to stun their opponent whether their attack "misses" or deals full damage.

 

I have my battle.c in this link, please fix that bug 
http://www.mediafire.com/?gvpj9zb57okemjk

I cant, use a new version, because I have some moods in the battle c and i dont want to lose some changes

OR REPLACE THE WHOLE VERSION TO OTHER, UNDERSTAND PLEASE

bump

I will wait for this one! pre renewal somebody please fix thath error I cant change my version

Edited October 27, 2013 by Patskie
Change to code

[iraciz]

 HEAD REVISION 17528   AND SAME PROBLEM