Effect of Abyss Knight Card

[Dori]

I'm wondering if it is possible to make the effect of abyss knight card the way it was in pre-renewal.

In renewal this card is absolute garbage. In pre-renewal, with 4 abyss knight cards the damage was almost doubled, but in renewal the damage is barely raised.

Is there anyway to fix this without having to go pre-renewal? Any help or suggestions would be appreciated. thanks~

Edited July 8, 2013 by Phenex

[Jaburak]

You need this; http://rathena.org/board/files/file/2822-card-effect-stack-limit/

[Emistry]

the attack calculation in re has changed alot .... not sure with card effects stacking issue.

[Dori]

Yeah it's not a stacking issue. I tested this out and 1 abyss knight card would raise the damage by like 200... Which is really really low.

[helvetica]

In Renewal cards were changed to raise equipment and weapon ATK only, not total ATK, so there's a less pronounced gain from them. Status ATK, the ATK coming from STR/DEX/LUK is completely unaffected by cards or any sort of ATK increasing. Conversely it's also considered purely neutral, so it also doesn't gain any benefits from element EXCEPT in the case of Mild Wind (to allow Taekwons to actually do damage )

 

Renewal was a very large nerf against overupgraded quad compounded level 1 weapons, and a dramatic shift to make level 3/4 weapons far more valuable.

 

If you want to partially restore the old behavior without completely committing to Pre-Renewal formulas, apply the following diff:

 

Index: src/map/battle.c
===================================================================
--- src/map/battle.c    (revision 17407)
+++ src/map/battle.c    (working copy)
@@ -4316,6 +4316,7 @@
                //Card Fix for attacker (sd), 2 is added to the "left" flag meaning "attacker cards only"
                wd.weaponAtk += battle_calc_cardfix(BF_WEAPON, src, target, battle_skill_get_damage_properties(skill_id, wd.miscflag), right_element, left_element, wd.weaponAtk, 2, wd.flag);
                wd.equipAtk += battle_calc_cardfix(BF_WEAPON, src, target, battle_skill_get_damage_properties(skill_id, wd.miscflag), right_element, left_element, wd.equipAtk, 2, wd.flag);
+               wd.statusAtk += battle_calc_cardfix(BF_WEAPON, src, target, battle_skill_get_damage_properties(skill_id, wd.miscflag), right_element, left_element, wd.statusAtk, 2, wd.flag);
                if( is_attack_left_handed(src, skill_id )) {
                        wd.weaponAtk2 += battle_calc_cardfix(BF_WEAPON, src, target, battle_skill_get_damage_properties(skill_id, wd.miscflag), right_element, left_element, wd.weaponAtk2, 3, wd.flag);
                        wd.equipAtk2 += battle_calc_cardfix(BF_WEAPON, src, target, battle_skill_get_damage_properties(skill_id, wd.miscflag), right_element, left_element, wd.equipAtk2, 3, wd.flag);

This will apply card bonuses to status ATK. Be forewarned a lot of the skills were adjusted and rebalanced to take into the lower effect status ATK has and this will likely throw a lot of damage numbers out of proportion. Status ATK still will not receive any bonuses from weapon element/endows, but if you wish to revert that as well it's only a few more lines of code.

[Dori]

Thank you for the detailed reply! Now it makes alot more sense to me. And yes I would like to have the bonuses from weapon elements as well. Could you let me know which lines I must edit for that?

[lchtea120]

is this correct?....still not effective

#ifndef RENEWAL
//Card Fix for attacker (sd), 2 is added to the "left" flag meaning "attacker cards only"
wd.weaponAtk += battle_calc_cardfix(BF_WEAPON, src, target, battle_skill_get_damage_properties(skill_id, wd.miscflag), right_element, left_element, wd.weaponAtk, 2, wd.flag);
wd.equipAtk += battle_calc_cardfix(BF_WEAPON, src, target, battle_skill_get_damage_properties(skill_id, wd.miscflag), right_element, left_element, wd.equipAtk, 2, wd.flag);
+
wd.statusAtk += battle_calc_cardfix(BF_WEAPON, src, target, battle_skill_get_damage_properties(skill_id, wd.miscflag), right_element, left_element, wd.statusAtk, 2, wd.flag);
if( is_attack_left_handed(src, skill_id )) {
wd.weaponAtk2 += battle_calc_cardfix(BF_WEAPON, src, target, battle_skill_get_damage_properties(skill_id, wd.miscflag), right_element, left_element, wd.weaponAtk2, 3, wd.flag);
wd.equipAtk2 += battle_calc_cardfix(BF_WEAPON, src, target, battle_skill_get_damage_properties(skill_id, wd.miscflag), right_element, left_element, wd.equipAtk2, 3, wd.flag);
#endif
}